From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51473: [PATCH] Enable xwidget scrolling optimizations, and other xwidgets improvements Date: Fri, 05 Nov 2021 15:34:23 +0800 Message-ID: <87mtmj9hts.fsf@yahoo.com> References: <87zgqslafe.fsf.ref@yahoo.com> <87zgqslafe.fsf@yahoo.com> <875yt7plc1.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15741"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 51473@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 05 08:35:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mitkm-0003uN-RC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 08:35:12 +0100 Original-Received: from localhost ([::1]:60326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mitkk-0002W9-ID for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 03:35:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mitkc-0002Vt-CD for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 03:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mitkc-0008Ro-3Q for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 03:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mitkb-00016L-TT for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 03:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Nov 2021 07:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51473-submit@debbugs.gnu.org id=B51473.16360976804190 (code B ref 51473); Fri, 05 Nov 2021 07:35:01 +0000 Original-Received: (at 51473) by debbugs.gnu.org; 5 Nov 2021 07:34:40 +0000 Original-Received: from localhost ([127.0.0.1]:44728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mitkG-00015W-61 for submit@debbugs.gnu.org; Fri, 05 Nov 2021 03:34:40 -0400 Original-Received: from sonic317-34.consmr.mail.ne1.yahoo.com ([66.163.184.45]:40053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mitkE-00015C-L8 for 51473@debbugs.gnu.org; Fri, 05 Nov 2021 03:34:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636097672; bh=l6zIwFSLrefOHC+P4eU+4Rn4nf+1CDodL1DjqD6Q4B8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Fe/Cx9b+dbYJKhX7KMm4EG7RZdF+6AxRTTGsHOzhbjyYXBDJGpnwJqklhPONNR2fKlWjceCt2h6a8clZti4gaKQKYe4gZLYUwY9ptm5Ygtyek7qpcQ5W0qg2+J6MA0irx7HTnnvtw2is0AhaSIELNeU2j+qHJGN+vWK5HU+2AjIj9Qiud4KoVbaC0jnFFuQXT86AiogMJwGk6r2bluH8WVglChZqbM2bCcxnqQpWwU5nfM21D7PFUI0Lbh0og94VECWIVUr7Yhv1np116cp77ziTvNKeZkQ5iKhVGRlKFPfzSCL9r8/90N0QVlK+Gud1m23CHNAfrRobvjSc+lmoKA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636097672; bh=LfP0ExUHzrTaEUJkL966nwNhkjjZnpsH4Ifxo1ejZhr=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=GReVnzct2OZ0cYcDxdKJo0a0/YNVcAHAKA/zUgKWn1JELn/UHzfWHQDRUYpu5xMBFTIEwKidQcyK4L3dDjl3iCJEoo01zxh1akDWBKkLAk5sT/DKEygK0+1JRY2P+ovfd7mSPX2ie/lkY12MbOJBWALJWVz7To5dhoaQDE7WGic5X9k9l5r/EK84/LbtX3CVym43b35bgf9bdhsH3sF3lNaL4Ma7RU4+oGcyhA/L1+XCwfClFZ8Q0GIO1S7mmB8u39cJR9UvvgBvxh0PqveIqin1HtE7S/AiKjYP0m+qefsdI6y3yLLe5XTwehFLfrVUWwIkEaa6SNEummcrcNwURA== X-YMail-OSG: Wm2uQYAVM1n4QSiPm7kvAM8SoCRWuEx3IyJf4soKaRm5vGpIfDpU6_csqpQ6qUV QAbAi171kk1.CQuWQtQUCH2PKZ95Yy3xQeD.zCBSpR1kBDcQkYPiBzef8M_SuZQL6z3q4lsFVmDt d8VBFQXISds73_wIDMGOrE9VJTSNZfaVYbXzJsHdaTkLvd5_N.AhAnG.VGrBSfwOUVs4yGor3omT QRU2Cfhoqb0ahCcV4ExMUghDHM9U0b.nRCqxMdB8l3axnJibV1zAvyMVmJXB_OMSWGHuU8qR4jk8 CPIAyI2rPv.v_5Cpom5VWPosz7UbYvfAW69eImCF4mW1wi79oYz1zBifFldN5K2jA5.Yz5RJ_Sqh ICKfEAiLXl_B6c.DQWCXkpubK0yM66tBRXF_ndt09Wvmb1byo5Wm_.qhKFaxvTm8TlhycTCsgNI5 g1q9XhPsTSFzafs60Ue9S2i9Uqe5zskxf2XVuFPnUWam3.SuOIqsQJrHkoyoUc4aZQci7ALPFk5Z is1XhraYTLLpRwlS6nGlg6IrZO5o0XTIfl8023P_gt3do.TcpkxnOVl59uEE54qCVE8pVobzo.QV dozuiuTaJo8PCZHYgar4UCwzfv6WVtXYEwiI_.sssuD70RfiOz0n9gzJy1oUFtaVOjkUUA5QwQx5 wCSY96EWFt23S0zSU.RYN2kJ0gx3BQj3oF_hTHRCg9eSrrMUBkSUl9GP7wtgL.L.QIuZc4zo.iNp l0eWAioQBquXChqXH6amQYufxubmcVqULA50X.Fp8g6hBUii.k5eNmoZLfM_qTaNRecT.pL5uBef fmEkR1HVSW54ydPAP6ZN9WjBvrDQP0qiH0Zx7f4VB1 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 5 Nov 2021 07:34:32 +0000 Original-Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 12b1cdd9bd06f9ca7ccfff1ce6ee2fdd; Fri, 05 Nov 2021 07:34:27 +0000 (UTC) In-Reply-To: <875yt7plc1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 05 Nov 2021 00:11:58 +0100") X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218981 Archived-At: Lars Ingebrigtsen writes: > Sounds good... > >> Someone with access to a Mac will have to do the changes necessary for >> xwidget scrolling to work correctly on macOS, as they don't work on >> GNUstep in the first place. > > Does this mean that these patches will break the Macos build? I tried my best to keep it working, but the scroll optimization will not function there. > I'm not really that familiar with how xwidget works, so er does this > mean that the events work less with your patch than before? Yes, but I fixed that, and defined a new facility for sending events to xwidgets from Lisp code in a few other changes. Should I squash them or send the new commits as individual patches? Thanks. > I'm unable to test this at all, because: > ** (emacs:2173922): ERROR **: 00:09:01.997: GApplication is required for xdg-desktop-portal access in the WebKit sandbox. > Fatal error 5: Trace/breakpoint trap > This is on Debian/bookwork. (And without your patch, just building with > xwidget and `M-x xwidget-webkit-browse-url RET fsf.org RET', and Emacs > crashes.) This is probably the same WebKitGtk bug that also happens on Fedora. Can you tell me the version of your WebKitGtk package and GLib? If you can't upgrade/downgrade, continually retrying could help.