From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Fri, 19 Nov 2021 08:12:30 +0100 Message-ID: <87mtm0wrdt.fsf@gnus.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <878rxq62qt.fsf@gnus.org> <83k0hatxjl.fsf@gnu.org> <875ysu2d18.fsf@gnus.org> <83y25pshaa.fsf@gnu.org> <874k8c8sg0.fsf@gnus.org> <83ilws16hj.fsf@gnu.org> <87wnl8qg8b.fsf@gnus.org> <83czn0123n.fsf@gnu.org> <83v90pwcab.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31151"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: luangruo@yahoo.com, tumashu@163.com, 51821@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 19 08:15:03 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mny6x-0007sL-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 08:15:03 +0100 Original-Received: from localhost ([::1]:33868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mny6v-0007Ag-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 02:15:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mny50-0006Qj-HV for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 02:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mny50-0003VG-88 for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 02:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mny4z-0002Vi-Pt for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 02:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2021 07:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.16373059639622 (code B ref 51821); Fri, 19 Nov 2021 07:13:01 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 19 Nov 2021 07:12:43 +0000 Original-Received: from localhost ([127.0.0.1]:37779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mny4g-0002V8-TP for submit@debbugs.gnu.org; Fri, 19 Nov 2021 02:12:43 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:57162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mny4e-0002Uq-Ey for 51821@debbugs.gnu.org; Fri, 19 Nov 2021 02:12:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VL0q7q9rLA2Mqq/hfOiCIikry6wGm509alnkoEqqbPc=; b=H1Q5xljP2zQ9BguLyhpi5h3DNV zS8MVhfRuRRHA5XdbrwLCb/LAgJTZau+LaOaSSydvOZ2ZSR/92jXbwoZoze590gSfyE9zIybVtqvA 04csqPyIJxhsl25g5WQyDzYZpxF+hI4Cm1G9c9B3JolJdt6vsYGvqINzkZiv506RaCkA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mny4V-00085u-GD; Fri, 19 Nov 2021 08:12:33 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAM1BMVEUIAgESCQUZEhIv IhxWUVU8PEKtc07Klm64hl6VZU2LUDbbr41tSDPmwKRWMiKGPy/////XM7RvAAAAAWJLR0QQlbIN LAAAAAd0SU1FB+ULEwcHD2WQdCIAAAGESURBVEjHzZbbkoMgDIYlkXCK+P5vu3+03TqzpcSZXmwc tCP5ciJgl+WU8FeW78ode4TBKw0m+fl8mWSKTByZ4xsgrjHSipuNeJrlFRderHzN9vGbYCdGU4km 5u8wHAYR2Ux4RX5GxF+u37+RYKndWE2WlAs7+8lWoqbUWlIfAS1ObdtAdKc+CRwYkJ0xVclp87tY qKuqACjqA0IvTUAUFfXEhCVglaKp1FI9AFcDZM+pM3sAKOfWZEepstJcP6hg0ZBEaXg6sg69gtik 9wpH6sl5L9YXJefkBLRkhI/Fg/RpywbzICJ1x5XnAFqV6wHUUtAivMw7ltQAbAiIkAOAC7Gl2FpK JUyA43xCYYsRSJyXGXBYDNzRsLWqdcbniEyb6DwimUzb3nwGMMjUrfHC44y9KIxSQVB8MTKr04HQ 1O7v7M0vXDhK5T3DnoTb+nnrnp12pSjJiThdhUWT9ekJOCBzMdxrA163NPj20YCQkYv3JcSJ3yS8 ez+Wkm6Wlt8kgT8YP9dSCuh1YiRUAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTExLTE5VDA3OjA3 OjE1KzAwOjAw8tFOqQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMS0xOVQwNzowNzoxNSswMDow MIOM9hUAAAAASUVORK5CYII= X-Now-Playing: June Tabor's _Airs and Graces_: "Plains of Waterloo" In-Reply-To: <83v90pwcab.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Nov 2021 20:26:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220368 Archived-At: Eli Zaretskii writes: > + DEFVAR_LISP ("line-height-factor", Vline_height_factor, > + doc: /* Factor for enlarging the height of lines that use the default font. > +The value should be a float number greater than 1. It determines how > +much will Emacs enlarge the height of a screen line that shows only > +characters displayed with the default face's font for ASCII characters. > +This is to avoid differences in height between lines that use the > +ASCII font and those which use non-ASCII (for example, Chinese) > +font, which is typically higher than the ASCII one. */); Is tying this to the default font the best solution, though? Emacs (by default) uses at least two fonts -- one monospaced and one that's proportional, and this will only fix the first issue. So I think the original idea (adding a line-height parameter/variable) would fix this issue in a more general way. Testing the patch, it also affects the height of faces with :height in them, meaning that separator lines get much taller than they should be. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no