From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#52194: 28.0.50; [PATCH] Put paid to a flappy test module Date: Tue, 30 Nov 2021 14:41:32 +0100 Message-ID: <87mtll3gmr.fsf@gmail.com> References: <87pmqimnia.fsf@dick> <87sfve3pce.fsf@gmail.com> <87bl21pyuv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18331"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52194@debbugs.gnu.org, dick.r.chiang@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 30 14:42:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms3Op-0004Zd-I7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 14:42:23 +0100 Original-Received: from localhost ([::1]:36426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ms3On-00078Y-UC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 08:42:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ms3OU-00075T-8y for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ms3OT-0002fY-Ro for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ms3OT-0001sw-QX for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Nov 2021 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52194 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix patch Original-Received: via spool by 52194-submit@debbugs.gnu.org id=B52194.16382797067221 (code B ref 52194); Tue, 30 Nov 2021 13:42:01 +0000 Original-Received: (at 52194) by debbugs.gnu.org; 30 Nov 2021 13:41:46 +0000 Original-Received: from localhost ([127.0.0.1]:40432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms3OE-0001sO-Ai for submit@debbugs.gnu.org; Tue, 30 Nov 2021 08:41:46 -0500 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:36399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms3O8-0001s8-Sa for 52194@debbugs.gnu.org; Tue, 30 Nov 2021 08:41:44 -0500 Original-Received: by mail-wr1-f50.google.com with SMTP id s13so44586494wrb.3 for <52194@debbugs.gnu.org>; Tue, 30 Nov 2021 05:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=HmN7zghfh3IIqG2ykshd/i7hNlch4y9uSqw2elA7QaE=; b=jYHuKLxFoSgoUwMDBFmfidsuMDnM2mBTI8tLivEs4J/fkh0HamNoQWAfmulJyCZAZS AN0Kkkd2KmG72bX8RhDHCpt7JuZIt0FLprHQSxKDhOAwmCSU4VLGZWyefgofKv9odBlL hw1qw5WVRP/hE0Y71QFYbIg7BMPY23lbM64CfKzgTWs6cUfDsvhFZMWetqNaRJBdOtCm kIETISouzlurmR7K0YsQ4zJUoJFepnUeobCIiCLFf0aNQdlxXjKgWwguEMJZ3TlfNJH7 krKsfUcnj/QTensEdUYjMb2/DlHO34vbfIdCLoY616ghrH9XkjFugb1NwUEhHlhpNBC6 aDaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=HmN7zghfh3IIqG2ykshd/i7hNlch4y9uSqw2elA7QaE=; b=aN/JpOnuChbUJRZN4xwqhQHCGPecFOklql1S6vziQ7TH5HTB4UP1nXOXaBKMEdmQ2D EA2kLK6fViJUJKoW3QTTchiNEQDxLJpUA97gjUf0qZXuEzBtaO790nzqP2m+095GdaGO XLbgqdLJa8N0Y3vKTTmTGuA3ebAEII+wHnll1frRR/eMoWXqLYlmIhShIpPMFDYpZreF 8CexA/3cL3Q9a5XO7e4NQSy6/7cd02cF5TViKWUBaVYC+U04ABIoVbUxbwOrat1+B8zs 4W+lLRu0EnQy+mdwQPkHpkfsaXArJDipiJi6iNZi/El2V2Aa0x82m8Zf0vDGX0vxhzfC DRYg== X-Gm-Message-State: AOAM531oBkgYxFhR7Q0dYe8e7tlpSi/C9+IJkVDQRJdZxmePHzHtg3Dn rdr4M7yg4OoKWs58dWnVWDgfUbu1vvE= X-Google-Smtp-Source: ABdhPJydbyhD6n5VVT7sc2UK83lvYRithfxG1xRmlFRgzcDXZxXyHdIrlOf5MIxqS0i3fM40glrMkQ== X-Received: by 2002:adf:f201:: with SMTP id p1mr41182472wro.243.1638279693507; Tue, 30 Nov 2021 05:41:33 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:3c45:157c:7662:2fd3]) by smtp.gmail.com with ESMTPSA id o12sm23391447wrc.85.2021.11.30.05.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 05:41:33 -0800 (PST) In-Reply-To: <87bl21pyuv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 30 Nov 2021 14:16:56 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221118 Archived-At: >>>>> On Tue, 30 Nov 2021 14:16:56 +0100, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >>>>>>> On Mon, 29 Nov 2021 20:38:05 -0500, dick.r.chiang@gmail.com sai= d: >>=20 dick> From 18e2cfa112c3393b4191bb3497bf9a0ae643c2a2 Mon Sep 17 00:00:00= 2001 dick> From: dickmao dick> Date: Mon, 29 Nov 2021 20:31:28 -0500 dick> Subject: [PATCH] Don't repeat yourself (DRY) >>=20 >> I don=CA=BCt think that quite works: Lars> [...] >> SKIPPED echo-server-with-dns Lars> It works here... I meant the 'connection failed but test passed' messages, which makes me question if the test is broken or whether it=CA=BCs just too verbose. Lars> But as for the patch itself -- "don't repeat yourself" is good ad= vice in Lars> normal code, but for tests, we want to be as explicit as possible= , so Lars> that when tests fail, we can see exactly what fails. So I don't = think Lars> rewriting the tests is a good idea, and I'm closing this bug repo= rt. That works for me :-) Robert --=20