From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52324: 29.0.50; "Padded" mode line lacks uniform border Date: Sun, 12 Dec 2021 10:48:35 +0800 Message-ID: <87mtl61qt8.fsf@yahoo.com> References: <877dciyusl.fsf@protesilaos.com> <83k0gh23ka.fsf@gnu.org> <837dcbqmmr.fsf@gnu.org> <87v8zu1vwn.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16961"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 52324@debbugs.gnu.org, info@protesilaos.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 03:49:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwEvJ-0004Ih-Bj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 03:49:13 +0100 Original-Received: from localhost ([::1]:54140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwEvH-0002UH-Px for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Dec 2021 21:49:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwEvA-0002Tt-Nx for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 21:49:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwEv7-00030x-RL for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 21:49:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwEv7-0001iR-Pb for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 21:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 02:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52324 X-GNU-PR-Package: emacs Original-Received: via spool by 52324-submit@debbugs.gnu.org id=B52324.16392773326577 (code B ref 52324); Sun, 12 Dec 2021 02:49:01 +0000 Original-Received: (at 52324) by debbugs.gnu.org; 12 Dec 2021 02:48:52 +0000 Original-Received: from localhost ([127.0.0.1]:50386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwEuy-0001i1-L1 for submit@debbugs.gnu.org; Sat, 11 Dec 2021 21:48:52 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:39736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwEux-0001hp-QK for 52324@debbugs.gnu.org; Sat, 11 Dec 2021 21:48:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639277326; bh=2zt6/vfXP/0c7Lpwxt55d/FWNc+/lAUrGu7H9nS1YtE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=hJL4q7GREUUMUKibehsz177fAMWsA6l+X6vhrU9nDr9vb18aw4yduF5n3euEzvsbZyOZtZwqdCCScsNkYZuGPmSvC46t4CuMOfwcSqG8l80NuKvAxaTJP/G8cs4VtK+A/DyPtLDWvxxmXDckmVuib0rY98A6olBwRKT4rhm8eNvULs6NuJGd5X0urCL8oHsey9s6ELaO/nZP9G+VqUWjoCMMqdBI2mIGtGKg4a0jm8+NwgFHTSnT+gUIE3hftGk6l6l9CJgnndqPqoHjNhJPPWfZ7hPurm2CVZtPDPFohq3BFYmqz3GCb2OQPGrRTOkXi3fEgnLUIS4Rr2THkCCK3A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639277326; bh=fqz85SO2b2vZMp0SL9mhj3TIX915yKu/848OcyAkLBr=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=slU6BWYWWNtgSXQBos3EcV3d3U06iV16twpmPZW7D0YJ/2bYwDgRTrxBNHrbDnJ78bdqswWbmLCo3unxncJqO3XMB9aFNrvJBzKgd4Ty0Yk/bHdT7hAJGTUFxhsoeYxHEdhDL5nxWRAbiIeOUZW5veqDYZe/jt8h2ddcQVj9zBmdX0woDixLZaaCaAgopNcpHwAWbwEs8oRVI2FizQOznL47t17VE8j9zf6dsZNWpOc8V8f8nREXH+3ACf+vu/4rp2YPYI7XBvzPTqLbFK3esyfWXepF9V+Rt/bbv6EsKbms1MLGgSXT3z2zxDkM5pPlH5BTh1oeobobb/RLpvAVBA== X-YMail-OSG: _Z8VfXUVM1mZaDy4rEaCQjitXLZ5cmzAWF43LdCQTRFxP0.oHhiZIrRnSdiqYKo 3jPcRSKUA4TM8.bpUblQe.Y7rWebUnO8W.OnsR.yw33nODgnFuK3eXI3ud0jeGu2DgfvrNLg2PNy AzwLdvwkR6jSpsR4uheUWx6N5YP9q4mrwRL8wJAFWaZRxX9ri4DycHWrlcgZ2jSuSPdPJF.mIwco Rv2JXIm.0kEfoU7D_nEM35qDw4RoKCfA8L4LXYQdUvpCIa.6Nb71AKFfexp35s4r2ep4x8QYXYcU 6uzpSoB2S0xm8RsroO_hKxFOgCkeeV8fvZaDINCOSCefCEOZi9B1aVq5IyBvj_Mo9HFfVg6zvmDT KXRMTxIhVLQOncLmzDZcAlCM6QyNiinzmJ4VOdlEx4qjimWjchgt8w9F41rqGxQC0dJ7.JZvX2ef eIBTkJICEYyCXHSOVUZ7FOMfsaN3ompwU05dSN_v1hbXCqV.LAZy1BLKOf2Aqs6DY8PgbV0FxQRS ZU5koPu2yhGWlwzOkkHO4V_w3y3rL28ap7izpwjiFRWPN8KoPuVK2isHFx0QUXfIxpNvb_0VJEnL gRNJ.2W0CfrYjT8xt_E8zVar_KseICJrs9cTecesKpAwjqWN7L6h0nzuWFIEUCrGh_Nu5oC3zsaX 8m5_Pq0vej8pVzl0aITPvRUB007f6Y1VyhCF_NcCPUFeY8auK1X3PXPdKRuvVj6Fmiuz5ERC5.G2 3npL.PpPJyXVJfKKQyf.F98ullNCqRCnpuy_8UhGSfa4wQe3kmmCeK_iZ.XSvCMFKRc5ODXXfh1E XJJqRvBwWi4S2IheAfknfwtwpaVe94Bi9BVE8llnNh X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 12 Dec 2021 02:48:46 +0000 Original-Received: by kubenode507.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 264c300542d2652eef145bafc3938f0d; Sun, 12 Dec 2021 02:48:40 +0000 (UTC) In-Reply-To: <87v8zu1vwn.fsf@yahoo.com> (Po Lu's message of "Sun, 12 Dec 2021 08:58:32 +0800") X-Mailer: WebService/1.1.19415 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222161 Archived-At: Po Lu writes: > The correct solution is to move this code: > > /* Draw relief if not yet drawn. */ > if (!relief_drawn_p && s->face->box != FACE_NO_BOX) > x_draw_glyph_string_box (s); > > To run before drawing the overline. I tested and it works here, so if > you have no objections I will make that change in xterm and on the other > *terms as well. BTW, the Haiku port has the same problem, but with a very different cause, even though text decorations are already drawn after the box: drawing the box on such glyphs sets a special kind of graphics clipping that prevents anything from being displayed on top of the box afterwards. This is done for a variety of subtle reasons that are too complicated to explain here. To solve it there, I made the subroutine in charge of displaying the box draw text decorations before setting the special clipping. It's TRT, as everything said clipping is supposed to prevent happens after it returns. So as a heads up, please don't take the changes made to the Haiku port as representative of how to solve this problem.