From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52973: Adding a few context-menu-mode commands Date: Thu, 06 Jan 2022 21:19:39 +0100 Message-ID: <87mtk8d3c4.fsf@gnus.org> References: <87o84tp69h.fsf@posteo.net> <868rvwsezi.fsf@mail.linkov.net> <87czl75lyz.fsf@posteo.net> <86czl6au29.fsf@mail.linkov.net> <874k6idjod.fsf@posteo.net> <86o84pthgp.fsf@mail.linkov.net> <87pmp4lmfz.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29476"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52973@debbugs.gnu.org, Juri Linkov To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 06 21:20:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5ZFm-0007XO-TY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jan 2022 21:20:54 +0100 Original-Received: from localhost ([::1]:49008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5ZFj-0007aR-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jan 2022 15:20:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5ZEw-0007aH-6S for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 15:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5ZEv-0008Jn-SC for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 15:20:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5ZEv-0002a3-Oy for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 15:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jan 2022 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52973 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52973-submit@debbugs.gnu.org id=B52973.16415003929897 (code B ref 52973); Thu, 06 Jan 2022 20:20:01 +0000 Original-Received: (at 52973) by debbugs.gnu.org; 6 Jan 2022 20:19:52 +0000 Original-Received: from localhost ([127.0.0.1]:42429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5ZEm-0002ZZ-Dy for submit@debbugs.gnu.org; Thu, 06 Jan 2022 15:19:52 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:42044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5ZEj-0002ZH-Si for 52973@debbugs.gnu.org; Thu, 06 Jan 2022 15:19:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v0SkVoI3ZxTA0hXonFrghqD9DgFtsvj4ufoSO2/U7YY=; b=IAHY3DeiF8uNYi387ylsVCew7G 1ovgPXVXTt3bPOc5gqJRTvGnpb5jQ5xUl99TAcw5kvuvsCkd9Zq0DDwVW7l+AiDd60s7+ifrSqLZI P6A4h/aHlooSESQmMvRQ1uGLPpDLhI9BP2oRsTO4ymJsrt4+/GoKdnEWVnqw6Px7gUh8=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5ZEa-0001Yy-2p; Thu, 06 Jan 2022 21:19:42 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWvlXeNclpKODH/ //8KL3ufAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YBBhQRETaELB0AAAFzSURBVCjPVZGxbttADIZ5 Qa1BUzN4qN6gego5gAMkkwKIh1hTh9qo7ynUAM2cITJiTWpgHcL/KUuelKEHiOJ3JH8e7+gLuW+M eRGRCz6YO5ZU08ojGnQ5VbT1c1KWUbXmNvnl2zM5TgV4LAdQz3wCJDgg0JH9oPWSQUAZsz8FvJTW x2neeUJ3GBXqIw/tJVRnLaKvqxP8dHd1vFGo/F/EocuQK9w81bsDxhyF9sk3TVfgNdsVGmk7PHt8 uA+D8PvnA+6l+m5Qvv+g3ONCKYI/dCVAVSZA5/aCywJwB5nvQDfiaR5VDCadO01oIthgmIxIjyRV QIEFMCocDDLb+g+A7bBIa1XbJmk1EeKnJGAmSmO/YYaJvXxG+p7tVUKCqefWx7hPAL1Ivf+YIKi/ HxbpM9uKQp9ZnpNaxJQibU9SO4zm77wQrevist4zCwci5ltZzXkGDErAdK3meNvPsE61CRpyRs2S 5sz+0k+bUcNb9vN56n/D/g0PeljmaAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMS0wNlQyMDox NzoxNyswMDowMG2OeMoAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDEtMDZUMjA6MTc6MTcrMDA6 MDAc08B2AAAAAElFTkSuQmCC X-Now-Playing: PJ Harvey's _The B Sides_: "Somebody's Down, Somebody's Name" In-Reply-To: <87pmp4lmfz.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 06 Jan 2022 18:59:44 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223749 Archived-At: Philip Kaludercic writes: > * lisp/net/webjump.el (webjump-default-search-engine): Add user option > (webjump-choose-search-engine): Add function I think putting this shared functionality in the webjump package isn't optimal. Webjump is "webjump.el --- programmable Web hotlist", and this doesn't seem related. browse-url (or even url-something) would be more natural, I think. The functionality otherwise looks good to me. One micro-comment on the code: > +(make-obsolete-variable 'eww-search-prefix > + "webjump-default-search-engine" Should be: > +(make-obsolete-variable 'eww-search-prefix > + 'webjump-default-search-engine -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no