From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 52973@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#52973: Adding a few context-menu-mode commands
Date: Thu, 06 Jan 2022 21:19:39 +0100 [thread overview]
Message-ID: <87mtk8d3c4.fsf@gnus.org> (raw)
In-Reply-To: <87pmp4lmfz.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 06 Jan 2022 18:59:44 +0000")
Philip Kaludercic <philipk@posteo.net> writes:
> * lisp/net/webjump.el (webjump-default-search-engine): Add user option
> (webjump-choose-search-engine): Add function
I think putting this shared functionality in the webjump package isn't
optimal. Webjump is "webjump.el --- programmable Web hotlist", and this
doesn't seem related.
browse-url (or even url-something) would be more natural, I think.
The functionality otherwise looks good to me.
One micro-comment on the code:
> +(make-obsolete-variable 'eww-search-prefix
> + "webjump-default-search-engine"
Should be:
> +(make-obsolete-variable 'eww-search-prefix
> + 'webjump-default-search-engine
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-01-06 20:19 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 8:34 bug#52973: Adding a few context-menu-mode commands Philip Kaludercic
2022-01-03 12:45 ` Eli Zaretskii
2022-01-03 13:52 ` Philip Kaludercic
2022-01-03 14:32 ` Eli Zaretskii
2022-01-03 17:23 ` Philip Kaludercic
2022-01-03 17:36 ` Eli Zaretskii
2022-01-03 21:17 ` Juri Linkov
2022-01-04 12:26 ` Eli Zaretskii
2022-01-04 17:46 ` Juri Linkov
2022-01-04 20:01 ` Eli Zaretskii
2022-01-04 20:08 ` Philip Kaludercic
2022-01-04 20:15 ` Eli Zaretskii
2022-01-05 19:09 ` Juri Linkov
2022-01-05 19:29 ` Eli Zaretskii
2022-01-05 20:57 ` Juri Linkov
2022-01-06 6:54 ` Eli Zaretskii
2022-01-06 8:20 ` Juri Linkov
2022-01-06 9:10 ` Eli Zaretskii
2022-01-03 21:12 ` Juri Linkov
2022-01-04 19:39 ` Philip Kaludercic
2022-01-05 18:58 ` Juri Linkov
2022-01-05 20:14 ` Philip Kaludercic
2022-01-06 8:17 ` Juri Linkov
2022-01-06 18:59 ` Philip Kaludercic
2022-01-06 20:03 ` Juri Linkov
2022-01-06 20:32 ` Eli Zaretskii
2022-01-06 20:35 ` Juri Linkov
2022-01-07 6:38 ` Eli Zaretskii
2022-01-07 6:46 ` Lars Ingebrigtsen
2022-01-07 8:20 ` Eli Zaretskii
2022-01-07 8:29 ` Philip Kaludercic
2022-01-07 8:37 ` Eli Zaretskii
2022-01-08 18:30 ` Juri Linkov
2022-01-08 18:44 ` Eli Zaretskii
2022-01-08 19:01 ` Philip Kaludercic
2022-01-08 19:10 ` Eli Zaretskii
2022-01-08 19:39 ` Philip Kaludercic
2022-01-08 20:09 ` Eli Zaretskii
2022-01-12 6:16 ` Lars Ingebrigtsen
2022-01-12 13:12 ` Eli Zaretskii
2022-01-12 17:16 ` Juri Linkov
2022-01-12 17:36 ` Eli Zaretskii
2022-01-12 18:03 ` Juri Linkov
2022-01-12 19:27 ` Eli Zaretskii
2022-01-12 19:41 ` Juri Linkov
2022-01-12 19:53 ` Eli Zaretskii
2022-01-12 20:00 ` Juri Linkov
2022-01-12 20:42 ` Eli Zaretskii
2022-01-13 8:39 ` Juri Linkov
2022-01-13 10:06 ` Eli Zaretskii
2022-01-13 6:03 ` Lars Ingebrigtsen
2022-01-13 8:35 ` Juri Linkov
2022-01-13 8:53 ` Lars Ingebrigtsen
2022-01-13 9:10 ` Juri Linkov
2022-01-13 9:23 ` Lars Ingebrigtsen
2022-01-13 10:11 ` Eli Zaretskii
2022-01-13 8:54 ` Eli Zaretskii
2022-01-06 20:19 ` Lars Ingebrigtsen [this message]
2022-01-06 20:32 ` Juri Linkov
2022-01-22 19:39 ` Philip Kaludercic
2022-01-23 9:08 ` Juri Linkov
2022-01-23 12:09 ` Philip Kaludercic
2022-01-23 12:13 ` Lars Ingebrigtsen
2022-01-23 16:30 ` Philip Kaludercic
2022-01-23 18:06 ` Juri Linkov
2022-01-23 19:49 ` Philip Kaludercic
2022-01-23 20:04 ` Juri Linkov
2022-01-24 9:14 ` Lars Ingebrigtsen
2022-01-25 12:06 ` Philip Kaludercic
2022-01-25 12:24 ` Lars Ingebrigtsen
2022-01-04 20:09 ` Philip Kaludercic
2022-01-05 19:03 ` Juri Linkov
2022-01-14 8:52 ` Lars Ingebrigtsen
2022-01-14 14:33 ` Philip Kaludercic
2022-01-15 8:07 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtk8d3c4.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=52973@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).