From: Lars Ingebrigtsen <larsi@gnus.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 54240@debbugs.gnu.org, chenphy10@gmail.com
Subject: bug#54240: emacs/lisp/emacs-lisp/derived.el patch
Date: Fri, 04 Mar 2022 16:19:59 +0100 [thread overview]
Message-ID: <87mti5g2xs.fsf@gnus.org> (raw)
In-Reply-To: <87a6e6pn8j.fsf@web.de> (Michael Heerdegen's message of "Fri, 04 Mar 2022 01:36:44 +0100")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> To me this looks like a regression introduced when converting to lexical
> binding. Look at the symbol 'mode': it's implicitly quoted so it can't
> refer to the lexical variable and you get the error reported.
Oh, yeah -- I was thinking that the mode had to be lexically bound
there, but of course it isn't really, since eval is ... eval. (Whenever
there's an eval in code, there's a bug somewhere.)
Would adding LEXICAL to the eval form fix the issue here, or would that
interact oddly with the defvar?
> The patch unquotes too much however, looks like we want something like
>
>> > - (define-abbrev-table (derived-mode-abbrev-table-name mode) nil)
>> > + (define-abbrev-table (derived-mode-abbrev-table-name ',mode) nil)
>
> (does that work?)
Tongjie Chen <chenphy10@gmail.com> writes:
> Thanks Michael. I tested this improved quoting and it worked. Once the abbrev
> table is defined, jdee will no longer run into problems.
OK, I'll push Michael's change to emacs-28, because this is a regression
from Emacs 27.2, I think.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-03-04 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:45 bug#54240: emacs/lisp/emacs-lisp/derived.el patch chenphy10
2022-03-03 17:14 ` Lars Ingebrigtsen
2022-03-03 23:02 ` Tongjie Chen
2022-03-04 0:36 ` Michael Heerdegen
2022-03-04 3:28 ` Tongjie Chen
2022-03-04 3:59 ` Michael Heerdegen
2022-03-04 15:19 ` Lars Ingebrigtsen [this message]
2022-03-04 21:39 ` Michael Heerdegen
2022-03-06 16:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mti5g2xs.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=54240@debbugs.gnu.org \
--cc=chenphy10@gmail.com \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).