From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#54343: 28.0.91; find-function goes to a wrong place for erc Date: Sun, 13 Mar 2022 13:12:12 -0700 Message-ID: <87mtht4noj.fsf@neverwas.me> References: <87h783ys33.fsf@gnus.org> <87wngyad1h.fsf@neverwas.me> <87tuc2vfa6.fsf@gnus.org> <87bkya8s5x.fsf@neverwas.me> <87k0cyuemt.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20374"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lin Jian , 54343@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 13 21:13:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTUaX-00058U-Co for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 21:13:13 +0100 Original-Received: from localhost ([::1]:42286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTUaV-0001p1-Ts for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 16:13:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTUaO-0001os-3s for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 16:13:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTUaM-0001R7-FM for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 16:13:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTUaM-0002ws-6J for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 16:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Mar 2022 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54343 X-GNU-PR-Package: emacs Original-Received: via spool by 54343-submit@debbugs.gnu.org id=B54343.164720234611285 (code B ref 54343); Sun, 13 Mar 2022 20:13:02 +0000 Original-Received: (at 54343) by debbugs.gnu.org; 13 Mar 2022 20:12:26 +0000 Original-Received: from localhost ([127.0.0.1]:43335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTUZm-0002vw-8b for submit@debbugs.gnu.org; Sun, 13 Mar 2022 16:12:26 -0400 Original-Received: from mail-108-mta193.mxroute.com ([136.175.108.193]:34477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTUZk-0002vj-Br for 54343@debbugs.gnu.org; Sun, 13 Mar 2022 16:12:25 -0400 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta193.mxroute.com (ZoneMTA) with ESMTPSA id 17f84e8f9b9000763e.001 for <54343@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sun, 13 Mar 2022 20:12:15 +0000 X-Zone-Loop: 8a58c1b1ee38cceee5625d580851d02b83c434fe3b96 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Kdsv9QgI0islCAlPGuFwPRnyHTkAZISICyJ0MAYATT0=; b=RxZlU8Gn2uI3ix2ABJ3ZLbJM7s VxlmktLtSIYRH11XV/NNCuvRn/s8+HzybSXBABbPQZefjscCKV3CsnPtdg1a6HuqOZhvMP6OxeFAa FRf6awY5t1VBnncLSo5D/pFE6I0Wu8PC/xjP71s8DNX1cdTOgSQuIAUGmx6dQYEPV6NLlv6m9Ef7I KlM+erf8YIwhOwhk+GXErXETJ8G3beAHPo2+1sJF2ObLazVf7ywJh6o8jryA5qZFgebDMK5PmmLpb cemI6mrdXo74uNUgfT4y8cydjvK4Essrzo2NZMqSCFvcCnfRkfcFysabAv4bUA8pcLvqpWImH0sYR I5OJnZVQ==; In-Reply-To: <87k0cyuemt.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Mar 2022 15:10:50 +0100") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228307 Archived-At: Lars Ingebrigtsen writes: > So I've now added that in Emacs 29, too. Looks like the "def" part is missing from "defgeneric": diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el index 777334a7a7..208d68d1ab 100644 --- a/lisp/emacs-lisp/find-func.el +++ b/lisp/emacs-lisp/find-func.el @@ -61,7 +61,7 @@ find-function-regexp [...] -cl-\\(?:defun\\|defmethod\\)\\|\ +cl-\\(?:defun\\|defmethod\\|generic\\)\\|\ ~~~~~~~ I'd used both in back-to-back examples (both def- and plain generic), which was clearly a typo landmine (sorry). > so perhaps longer term it would be nice if it was rewritten. And > perhaps the logic should be "first look for these things, and if we > don't find them, then look for these other things". That is, a > priority thing.) I was thinking much the same, albeit in a less evolved manner. The alternate function form for the CDRs of `find-function-regexp-alist' members may prove useful to do the prioritizing. Perhaps it'd even be worthwhile to incorporate more refined strategies, when available, such as the finders provided by cl-generic.el[1]. >> Just a benign optimization involving some culling of redundant code in >> `erc--switch-to-buffer'. This email contains the latest version, with a >> slightly revised commit message: >> >> https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-01/msg02081.html > > I think that makes sense? But I haven't tested the patch. I'm testing it indirectly (in yet another bug) but will add a unit test for good measure and ping you in the other thread. Thanks. [1] https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/emacs-lisp/cl-generic.el?id=dd91aac5#n995