From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Date: Wed, 30 Mar 2022 13:51:57 +0200 Message-ID: <87mth7bqua.fsf@gmx.de> References: <3947f11808243544dcdd4e4d2fde4922@webmail.orcon.net.nz> <87v8vwap2l.fsf@gnus.org> <878rssaos4.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32146"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 54606@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 13:58:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZWyH-0008BE-8r for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 13:58:41 +0200 Original-Received: from localhost ([::1]:38958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZWyF-0003cF-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 07:58:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZWso-0005EM-IX for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 07:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40811) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZWso-0006um-72 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 07:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZWso-00075a-3f for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 07:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 11:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54606 X-GNU-PR-Package: emacs Original-Received: via spool by 54606-submit@debbugs.gnu.org id=B54606.164864113527194 (code B ref 54606); Wed, 30 Mar 2022 11:53:02 +0000 Original-Received: (at 54606) by debbugs.gnu.org; 30 Mar 2022 11:52:15 +0000 Original-Received: from localhost ([127.0.0.1]:34708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZWs3-00074Y-5o for submit@debbugs.gnu.org; Wed, 30 Mar 2022 07:52:15 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:54243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZWs0-00074J-Cd for 54606@debbugs.gnu.org; Wed, 30 Mar 2022 07:52:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1648641119; bh=xeShZOYlavQzFOGvDxnPIKEZ+vtTnlxbXE/ccJ56N50=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LkERQ4JTxpPTqv9GNII31CcDQm8JvV+P7AjVyjURFVVViAhEqYB5xlPlQX+AKqREL Vi77jQSB1zDK++R90u6VrHBHlPkeGP9OCAXg8js4FsFB6Eluuf8PT1PDTY4BsMKhJ6 x8U4zkRaJUCKK74itwsRSFmEBCHTL2QZ3hI96Yfw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.151.59]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1OXT-1o34FQ0cot-012l8C; Wed, 30 Mar 2022 13:51:59 +0200 In-Reply-To: (Phil Sainty's message of "Thu, 31 Mar 2022 00:43:23 +1300") X-Provags-ID: V03:K1:19OtnDZvlOJLkdp5QREDMqiZMBVgz4RTrRB2YABEJH/Vw4KwcnV noQgmMtwEAfYr2OI4a0xAP4U2Rb/C1pSljUIrrrdb0np7lft8JNaz5XlaF5fS1axEnMPS0J F+42Su6/QOkrw86PG8Y1N51s77FQhMWJn+/xxKAS5OsaIiBU/Kaj1ARe/5FSTPRDhJNWaHd 6ET8vXMkG3gdo+3vDKgSQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:hUBu7g+dKGE=:V2W+PqP8E+pvUVP6YLhG9h yem4yNjZ1/X4cXtfHob8nBwC1kG0vXOmgl+tkWq1SIPUbeO5hwWZ0zWU+l/RNIUi7IefYD+HP T6SDRwi2vH7PmFQPB2V6R0Gi/jcQrlTAseI1BscVaUzGldFfghbC7Mh5ZQDjemhK3WlgNJtGC qUhyHiHbIMte9GysScNhjC8c+UbhqRIUF3ZAiUsItWYYSBnktEtTGntGw5Y9FdCfv4KVR5iKE 6RusLqzTuvid04kWFWDdRx6lHBzoVByc/9E/KGPl9QcatSjRB7E/kk3yscdAkgvwl2kz8OEbj y5R0P08V1h9Jimti+WDCE9cfPCp/oSNcmjdP9JaQNLiLXGKE+AZ4SJqscmUFJR8wssM4XwdXf 1ymN7Kxuug/CAQTvBeNbBvgiZtRns3aVZOGCjK5m5QeqfqsHDCFVZ8wtf+7csx24GvOsJ0JKn XqAIwg8hu1aT4iqbp/C6o/taS01jqWO4PHG3tyokgD58VQhNbBKAttWwSc9z3jPgcCDFbPfly gAv8WaMexmFjQB7Ez1ljRgo6xg9TPP66hnWOThZi5wpL/DKawuuTtG4fiV0aRsWa7u6PZco8x DutiysAOx2t3q0Q+KjfT8gd4mGtcez+TX8EWOhcr2sbh0VWEaxp/k0DcmJAFvH8PIIIs4+JJ6 l8j8k86VxnH4v1Z8Bf5yWQhvZ0/3YZOF6S6rgq2MVacV64TM87Ew9RpC45rZ8obB0wsFLjJl4 UllPmIIBxQKpXCf99ZQegxm0vnm4ldf17YLzM5KEiCmKoXFsagpCszZYWKrR7biz7IBbdEYq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229100 Archived-At: --=-=-= Content-Type: text/plain Phil Sainty writes: Hi Phil, > I've just tested with this, and it solves the immediate problem, but > it's slow. In my test case it's taking ~2s to switch between images, > whereas it takes only a fraction of a second when I'm ignoring remote > dired buffers by adding (not (file-remote-p default-directory)) to > the conditions. > > I have 15 remote dired buffers (about half of which are using multi- > hops), which isn't a small number but also isn't big, so I think that > `non-essential' seems inadequate here (unless this is significantly > more efficient in newer versions). There is also a change in Tramp of Emacs master, which is relevant in this context. Do you have a chance to test that Emacs version? Otherwise, does the appended patch for Emacs 27 make a difference? I haven't tested it with Emacs 27, though. > -Phil Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment *** /tmp/ediffwcSDZb 2022-03-30 13:50:29.736061472 +0200 --- /home/albinus/src/emacs-27/lisp/net/tramp-sh.el 2022-03-30 13:50:18.051914192 +0200 *************** *** 4958,4963 **** --- 4958,4964 ---- ;; If Tramp opens the same connection within a short time frame, ;; there is a problem. We shall signal this. (unless (or (process-live-p p) + (and (processp p) (not non-essential)) (not (tramp-file-name-equal-p vec (car tramp-current-connection))) (time-less-p --=-=-=--