unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 45768@debbugs.gnu.org, simon254@mailbox.org, 45767@debbugs.gnu.org
Subject: bug#45767: bug#45768: icomplete-mode does not provide in region completion for dabbrev-completion
Date: Sat, 07 May 2022 12:16:16 +0200	[thread overview]
Message-ID: <87mtftvea7.fsf@gnus.org> (raw)
In-Reply-To: <jwvv8ui5u93.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 06 May 2022 15:38:54 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> The problem is that `icomplete-in-buffer` relies on
> `completion-in-region-mode-predicate` being passed to
> `completion-in-region` (this is needed so Icomplete can know when you've
> finished the completion), which `completion-at-point` does but which
> `dabbrev-completion` does not do, so `icomplete-in-buffer` is not used
> when completing via `dabbrev-completion`.

I see.  I've now added this to the doc string on icomplete-in-buffer,
and since this is working as intended, I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-05-07 10:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10 12:37 bug#45767: icomplete-in-buffer completion does not work with dabbrev-completion simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-06 19:04 ` bug#45767: bug#45768: icomplete-mode does not provide in region completion for dabbrev-completion Lars Ingebrigtsen
2022-05-06 19:38   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-07 10:16     ` Lars Ingebrigtsen [this message]
2022-05-07 14:22       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-07 15:51         ` Lars Ingebrigtsen
2022-05-08 18:08   ` bug#45768: " Juri Linkov
2022-05-09  9:47     ` Lars Ingebrigtsen
2022-05-09 18:41       ` Juri Linkov
2022-05-09 21:23         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-19 16:58           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtftvea7.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=45767@debbugs.gnu.org \
    --cc=45768@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=simon254@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).