unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 43723@debbugs.gnu.org
Subject: bug#43723: 27.1; Errors in file-extended-attributes prevent from saving buffer
Date: Tue, 07 Jun 2022 11:26:17 +0200	[thread overview]
Message-ID: <87mteoomdi.fsf@gnus.org> (raw)
In-Reply-To: <8335gh91ip.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 06 Jun 2022 19:53:34 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> The basic concern is that Emacs 26 silently ignored errors in file-acl
> and file-selinux-context, whereas Emacs 27 and later doesn't ignore
> them.  My point was that preventing the user from saving the edits
> just because we cannot preserve the ACLs is too radical, since most
> users don't care about ACLs, and because support for ACLs on volumes
> mounted by all kinds of network disk drivers that have trouble mapping
> extended attributes between different systems.

I see.

> You can easily simulate this situation by writing a replacement for
> file-acl that always signals a file-error, or advising it to that
> effect.

It's always better to have an actual test case so that we're not fixing
the wrong thing...

But in this case, I guess it's `set-file-extended-attributes' that
should be signalling an error if we want to emulate the problem?
`file-acl' would presumably just return nil in these cases, so there'd
be no warnings or errors?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-06-07  9:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 14:43 bug#43723: 27.1; Errors in file-extended-attributes prevent from saving buffer Eli Zaretskii
2022-06-06 16:22 ` Lars Ingebrigtsen
2022-06-06 16:53   ` Eli Zaretskii
2022-06-07  9:26     ` Lars Ingebrigtsen [this message]
2022-06-07 11:35       ` Eli Zaretskii
2022-06-07 11:52         ` Lars Ingebrigtsen
2022-06-07 13:07           ` Eli Zaretskii
2022-06-07 18:04             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mteoomdi.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=43723@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).