From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45872: 27.1; rcirc nick tracking Date: Tue, 07 Jun 2022 15:30:47 +0200 Message-ID: <87mteoha7s.fsf@gnus.org> References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> <87wnpfzroo.fsf@posteo.net> <87wnpcxj28.fsf@posteo.net> <878rt8be9a.fsf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21739"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Philip Kaludercic , 45872@debbugs.gnu.org To: Ken Raeburn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 07 15:32:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyZK1-0005Mm-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 15:32:37 +0200 Original-Received: from localhost ([::1]:56026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyZJz-00012G-7R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 09:32:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyZJT-0000ui-50 for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 09:32:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyZJS-0000Vz-Sh for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 09:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyZJS-0007Bm-KX for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 09:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45872 X-GNU-PR-Package: emacs Original-Received: via spool by 45872-submit@debbugs.gnu.org id=B45872.165460866324337 (code B ref 45872); Tue, 07 Jun 2022 13:32:02 +0000 Original-Received: (at 45872) by debbugs.gnu.org; 7 Jun 2022 13:31:03 +0000 Original-Received: from localhost ([127.0.0.1]:39003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyZIU-0006KC-UL for submit@debbugs.gnu.org; Tue, 07 Jun 2022 09:31:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyZIS-0006DW-Dv for 45872@debbugs.gnu.org; Tue, 07 Jun 2022 09:31:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vAAmVSt0AqIHfqeuPtldB1hsvsFMYUWjRqpbb+yok+U=; b=HAMTeQ6dtE6W1ijgT2Eq146LG2 MrutPMKK+xV49gPlLmkQZ9MsT9enk+kckwMdfCMYBwGMZAd+LD21VkEM3OpqqvuGiRgKq8igyHpTJ sflVTirsf4HXfIHp+wfWt4SwEiiSYC4z4JxS0bSUJngjGHxMxzxBdexPBNkZWxBXeigs=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyZIF-00037H-Rk; Tue, 07 Jun 2022 15:30:54 +0200 X-Now-Playing: Blaine L. Reininger's _The Blue Sleep_: "Dry Food" In-Reply-To: <878rt8be9a.fsf@redhat.com> (Ken Raeburn's message of "Thu, 17 Mar 2022 14:55:13 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233887 Archived-At: Ken Raeburn writes: > 2022-03-16T08:24:29 !!! > ":someuser|away!~someuser@some-internal-host.redhat.com NICK > :someuser" (error Buffer name =E2=80=98someuser@some-irc-host.redhat.com= =E2=80=99 is > in use) > > I think this is coming from cases where I=E2=80=99ve been offline for a n= ick > renaming, so when I come online, =E2=80=9Csomeuser|away=E2=80=9D is onlin= e but I have a > buffer =E2=80=9Csomeuser=E2=80=9D. Perhaps the UNIQUE argument to rename-= buffer should > be set? So the suggested change is: diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 0d30b34922..815dfef50f 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -3298,7 +3298,7 @@ rcirc-handler-NICK (with-current-buffer chat-buffer (rcirc-print process sender "NICK" old-nick new-nick) (setq rcirc-target new-nick) - (rename-buffer (rcirc-generate-new-buffer-name process new-nick))) + (rename-buffer (rcirc-generate-new-buffer-name process new-nick) t)) (setf rcirc-buffer-alist (cons (cons new-nick chat-buffer) (delq (assoc-string old-nick rcirc-buffer-alist t) Skimming the code, it seems like this should do the trick (but I haven't tested it). Ken, Philip, does this look OK to you? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no