From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregor Zattler Newsgroups: gmane.emacs.bugs Subject: bug#45246: 28.0.50; etags assertion error Date: Fri, 10 Jun 2022 00:33:07 +0200 Message-ID: <87mtelsc0s.fsf@no.workgroup> References: <87k0tklzzz.fsf@no.workgroup> <87o7z4k8ob.fsf@gnus.org> <87a6ao7dnh.fsf@no.workgroup> <838rq879ey.fsf@gnu.org> <83y1y85rko.fsf@gnu.org> <83zgil20oe.fsf@gnu.org> <874k0tznif.fsf@gnus.org> <83k09p1x3o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1288"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45246@debbugs.gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 10 00:34:51 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzQjp-000Acr-1N for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 00:34:49 +0200 Original-Received: from localhost ([::1]:40770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzQjn-0006Bz-Dw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 18:34:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzQj4-0006Ap-KG for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 18:34:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzQj4-0003E5-Am for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 18:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzQj4-0000Cw-57 for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 18:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregor Zattler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2022 22:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45246 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45246-submit@debbugs.gnu.org id=B45246.1654814000745 (code B ref 45246); Thu, 09 Jun 2022 22:34:02 +0000 Original-Received: (at 45246) by debbugs.gnu.org; 9 Jun 2022 22:33:20 +0000 Original-Received: from localhost ([127.0.0.1]:48195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzQiO-0000Bw-CY for submit@debbugs.gnu.org; Thu, 09 Jun 2022 18:33:20 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:51249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzQiM-0000Bj-BE for 45246@debbugs.gnu.org; Thu, 09 Jun 2022 18:33:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654813992; bh=E2sNSvmBNpdV3u+s0zM0UfbGe2zVy7n1H9gfdkddUZI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=VYtiSGkOG/VThX3eL985XRtX1wQ4SLR2AL1KbCYqnWdryV9UdUfER5Gjl+xlv08Gu CimOatbgjfHy0uyxmbWuB8hdtnRNcg5uWWtVbRyt/XC//Vp21VW0f+YdI8UEwdIncq gtYfmZCQiiSlC/uJtmSycNyP6yIzH5jhDvJzc5Q4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from localhost ([95.90.232.221]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHAB-1nWgfs4Btz-00gpLL; Fri, 10 Jun 2022 00:33:12 +0200 In-Reply-To: <83k09p1x3o.fsf@gnu.org> X-Provags-ID: V03:K1:uRRCjArJp83HldZZShLoOB1PEcVdKZHSNnniJe1gSsiv9WseHNX guy3q5eYSfSc+JnfIDYNXRMgLIOOh26Z0TJOsKe7JCBQCLdPVRG0mWd4h5ABnovmWnQchqP kCPavFmrV6EMkXjkpee0EMEvqA2xUpCF1I+U3ff1oG1yeQxdZcPBQYAv+5O1nXMbgRTR4D4 GD5Jn3cwSzv9+PMEMm3EQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:HperUMg2gsg=:y0YTQ5RZS1XJqv8k2JjeaJ KwNvZa9nQxjCdO/47K8kE5Kd2Ruiugk8kkyY9xTgVtoJ1G8wRXUxPZx67HoddF6DPwcttSzKB ADTPXo+NLndBfW0okUhg9VZ3T8QTLON0MQbAFIUQhcbo3/W+lW06pGIBriehXP4hqhSka/Ii+ 7xuRUH/uVF/3oQ3qCe0aGisrQJ0jDsxDxAjaIKEx4Nh1bNUQWvjmvxzAH8RrFsH3AlHoJPjqO gbz6YXeuj9f4FaUDMf2ktzRSBIlBj5dTsxQdYp60817NaZ+MbvutMYAUj6Jfncqt0qL1Jzwa2 f9H9OT3em3RnDxnssLDMHqH/z8CJBycca/LCbVvKefOWXpwbQe3JAGmP3D96J7jPCwfmqlT3F geRHx7wYxfOo9puBPBIxW53v0XgHAdYfp8sR7HGHijDwa18TI5f3rYWxo2uUWAf+/m1QUEn19 KkgPHqv7wENJMpKNXj5uOY3IJbUGpynkIRMe3UHEtXch6HjGKffug0Cpoc3l0dJm28j0Ak0PJ 4X1+xEac3O2o/3C/j8XlPY2/Z418sgja7h680Sjz6IuO7KalShXQzwJ9ZRv59pLiqhV3eB6X8 l44rY2dSKORwTHC91+8TtBzd9Q+RMyfrvX41QkL59NSoXNQY1wSurXQlTaxxhwpqqnVowcaKE uEHVPccsutNihfZLVGaT0imMlFwv0JGSRwumfrkmnRTqO/EYVwo77FJDPXVo1QVm5LSWKIVl+ mQLUqkYLGgYyAyb1VozvYp9Cj12GUd3WweAzakZwhmMX72Bub/ItcsdNjTs0barN3+QMYRWQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234178 Archived-At: Hi Eli, Lars, * Eli Zaretskii [2022-06-09; 21:59]: >> From: Lars Ingebrigtsen >> Cc: grfz@gmx.de, 45246@debbugs.gnu.org >> Date: Thu, 09 Jun 2022 20:43:04 +0200 >> >> Eli Zaretskii writes: >> >> > "etags --help" says: >> > >> > -I, --ignore-indentation >> > In C and C++ do not assume that a closing brace in the first >> > column is the final brace of a function or structure definition. >> > >> > And indeed, invoking "etags -I" compiled with --enable-checking with >> > the original file avoids the assertion violation. And in a productio= n >> > build, etags produces a valid TAGS file even if -I is omitted. >> > >> > So I think there's nothing to do here, and we should close this bug a= s >> > notabug. Does anyone disagree? >> >> I think that sounds correct. I confirm -I avoids the assertion. > Gregor, any objections to closing this bug? no. I must admit, I did not read the man pager closely but anyway I wouldn't have understood the consequences of setting vs not setting -I. Perhaps the documentation could be amended somehow? I assume this is a trade-of between speed and robustness? ... Some highly unscientific tests: I do not see a difference in speed neither between etags as of emacs26 as it comes with debian bullseye with or without -I. The optimized build etags from emacs29 is a bit faster with -I than etags as of emacs26 with or without -I. I do not have objections to closing this bug report, but I wonder why etags treats closing braces in the first column special if it does not speed up things? Ciao, =2D- Gregor