From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Date: Wed, 06 Jul 2022 21:19:35 +0200 Message-ID: <87mtdmyrp4.fsf@web.de> References: <874jzui52r.fsf@web.de> <87iloa2hlm.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11288"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 56423@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 21:23:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9AcR-0002qC-2p for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 21:23:27 +0200 Original-Received: from localhost ([::1]:33012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9AcQ-0006Q4-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 15:23:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9AZ9-0003hG-1M for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:20:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9AZ8-0003kv-0p for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9AZ7-0001qc-Ry for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56423 X-GNU-PR-Package: emacs Original-Received: via spool by 56423-submit@debbugs.gnu.org id=B56423.16571351857072 (code B ref 56423); Wed, 06 Jul 2022 19:20:01 +0000 Original-Received: (at 56423) by debbugs.gnu.org; 6 Jul 2022 19:19:45 +0000 Original-Received: from localhost ([127.0.0.1]:55208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9AYr-0001q0-4f for submit@debbugs.gnu.org; Wed, 06 Jul 2022 15:19:45 -0400 Original-Received: from mout.web.de ([212.227.15.3]:47041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9AYo-0001pl-FI for 56423@debbugs.gnu.org; Wed, 06 Jul 2022 15:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1657135176; bh=QYK+RNno4sJdbuF1fWFnCq2sruBniJwk4O6KMKrir1s=; h=X-UI-Sender-Class:From:To:Subject:In-Reply-To:References:Date; b=R+pJ55DgXApaeMxYC8ByHBSzAgD7M6FVGPoVPaP4WAjlV1up9cN7pdk8ET0Cq7zyl Cg/T/cvhzMXxK+x+HyJtk0M6yXz8sQtxZGBBk+Vc+6SFsr9G77fpoa8R6RZoZR+yxH XvSh/K2pXm0oekRucjj2YhK8aPTZD/r9XnBA1lgU= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.59.210.236]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MbCI8-1nc2jI0fWa-00bUMN; Wed, 06 Jul 2022 21:19:36 +0200 In-Reply-To: <87iloa2hlm.fsf@web.de> (Michael Heerdegen's message of "Wed, 06 Jul 2022 20:58:45 +0200") X-Provags-ID: V03:K1:b66sqlJBNsFNytmTHZcBv2ubzH7Bw4mfeIxH4i5//vvhKtZyhvp 8skQyvO7oluRyQio4zaYaaKO2ad2x8ewVwMTDfwMX5oo1LCSpZZ/0M8CvaCTwqVofXsQnNt KPnpmGTmwZA/kz312O3wPeJ+mfnWmw+1SEjoMDuM4yvgkTSl46HfJ+XstonFTcoklNgtYZr A/YEFwuZ4mta09G2E3Bqw== X-UI-Out-Filterresults: notjunk:1;V03:K0:clSTTnEGnoQ=:snDFTrRGNnNMXMoRy7vH5O lDgZNBFWp0AvsSi6DT6Wkyub9lw0k/wwNqFbmrdmFdwxsQ0KdomQ9Djl+LVGVdjaDKjSPf0cp SxNno6s/hYWfnO4WLUem6eXSXLlsDi1EdOcM164N2uRF/hxcd6yABn+X2oR136QOKr4VWFm+j KCPOaMEhwz0Z/dpuoalLx55QJsvSlGbbz0p3fwvU3A6mceqeWoM9jQsk4aN0PGaUORNLimNrE pLUQJl6F0VVJd7TQUB0KC3egmIFdijfwZN/09vuZU6qISUnTHihh6zB9h0KTTHttyqF1rq8g9 1cv+NR7GiWblBpkOS6bsHdNneEB3M+0kalRNWHHug0yo8B45f1qo406Klv5cZcknAdeG0Oi+a AYALxOB375k2KDhHrONITBe7LOb5Qg+Wh/3bBQ8RqI4A0HR+3DU2dL9ctOB/tbBG7IVZJokhF YvS9+NBuEmUo/6XwtuzYz/NMI0QjL3KKPg6EtbjOaTRHvKVLl3MExlCOVABqpOrihiHwQw1yL IxqQHh2M7WqGSNNpwPvyE7uVZlzuDLqwrHZqxY+sB2owHIfxxGGm6k/8ROG+zAF2RFOhNjMkr 7q3YTogMsMDhmV2uFDiJlY0TdvRQH3A7tnzf9YRp/DlkJq6QY2FcXRFeK7fofjxfzywUNHGQN PREtHhfaZmeyyB7eeGnP1+YWpsA2IDyNKVijQaRvvSWagSOLI0RG07yHW5zTbKjc4npv+zGsY N8nXofpn9lVICdaLGthoX22KHXIFV6FxDB5kgvJZDFw4HX8pNuUp6NfHRo3kh5z9yRFfjftc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236296 Archived-At: --=-=-= Content-Type: text/plain Michael Heerdegen writes: > [...] and `font-lock-set-defaults' finds that > > (derived-mode-p font-lock-major-mode) > > fails so that it recomputes the `font-lock-keywords' from the > defaults. I guess we could prevent that happening? This patch seems to fix the issue. Good idea? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Fix-wdired-vs.-hi-lock-Bug-56423.patch Content-Transfer-Encoding: quoted-printable =46rom 26baa6c65e934b110499c77255c5c54a89acd116 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Wed, 6 Jul 2022 21:16:19 +0200 Subject: [PATCH] WIP: Fix wdired vs. hi-lock Bug#56423 =2D-- lisp/wdired.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/wdired.el b/lisp/wdired.el index a5858ed190..7c8969431f 100644 =2D-- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode (add-hook 'before-change-functions #'wdired--before-change-fn nil t) (add-hook 'after-change-functions #'wdired--restore-properties nil t) (setq major-mode 'wdired-mode) + (setq font-lock-major-mode 'wdired-mode) (setq mode-name "Editable Dired") (add-function :override (local 'revert-buffer-function) #'wdired-revert= ) (set-buffer-modified-p nil) @@ -457,6 +458,7 @@ wdired-change-to-dired-mode (force-mode-line-update) (setq buffer-read-only t) (setq major-mode 'dired-mode) + (setq font-lock-major-mode 'dired-mode) (setq mode-name "Dired") (dired-advertise) (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t) =2D- 2.30.2 --=-=-= Content-Type: text/plain TIA, Michael. --=-=-=--