unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Visuwesh <visuweshm@gmail.com>
To: 56554@debbugs.gnu.org
Subject: bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
Date: Thu, 14 Jul 2022 19:39:15 +0530	[thread overview]
Message-ID: <87mtdbrdkk.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

Tags: patch

This fixes a typo in put-image.

BTW, even with this patch applied, I still can't access the keys in
image-map: I think it is because one cannot place the point on the
image?  Is this intended?  If yes, can we change mm-inline-image to use
insert-image instead (it currently uses put-image)?  Thanks.

In GNU Emacs 29.0.50 (build 11, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2022-07-14 built on astatine
Repository revision: d37ba6f259b972aa44c66ecb76210e03a3084183
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json
 --without-xaw3d --without-gconf --without-libsystemd --without-cairo'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-image.el-put-image-Fix-typo.patch --]
[-- Type: text/patch, Size: 710 bytes --]

From 07de01f5f9096e9a2e57d93ccd9edd76c7467e11 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Thu, 14 Jul 2022 19:25:19 +0530
Subject: [PATCH] * lisp/image.el (put-image): Fix typo.

---
 lisp/image.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/image.el b/lisp/image.el
index bdaaec608e..cb5ef4e8d1 100644
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -613,7 +613,7 @@ put-image
       (put-text-property 0 (length string) 'display prop string)
       (overlay-put overlay 'put-image t)
       (overlay-put overlay 'before-string string)
-      (overlay-put overlay 'map image-map)
+      (overlay-put overlay 'keymap image-map)
       overlay)))
 
 
-- 
2.35.1


             reply	other threads:[~2022-07-14 14:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 14:09 Visuwesh [this message]
2022-07-14 17:34 ` bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo Lars Ingebrigtsen
2022-07-14 17:40   ` Lars Ingebrigtsen
2022-07-14 17:43     ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtdbrdkk.fsf@gmail.com \
    --to=visuweshm@gmail.com \
    --cc=56554@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).