From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#49592: 28.0.50; lisp-current-defun-name and non-standard defuns Date: Sat, 06 Aug 2022 02:17:50 +0200 Message-ID: <87mtci1az5.fsf@web.de> References: <878s279dfi.fsf@web.de> <87edxwezs5.fsf@gnus.org> <87wnbnigm4.fsf@web.de> <87fsiac38p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34010"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 49592@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 06 02:19:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oK7X5-0008ev-Nx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Aug 2022 02:19:11 +0200 Original-Received: from localhost ([::1]:46316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oK7X4-00085A-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Aug 2022 20:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK7Ww-00083t-AS for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 20:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oK7Ww-0005kF-2W for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 20:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oK7Wv-0000aN-U4 for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 20:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Aug 2022 00:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49592 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 49592-submit@debbugs.gnu.org id=B49592.16597450832178 (code B ref 49592); Sat, 06 Aug 2022 00:19:01 +0000 Original-Received: (at 49592) by debbugs.gnu.org; 6 Aug 2022 00:18:03 +0000 Original-Received: from localhost ([127.0.0.1]:60737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK7Vz-0000Z4-9H for submit@debbugs.gnu.org; Fri, 05 Aug 2022 20:18:03 -0400 Original-Received: from mout.web.de ([212.227.15.14]:47005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK7Vt-0000YS-Tg for 49592@debbugs.gnu.org; Fri, 05 Aug 2022 20:18:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1659745071; bh=1iNfakOOMy4elyMnnAifbV/Z0FK8/9lhVCvpk1R/aDc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=StT4J9Bwx5IsApo7kY5JsXYVTlYGdW3JN+QLmgzWQpxfCiKeGDdB9uNeZHUI6WeP6 YIqTZzfv+Mm41EvurCkXVTl5PlI6lOhdH5dXvc1QIIYyLLqWr5CWDC0qwYkNQyAdRH XFXm8Ee+Z4saEdmxMlvoPdeDRDqtcuwwa6VSXGk8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MyNwm-1nULq722eq-00yyKh; Sat, 06 Aug 2022 02:17:51 +0200 In-Reply-To: <87fsiac38p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 05 Aug 2022 13:57:10 +0200") X-Provags-ID: V03:K1:MxkqtdYk3BL7xNPR1jVosnsi9wV+lLi5lxnoe062QdyyV3oaWUm vqmEJk8AOcBuCvk0BsVMAeXHd2ZKGhRX4YbO0OONKNFys52zjgE6HHgLsBImRN26JHYtndp h5y9zgOnHEV/Iuq/JvMcdTx2KaIEj3nXCAn3kxKS0+rHG2sV/R6L1RNl7NOrt7acXoBaTKk uLQjoinhEaCVbdq9cnqJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:mvZeFz9YVoU=:M+UpMObGdoNb1RRfWMXwQM 6tkiVEzrVKPOApSqCVIFsfhmZeFO7mjab6XiwxoPVq59joZxqu+Kv8RF/pFj92ojtbAcyDXxT 9i5oX3yyn7q1PmC3fDRL+LRT+QY3J6z2wn3Qp8NDavAJMnNWXJzWxUoQvlvVHY41TWPKbKM+D Ul3lA3yhwa/rsuW1Royy2tFx0gowq+8lmmbpYS1e4Ree8plEecOL33ef9rIIcryONIL6BCWh6 Cic/rwMCEB/nvi5AvdyZ/MqO9hN4HOTExp7b4l7BENEnHh2JOMNShVyY5mr5nt0OOuweqUEOb tf42xD9ybeHhArGYZ4wnLy2DXZoLiECB/DsSPSeTdrANIhzzSSkR7CTZtB/5JMvKnhoq/HdgK TkgA+wIXgHpdiQ/djuo9FnM+9uSJ+N6un+PK2/GwRNeTl/1KqLdV8LF3IAk5I6G6nZVjaF57K b/zuTx9oGIXKC40wfqlzz+4Vs81j3P8kAed/MT+7Lonlp26oKoQVTiZGzk1g0ulSFnfxN8tUT Q6+zF5hYsk2fqt/Fj1CtgPXDOLqFMD220OR8Gd8wtJrAqwbNfrYWvok0FPuvSXnJQfrWKW58e CE2Hxvfb1eLW7+gsaOBwvnrHc1SG4s5BTDxs0jZQ+zrm2DpZS1RJ0l20pPQ7F5qpXsO8W91hj OAAom3ay39wHi3dSg8v2VZQbrQrSm88eO9JJ3IJN/U9z794+H2d/XD2dO4aOPBI8YQQyy+ARg rPfV1Z3ioWRAVD8ukSXrxoGojaUPQyTEsI2gM/4o31RI/aHQ7853vVa8JUHpM27s6+G0Qnvh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238948 Archived-At: Lars Ingebrigtsen writes: > > I don't follow - edebug-spec of what, in the above case? > > I was suggesting that we could use the edebug spec (instead of > heuristics) if it exists, You want to find out the correct NAME of the thing being defined by looking up the edebug-spec of the current top-level form instead of simply assuming that the NAME is just the first argument of the call? Makes sense - but I don't know if it's a big win and Edebug specs help out in enough cases (lots of macros don't have one, even in Emacs itself, e.g. `defvar-keymap'). Anyway, it wouldn't harm and motivate people even more to write Edebug specs. Or do you intent to give up the heuristic of using the first argument completely? I don't think that would be a good idea. Because this heuristic works very well in practice IME. AFAIR, most of the time, or every time, when I saw the heuristic of `lisp-current-defun-name' failed, the top-level expression was not a defining form (like in my example) and `lisp-current-defun-name' returned the complete sexp - and treating this case specially would already give quite good results I think. Michael.