From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#58518: 29.0.50; [PATCH] Turning off compilation-minor-mode removes fontification of other modes Date: Sat, 15 Oct 2022 12:25:32 +0200 Message-ID: <87mt9x4c4j.fsf@gnus.org> References: <87pmeue8s3.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 58518@debbugs.gnu.org, Stefan Monnier To: miha@kamnitnik.top Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 15 12:26:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojeNO-0000y8-Hh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 12:26:42 +0200 Original-Received: from localhost ([::1]:59830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojeNN-0000k0-05 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 06:26:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojeMl-0000im-2T for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 06:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojeMk-0007d2-2S for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 06:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojeMj-0003UR-Nz for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 06:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58518-submit@debbugs.gnu.org id=B58518.166582954813396 (code B ref 58518); Sat, 15 Oct 2022 10:26:01 +0000 Original-Received: (at 58518) by debbugs.gnu.org; 15 Oct 2022 10:25:48 +0000 Original-Received: from localhost ([127.0.0.1]:39573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojeMW-0003U0-Fc for submit@debbugs.gnu.org; Sat, 15 Oct 2022 06:25:48 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojeMU-0003Tg-8O for 58518@debbugs.gnu.org; Sat, 15 Oct 2022 06:25:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eo2107vitzMh0+HKAZX2mYVrTo9olPHspkIE8RZA77g=; b=gwlbJsYU6OeaciZULziTFv/RFz y5zpfxetWgFvYx6quq1IjBQzPMR/nrQpCrno06csEuhnkjNTQqO0cuUnSbJHkKrL37Syf8x4Iqx8r EKd2SPD1cq+ABuH46sR9W3aKRIF44gBQ7mIvb7EB75NnjpOnriZfxYLBJfLcp/SQvUlI=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojeMH-000764-6s; Sat, 15 Oct 2022 12:25:35 +0200 In-Reply-To: <87pmeue8s3.fsf@miha-pc> (miha@kamnitnik.top's message of "Fri, 14 Oct 2022 17:15:24 +0200") X-Now-Playing: Bill Callahan & Bonnie Prince Billy's _Blind Date Party (2)_: "The Wild Kindness" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245535 Archived-At: miha@kamnitnik.top writes: > The attached patch makes them return to the face they had after step 2, > as specified by the grep command. [...] > - `(font-lock-face ,(if leave > - compilation-leave-directory-face > - compilation-enter-directory-face) > + `(compilation-face ,(if leave > + compilation-leave-directory-face [...] > + (let ((alist (copy-alist char-property-alias-alist))) > + (cl-pushnew 'compilation-face (alist-get 'face alist)) Hm, it's an interesting approach -- we don't use this trick elsewhere in other mode (I mean, except for `font-lock-face'), but this seems like a good solution. But since it's so unusual, I wonder whether there's any reason we don't use this more in general. Are there performance impacts, for instance? (I don't think so, since it's a buffer-local variable.) But I've added Stefan and Eli to the CCs; perhaps they have comments.