From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#58875: 29.0.50; emoji-insert triggers a Lisp error Date: Wed, 02 Nov 2022 23:39:04 +0100 Message-ID: <87mt99q8vr.fsf@bernoul.li> References: <87eduqml1d.fsf@gmail.com> <87leoxp69o.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30364"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec , 58875@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 23:40:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqMPL-0007dK-Ts for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 23:40:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqMOz-0003Om-DI; Wed, 02 Nov 2022 18:40:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqMOx-0003Od-8m for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 18:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqMOx-0002mT-04 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 18:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqMOw-00063k-Fg for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 18:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58875 X-GNU-PR-Package: emacs Original-Received: via spool by 58875-submit@debbugs.gnu.org id=B58875.166742875323230 (code B ref 58875); Wed, 02 Nov 2022 22:40:02 +0000 Original-Received: (at 58875) by debbugs.gnu.org; 2 Nov 2022 22:39:13 +0000 Original-Received: from localhost ([127.0.0.1]:47336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqMO8-00062b-Mw for submit@debbugs.gnu.org; Wed, 02 Nov 2022 18:39:13 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:58472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqMO7-00062S-2z for 58875@debbugs.gnu.org; Wed, 02 Nov 2022 18:39:12 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id ADDBD16483; Wed, 2 Nov 2022 23:39:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:references:in-reply-to:subject:subject :from:from:received:received; s=sel2011a; t=1667428746; bh=Urh+6 pcPtx3hGXujkUtR3ciLZEByafcgSswdQGoloMQ=; b=QkGUTNlimbZfx+tnT/8Gv by2BC9mu/Q8gKpTHvQoBpSFIOjs3ES/AyZhMO7rfEdPd2cm0yFKWQ4IDrE2v9CDe fBIHow1SVk73Y8tp8swCCitHFs7zISo4D6Chkr16zPt789yH8DSLa7a7LET7zNcJ KY/2MssOtM6xhWSrxxWxZ4= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id g7C1turMxKof; Wed, 2 Nov 2022 23:39:06 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 7AD4A16550; Wed, 2 Nov 2022 23:39:06 +0100 (CET) In-Reply-To: <87leoxp69o.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246899 Archived-At: K=C3=A9vin Le Gouguec writes: > K=C3=A9vin Le Gouguec writes: > >> If I revert 2022-10-28 "* lisp/transient.el: Update to package version >> v0.3.7-173-g81b29ca" (de5a3fa1e5), then I no longer get an error. >> >> Haven't dug deeper yet. FWIW it's not clear to me if the fault lies on >> the side of transient.el or emoji.el: Magit and rg.el's transients work >> fine AFAICT. > > Bisecting the transient repo with=E2=80=A6 > > ~/src/emacs/master/src/emacs -Q --batch \ > -L ~/.emacs.d/elpa/compat-28.1.2.2 \ > -L ~/src/emacs/transient/lisp \ > -eval '(emoji-insert)' || false > > =E2=80=A6 points to: > > ea851f3bde0b769b04ad03ab1a1341c013d0ddc6 is the first bad commit > commit ea851f3bde0b769b04ad03ab1a1341c013d0ddc6 > Author: Jonas Bernoulli > Date: Thu Oct 20 12:19:22 2022 +0200 > > Turn suffix specifications into code instead of data > > The macro `transient-define-prefix' manipulates its GROUP arguments, > but until now it expanded to new vectors using vector syntax, i.e., > data. An effort was made to evaluate lambda expressions, but that = did > not really work. > > Now the GROUP arguments are expanded into code, which evaluates to = new > vectors. This way lambda expressions are automatically evaluated a= nd > byte-compiled, but we now have to take care to quote certain lists = and > symbols. > > Functions such as `transient-insert-suffix' take group and suffix > specs of the same form as `transient-define-prefix' but because the= re > is no macro expansion step, they have to `eval' the result of parsi= ng > these specifications. > > Add a new macro `transient-define-groups', which can be used to def= ine > suffix groups that are shared between multiple prefix commands, but > don't use it for `transient-common-commands' to avoid having to make > a bunch of functions available at compile time. > > Still haven't actually looked at what the fuss is about. Based solely > on emoji.el's use of internal transient-- functions, I'd be tempted to > conclude that emoji--define-transient needs to be updated =F0=9F=A4=94 Fixed with da89281837ae85b7656070b7afbd3e6d94293b88. Thanks for the report. Cheers, Jonas