From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59435: 29.0.50; tree-sitter fails to fontify or indent simple function Date: Mon, 21 Nov 2022 19:57:08 +0800 Message-ID: <87mt8k5xm3.fsf@yahoo.com> References: <871qpw7s9k.fsf.ref@yahoo.com> <871qpw7s9k.fsf@yahoo.com> <3A4C0323-634D-437D-9510-50E59A254619@gmail.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3075"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59435@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 21 12:58:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ox5Rb-0000cH-1g for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Nov 2022 12:58:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox5R8-0006h7-HN; Mon, 21 Nov 2022 06:58:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5R4-0006gf-Hg for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox5R4-0001YD-91 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ox5R3-0002BI-Oj for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 11:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59435 X-GNU-PR-Package: emacs Original-Received: via spool by 59435-submit@debbugs.gnu.org id=B59435.16690318468338 (code B ref 59435); Mon, 21 Nov 2022 11:58:01 +0000 Original-Received: (at 59435) by debbugs.gnu.org; 21 Nov 2022 11:57:26 +0000 Original-Received: from localhost ([127.0.0.1]:45592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5QU-0002AQ-DC for submit@debbugs.gnu.org; Mon, 21 Nov 2022 06:57:26 -0500 Original-Received: from sonic317-34.consmr.mail.ne1.yahoo.com ([66.163.184.45]:43852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5QR-0002AA-9j for 59435@debbugs.gnu.org; Mon, 21 Nov 2022 06:57:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669031837; bh=ciOem5wzZqJDBIVRX5G+p3fGuvGSwM+qimwmFxe1a0Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=N3juS4GLq586pzWioE/Bvp8iCTOAHqZ/IjcQt49qzE+qW8EO+I0vbCyGoseiSpIpGd6vLppLZ2DI2tIxzUIkMzHRlXLB9mLBP2vrslVF/8iNxZpZgxlM1mx1UTsY4LqSLKIFAVTncHs8AYtBraJ48BY8GApyry466qLlzdnbDIDNEtzFYzRilYgNK9ELD2FigKfQx0Cjeh5QJimo8yDS9rSFwW27Uv263/im76amuora+tRx/9fkOKrK4T+5UB1e+0yoSUU+FVtZYDxPxSo+Es+OXg9Rnxrv4Ml3Zb9hrQW/3kFAeNP2k8aHmytqNlY6cVMEn2zTd74Mw3UyllWQLw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669031837; bh=iVjZtcz8eq44yjX6sNQRrFqSN1ZQJePIddcz90dQ/xv=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=nd1xkPTsO3qj3YciE+VXXI0l8wPRh5U2kEoGd2V/U4fQzAyMvgfNETQpKJdyy3WGOROj/xmrmojXAaEDssgGBkLz6Sywn7rdT9WOvStgVCiAVHvHZzuqjWm8c6RwbE2FHdFNvv6sGhzTRYIArFQKW8dtiQsCqZPQZcrtGWhfkJHEqQDL8lNMllienr0zjwmUMV6wyggJmdcvLPuuHidZusrMcpsqGCp0gOng1tyP3bXPBXXR4HSA0dy7U9ivem4fugFXtxdvKGm6bNXdMg17VAyoLRZveT5oeT18dpcPdlsTrsiuQNHNxfjj2dQf+N53mdOsHAorsfDTeTSakjKfXw== X-YMail-OSG: z_KfqPsVM1lPYEkqPQDvo8UODIb_4tp.1YBIXSnp4GdDASzFiTFu7Szs2H4IcSk CouTfVFLMnYd8R8WpkLoCmFxzNPN.q.ulyN7IaHr2k2kaogvg4zv6nQmAKmT5ErU5xehmWrhbx6J 8JGxgRSysNxAYkovcpoah3rmXbsLebtYCO6nS3IbhP.EugDuzVzaJGUa6Q_xCcRaYhwfwQ2NG8a9 40u3iseZTy5CW9uAUWQ5_cu9LjlQxtTIneP_lCp4tKBB.8qtt66gqJjXhJ88sdUnK2T4uTTRrijT yXqTq6uOWtf59xVSbm5nc2yTraSooqyWVrYNhRi6hO9D6YuRVWO_94tv8bsq7xrDzWU1W.CaIoD6 fjEklQJuXD7w3hr47Oh97LMQrFwQA8MWMKRq5jmLH0I8aPvnhGrxPjt3B6X9KeaUoWD01xP.2xLa Pt.jea1gNaV5B2aYArsfSuUKMM1fQMRKYVMK3y76uxvycJ64XoqsDfT7PSgqVMEMVVBl7b5DQ0hw bhIVDFYySe4P8RmdgZyiUGuZORWlwJatu4iTIvgJApsuoShu1B3_Kqk0AzMoHD44_m6.BB4kY_SD YYaU8XO7ZsSxO_pPO6cdT7_MjjE3ON6pvi5QzsUqIigGCF73RhP4UvvJKj43AT.3jpfoTT3y8Zvc yGJ84P1DKNmAxP3ig45AXcRCxSDoR1MAtjSzThaS7TwJPbwVxKT4UHvsKvDVvU4ZsMMiWP3uTUOH bgwGrZDJVS_Zyv.qORoYBO.DAHhE.KuiCZ2wuV1YkCHvI1kKmEMQN0MBr_ZGu3jaHEsj66GsLCS5 smODwPY_o2LRwI7kaVeB591FVIcTzfgr1o9mjSaqPV X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Mon, 21 Nov 2022 11:57:17 +0000 Original-Received: by hermes--production-sg3-6c8895b545-xbfp8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a0ca3db1781ba0607b4f1dd28148257c; Mon, 21 Nov 2022 11:57:14 +0000 (UTC) In-Reply-To: <3A4C0323-634D-437D-9510-50E59A254619@gmail.com> (Yuan Fu's message of "Mon, 21 Nov 2022 01:45:06 -0800") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248516 Archived-At: Yuan Fu writes: >> On Nov 20, 2022, at 10:09 PM, Po Lu via Bug reports for GNU Emacs, the S= wiss army knife of text editors wrote: >>=20 >>=20 >> c-ts-mode cannot fontify the following code: >>=20 >> ifsubmitbufl (tp) >> { >> register *kb1 =3D tp; >> extern tbase, i_len; >> register l =3D len; >>=20 >> again: >>=20 >> highprio (); /* tbase is used by protoureg */ >> iomap (&UBR, tbase +=3D UBR_SIZ); >> UBR->addr_l =3D kb1; >> UBR->addr_m =3D kb1 >> 010; >> UBR->mode_l =3D 07777 &~ UBR_INST; >> UBR->mode_m =3D 0; >> UBR->long_l =3D l; >> UBR->long_m =3D l >> 010; >>=20 >> iounmap (); >> tally_iostat (tbase); >> iospoke (UBR, P_LOCK); >> resetprio (); >>=20 >> SWITCH (S_WAIT|S_HIGH|S_IMMED, 0700, again); /* this returns to >> BR->senv[0], except >> if CL_HI */ >> } >>=20 >> here, ifsubmitbufl, tbase, l and again are fontified as types. They are >> fontified correctly by CC Mode, as three identifiers and one label. > > Thanks, I fixe the label=E2=80=99s face. Thanks. > As for ifsubmitbufl, tbase, and l, I don=E2=80=99t really understand the > syntax here, and I think neither does tree-sitter . In general > tree-sitter struggles with nonstandard (in its book anyway) syntax. Well, that code is 100% valid C. "*kb1, tbase, i_len, l" are implicitly int (which on that machine is 16 bits wide), and so is the value of "ifsubmitbufl" and "tp". > And there aren=E2=80=99t much we can do (except for maybe improve > tree-sitter-c=E2=80=99s parser). Would someone try that? > Seems to work fine here. I don=E2=80=99t see anything I changed recently = that > could affect this, either. Sorry, I think I meant "before". Place point after "l =3D len;", then press RET.