From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Date: Sun, 11 Dec 2022 09:56:18 +0100 Message-ID: <87mt7u48ul.fsf@gmail.com> References: <83iliiv0yv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , Stefan Monnier , 59956@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 09:57:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4I99-0009XS-C3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 09:57:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4I8x-0002oc-6K; Sun, 11 Dec 2022 03:57:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4I8s-0002nv-Nj for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 03:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4I8s-0007ar-Fl for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 03:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4I8s-0007H3-0D for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 03:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59956 X-GNU-PR-Package: emacs Original-Received: via spool by 59956-submit@debbugs.gnu.org id=B59956.167074899027944 (code B ref 59956); Sun, 11 Dec 2022 08:57:01 +0000 Original-Received: (at 59956) by debbugs.gnu.org; 11 Dec 2022 08:56:30 +0000 Original-Received: from localhost ([127.0.0.1]:46212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4I8L-0007Ge-SD for submit@debbugs.gnu.org; Sun, 11 Dec 2022 03:56:30 -0500 Original-Received: from mail-ej1-f42.google.com ([209.85.218.42]:44800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4I8J-0007GY-1y for 59956@debbugs.gnu.org; Sun, 11 Dec 2022 03:56:28 -0500 Original-Received: by mail-ej1-f42.google.com with SMTP id x22so21013720ejs.11 for <59956@debbugs.gnu.org>; Sun, 11 Dec 2022 00:56:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wD7//Y3mc2/PxBriZDEBRGFIBFxlmGfsXc3cY5CGb/M=; b=eoJWjK9vTC2FjCu91B5dhwBjL4K1i2+F4kk/2SuI1Dbf1z9zvSKzfu4ixLSCnyUIPg /V8nFowDyN/1vkUwYIJzeZaesbc7XdqiXF3vjqhIVsYutlCRsLdjNmqRCXWZSOpZkz4/ mk1oEzWzPtcQoyGi+kT0/8aNdH92Ky+GAl/XEilo57sdzjWP2Pera4b+oxQ6xQUsmAjR +jInN3S3F4TDJCIOO1XdiHroe9WQQh6q9C6WxV9MvGzitoLS2iSstCGyijovlgkjSn2J Q70ihI9Nb4imiarCNZJgXQ/LR1B29AiKrqoiEdprhRPJSAuqS8Gptloqjlz9hJ1UJCF1 7xPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wD7//Y3mc2/PxBriZDEBRGFIBFxlmGfsXc3cY5CGb/M=; b=tfCEK+yJoENucnysTx02tN1Cu9u4+F+i20f4IYDWiR/4YD8Fv4U5J/mOJKSscFbPG6 oWarnVuhiLyO5wPen1j3VeR6+NVRWyvUYzVdzU1t5zgIv+8Q5ta2umYPU1qVKEXo/r0r LXmDAjiWaDs+yDwVi5MkNbvWIyCv1Cb8jTOGLNIWn/Ss8TORKk2kuAXtbM3PsEc+N8Rj QhQ4QmJ994WO2XHiNhbzBKcL9MtaadiToopF2Ck83rl6wKYoQyXJ4j6BVcWXkCSgZBF5 /QVBiPiRIehBmOB9ltrbygMCbLCKMpGwy/ppcSNBl8aRQFvDCaiBZXqdKef3GUd4JpxO YA5w== X-Gm-Message-State: ANoB5pk61MW1porKncbsZVi7cKnnVbgNadYbp9dzIgqDaz1TZ9lejVxY HZdnzcwLlRRwuwCGFbELqZi2mvcoc2Zh6w== X-Google-Smtp-Source: AA0mqf7WCgs5yMkif1VDCszahvPxR0RyawDJhZNhlYvsAzyz9p5OhkHGFdJ0pawFxuHgOBcHMz3Waw== X-Received: by 2002:a17:906:3716:b0:7c0:bbab:22e5 with SMTP id d22-20020a170906371600b007c0bbab22e5mr9767002ejc.16.1670748980742; Sun, 11 Dec 2022 00:56:20 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::a4bf]) by smtp.gmail.com with ESMTPSA id q8-20020a17090676c800b007b790c18264sm1854307ejn.159.2022.12.11.00.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Dec 2022 00:56:19 -0800 (PST) In-Reply-To: <83iliiv0yv.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Dec 2022 09:44:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250583 Archived-At: On Sun, 11 Dec 2022 at 09:44, Eli Zaretskii wrote: >> Cc: arstoffel@gmail.com >> Date: Sat, 10 Dec 2022 17:25:53 -0800 >> From: Jim Porter >> >> X-Debbugs-CC: arstoffel@gmail.com >> >> Starting from "emacs -Q -f -eshell", type "echo $exec-path " (note the >> trailing space), and then hit TAB. The result is this error: >> >> pcomplete-match: Wrong type argument: stringp, ("/usr/bin" ...) >> >> This is a regression from Emacs 28, and it looks like it's due to >> 'pcomplete-here-using-help' assuming that all the pcomplete args are >> strings. However, 'exec-path' is a list (and Eshell reports it this way >> to pcomplete), so the completion fails. I think all that's necessary is >> checking that the pcomplete args are strings in >> 'pcomplete-here-using-help', but I know next to nothing about pcomplete... > > Adding Stefan, who should know more about pcomplete. > > Stefan, any suggestions? For the record, this problem afflicts just about every pcomplete rule (except probably those meant specifically for eshell). I just tried `cvs $echo-path TAB` and I get the same error. The issue here is what eshell returns via (pcomplete-arg ...) etc. Currently it can be a list. How about changing it to the string "$echo-path", with the list sneaked in as a text property?