From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60977: 29.0.60; Dired: invalid face reference with dir symlinks Date: Wed, 25 Jan 2023 00:23:52 +0000 Message-ID: <87mt67zckn.fsf@tcd.ie> References: <87mt6cdaao.fsf@tcd.ie> <86wn5e7imn.fsf@mail.linkov.net> <87sfg1q7y7.fsf@tcd.ie> <83pmb4giwj.fsf@gnu.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30651"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60977@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 01:25:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKTbM-0007mP-E7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 01:25:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKTb7-00082s-Jq; Tue, 24 Jan 2023 19:25:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKTb5-00080y-P3 for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 19:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKTb3-0005n3-QB for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 19:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKTb3-0003gM-Lb for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 19:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 00:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60977-submit@debbugs.gnu.org id=B60977.167460624314083 (code B ref 60977); Wed, 25 Jan 2023 00:25:01 +0000 Original-Received: (at 60977) by debbugs.gnu.org; 25 Jan 2023 00:24:03 +0000 Original-Received: from localhost ([127.0.0.1]:57859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKTa6-0003f5-G8 for submit@debbugs.gnu.org; Tue, 24 Jan 2023 19:24:02 -0500 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:42954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKTa4-0003ea-BY for 60977@debbugs.gnu.org; Tue, 24 Jan 2023 19:24:01 -0500 Original-Received: by mail-wm1-f45.google.com with SMTP id f25-20020a1c6a19000000b003da221fbf48so200001wmc.1 for <60977@debbugs.gnu.org>; Tue, 24 Jan 2023 16:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jUMq/1o2r6fILPJr33YmU9xqJvqhGb8QwZCpCjgo+DQ=; b=Yi7c6gHqfbDzoOpjY1t7RvHQ+f1UZsNrln2BIGV2ugG9cbLuyDVnVR1At1Si8LLSOs W5PnqNIHfY8JE0R8pYqg6aB0AjelBBV3THVHuhmCNyurg6YMhMDbO/IEHHUyFkXctZ3i Qjj4ehVBn9LoulsQl8e7PcjNucgr8tr5PikoPO2jOlYf1HqTdLLAjIDq1IlKdbr6SP8h YdfAOg4347NbHYAggK2OGMYhGeBN3PCQHsRjX9HDrybke0FEvhFMKRmwCXCdjgrUnylA HeQMWT9EGWBhPAGQIN7gyIvRyDpmR4/M4kCv3tgpjMmlY4yUbpQbT+a3ncPF7FVkhlH0 iM9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jUMq/1o2r6fILPJr33YmU9xqJvqhGb8QwZCpCjgo+DQ=; b=PWkSEqQCi7SmCjwSvL7yVFWWEbSTcJfgNk5dKaVVoD3aZaBmdzYN9qMZ9Sooq/Kbav kJV2Yf9FniQ+ePkKWA5qy0KKS+pApssiUlR0bqbriV6dXUVnYDIjLCsioZ6IZVjG9dQv bezeKylwXECRtwWOF+fQcav++4WQ1Md8n8fJnbs0/KSgKKCZzUL1xL0cWjcioIvt4Xga T/ZqFE87+yWFvET8+wJaNhgljeYUjJJVHcszoGRwhRs1+VsvufgnVFuTsMpuDAcXacFG e82Ym6HfSXyIU8C70ExCFMF1cCLgHNWaFnH2zSTK6ucEcbGAcGyFRALpwTT0Ia3FSWMm RE0Q== X-Gm-Message-State: AFqh2kr4HhdbsE3tZxg/6o0EsmDWDkhHFDvUSuMjzBUAFqxZl/xOAev2 UqLTQa6sT43lGmKU2s2J2tj9fA== X-Google-Smtp-Source: AMrXdXtq1Vf6f7HF4Nhj11k4dE8+zNvFSBlp3iopdkxf2obT1jgEZIhZLiDmi0C6adKShBpCK1uHiA== X-Received: by 2002:a05:600c:4191:b0:3d4:5741:af9b with SMTP id p17-20020a05600c419100b003d45741af9bmr37531177wmh.0.1674606234329; Tue, 24 Jan 2023 16:23:54 -0800 (PST) Original-Received: from localhost ([64.43.154.54]) by smtp.gmail.com with ESMTPSA id y5-20020a05600c364500b003d9e74dd9b2sm266168wmq.9.2023.01.24.16.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 16:23:53 -0800 (PST) In-Reply-To: <83pmb4giwj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Jan 2023 08:29:38 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254084 Archived-At: Eli Zaretskii [2023-01-24 08:29 -0500] wrote: >> Cc: 60977@debbugs.gnu.org >> Date: Mon, 23 Jan 2023 21:04:00 +0000 >> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >> But I don't know whether it's acceptable for emacs-29, or whether it >> >> conses too much during font lock. In the latter case, we could evaluate >> >> dired-directory-face once (when dired-font-lock-keywords is defined), or >> >> we could use the 'dired-directory' face directly. WDYT? >> > >> > I think the effect of consing is negligible. >> >> Thanks for confirming. >> I'll install it once we hear from Eli re: emacs-29. > > I'm sorry, but I don't see any questions you asked me about this > issue, and neither do I see it on debbugs in the discussion of the > issue. What did I miss? My question was whether the patch in https://bugs.gnu.org/60977#5 is efficient and suitable enough for emacs-29, to fix a font lock regression. Thanks, -- Basil