From: Mickey Petersen <mickey@masteringemacs.org>
To: 61529@debbugs.gnu.org
Subject: bug#61529: 30.0.50; tree-sitter: weird off-by-one error but only in css-ts-mode(?) with `treesit-node-at'
Date: Wed, 15 Feb 2023 08:25:53 +0000 [thread overview]
Message-ID: <87mt5fjpwu.fsf@masteringemacs.org> (raw)
Here's a strange one.
I don't know where to point the finger here exactly, but I think
`treesit-node-at' might have a small bug in it somewhere.
Consider this `css-ts-mode' code:
a {
background: linear-gradient(|210deg, rgba(255,82,41,1) 0%, rgba(251,165,85,1) 54%, rgba(163,73,73,1) 100%);
}
Let | be point.
Engage `treesit-inspect-mode' and you'll see it asserts that point is
at '('. OK, so that could easily be a glitch in that implementation,
but let's probe further.
With point at '2', then I'd expect `treesit-node-at' to yield that node. But it does not:
(cons (point) (treesit-node-at (point)))
=> (34 . #<treesit-node "(" in 34-35>)
Move back one point
(cons (1- (point)) (treesit-node-at (1- (point))))
=> (35 . #<treesit-node "(" in 34-35>)
Move *forward* one and it does, but it gives us `unit' but I'd expect
`integer_value` as per the explorer (and indeed the tree.)
(cons (1+ (point)) (treesit-node-at (1+ (point))))
=> (36 . #<treesit-node unit in 38-41>)
Again but with the TS implementation `treesit-node-on`:
(cons (point) (treesit-node-on (point) (point)))
=> (35 . #<treesit-node integer_value in 35-41>)
And now we get the right node.
next reply other threads:[~2023-02-15 8:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 8:25 Mickey Petersen [this message]
2023-02-15 13:42 ` bug#61529: 30.0.50; tree-sitter: weird off-by-one error but only in css-ts-mode(?) with `treesit-node-at' Eli Zaretskii
2023-02-15 13:42 ` Mickey Petersen
2023-02-15 18:35 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 19:01 ` Mickey Petersen
2023-02-15 19:42 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-16 19:48 ` Mickey Petersen
2023-02-16 21:26 ` Dmitry Gutov
2023-02-16 21:34 ` Dmitry Gutov
2023-02-17 6:16 ` Eli Zaretskii
2023-02-17 7:24 ` Mickey Petersen
2023-02-17 15:11 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt5fjpwu.fsf@masteringemacs.org \
--to=mickey@masteringemacs.org \
--cc=61529@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).