From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63312: 29.0.90; set-frame-parameter sometimes called with dead frame when quitting ediff Date: Sat, 06 May 2023 19:12:51 +0800 Message-ID: <87mt2hk91o.fsf@yahoo.com> References: <838re1hk45.fsf@gnu.org> <04798b34-f836-f889-88e7-2308229b5ff3@web.de> <833549hhoe.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18070"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Tobias Bading , 63312@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 13:14:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvFrl-0004WG-LT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 13:14:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvFrX-0003JV-If; Sat, 06 May 2023 07:14:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvFrW-0003JJ-5k for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 07:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvFrV-0001Wp-Tn for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 07:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvFrV-00022y-PH for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 07:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 11:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63312 X-GNU-PR-Package: emacs Original-Received: via spool by 63312-submit@debbugs.gnu.org id=B63312.16833715877796 (code B ref 63312); Sat, 06 May 2023 11:14:01 +0000 Original-Received: (at 63312) by debbugs.gnu.org; 6 May 2023 11:13:07 +0000 Original-Received: from localhost ([127.0.0.1]:59542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvFqd-00021g-4g for submit@debbugs.gnu.org; Sat, 06 May 2023 07:13:07 -0400 Original-Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:43287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvFqa-000219-KD for 63312@debbugs.gnu.org; Sat, 06 May 2023 07:13:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1683371579; bh=rzAK3tBc084zKrDqc6Bl0wTdKiaC63Ub8HxKR5k0FGE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=eTp09GPAvu0dWv/0z+EHckfe4Ucu8Upr7yOLES/OhflKAZgipOdVRa5x4rYm38IqBh0PbLCdKmVTsf0Cm1Bug3HkNrpAvkDf3HSp2TqmXs/qvGcGZgnSWtZYPvdqgtC+nLWh/W/2xOeoA8lB05PVPURSEZoGHSaCzuG361qYJZcgR4yVqmdAiIVV6sPGcH0bf+gLSai0qjBeZe4BXU8fIMG/IL1ofaNLoZrUQG5MewBglDDPheauu2GmdwuuCPKYnHShRlWRrGN9KBQj8PmxwjN7SyI7RpJfbLbNLGvno1aEqgZI+4sGBGFW/pTF6RDhIWeXaZUMnN4vLqAqQIld6w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1683371579; bh=lMIWdAUjv2r9gstj6mjy9rK827cX/Geh9QH0ZWHA4+b=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=hXWXV0C/mOtbQErhZtAXj0rgl1W8oGaeFmDKaHgN/a7ihImGjmEomAdfcBN4UVlLXNA4w5HCeA/bDUBf2sxllHoU9aJafsMiEI5DbYGfre1nZ6k2aNtiYOYjH7TLxUjVVhcFRcfBIvmveStReMlxeUgmjeawl/4XIjpTrxC2Myh34Jcf8MwLG3PlKDk70X/zKg5ccKBGXM9TyBCc9kM2fbnM03f9zQ2spUumRnrilwfRkrIL4qbFFWRDfRBEmDjl23ga82DpIW/2MMSRurSvpQHMyGHf1XHzr8CJm43kCC3Vr4p19BoI5k8i5RcM0EBMFbw0JOYtR0ehEos+SfSNvQ== X-YMail-OSG: 4kJy4WcVM1nFCWN3hLwWhNCyZ8PvU1rmwf21KjUO0r1GwzcOlXyRUj1sMMUP5wn s0sh2zkqyBKOvjj4Agq0uq1TRnGY7ewYLBumxp327GGz6RjL29p5jfBXXL7LJMmt.L0ndcHU6Cp0 bYbIU75_AzSwqb9kLUNhQJa2tkd.eOy3qT9.vWa09WLvBzJIhlp.NJ4p_wFBN2fgT.hX7e6iZX.2 nqUOvat24o.n14dzL3BM0NCZ4zynXaBhUAFhRWQsqDJGw7Pr3TeJDNENMhhwR6qF6fCpLc.M4wls 1B47ZH51Siqewwh1F1ydgBXgmGX1Okbbb7xz5NDvI.rxXdF.WyX7MOkRX.9ScmfcV01wt3hvEBU4 r8VXXHExUY1.AyOkc5G.C6LbHirfZIR8.k6WGKDExuzlHTrFxnrOyGmSkXHYfcKEuXVYxySbsY_k J6DXIRfDojMPXheVh9VYpxdAAAotqz_ansycnhAFdlc7MQYFi0K.gozqvvNdSILiZ9GxFLn_.NmC vgpdyRaHMD9Slv855thHEbFKT2zYvlyLF4KPzHWuKTfNi9pKcq1o0iZu4VTzT0mHBofZe1FmEtuT ablDgZiuBLYhpMWSNFhZzqoYtm6R5rKVMQf8jpM2jFmpNY90q1MeZo5KIBJIgWZfke.3sW.bbICL zHm9_gAnl9KqpMEXIPgnraPgV1CmFN_u69OYqzYbh_bzqkEfMMqQlwnD2sYNTiaaFePgpx5XI.aU gRBveDPFvQUcY6wBSO1FPA4peR1oCjuQMOVPj6ZeP7qwwXaPnhIh0RN1xnCRfFffBamKKdbR4l4E bmEV7xpt6AzLmhOFvS4fZ.n2pUS5F.np2pNkidbIvv X-Sonic-MF: X-Sonic-ID: 1e8a9aca-4086-4521-9d13-0106d78afe60 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sat, 6 May 2023 11:12:59 +0000 Original-Received: by hermes--production-sg3-6d6fb994f6-94jgf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 490477d94673c7734cba057f2d975c0f; Sat, 06 May 2023 11:12:56 +0000 (UTC) In-Reply-To: <833549hhoe.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 13:34:41 +0300") X-Mailer: WebService/1.1.21417 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261182 Archived-At: Eli Zaretskii writes: >> Date: Sat, 6 May 2023 12:10:33 +0200 >> Cc: 63312@debbugs.gnu.org >> From: Tobias Bading >>=20 >> > Does the patch below give good results? >> > >> > diff --git a/lisp/x-dnd.el b/lisp/x-dnd.el >> > index 9286a18..acfbbed 100644 >> > --- a/lisp/x-dnd.el >> > +++ b/lisp/x-dnd.el >> > @@ -609,8 +609,9 @@ x-dnd-init-xdnd-for-frame >> >=C2=A0 (defun x-dnd-after-move-frame (frame) >> >=C2=A0=C2=A0=C2=A0 "Handle FRAME moving to a different position. >> >=C2=A0 Clear any cached root window position." >> > -=C2=A0 (set-frame-parameter frame 'dnd-root-window-position >> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 nil)) >> > +=C2=A0 (and (frame-live-p frame) >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (set-frame-parameter frame 'dnd-= root-window-position >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 nil))) >> > >> >=C2=A0 (add-hook 'move-frame-functions #'x-dnd-after-move-frame) >>=20 >> It probably would, because for testing purposes I already patched >> handle-move-frame like this: > > Not really, because there could be other functions on the hook > variable, which do deal well with a dead frame. > > Po Lu, any objections to installing my proposed change? Please install on emacs-29, thanks. This hook should not be called with a dead frame though, and Martin proposed a fix for that which was installed last year, so I will continue to investigate on master.