From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63556: 29.0.90; Use of _Generic breaks Emacs build on GCC <4.9 Date: Fri, 19 May 2023 08:46:02 +0800 Message-ID: <87mt21408l.fsf@yahoo.com> References: <4b378d55-ef65-7a0f-b03d-e304785cf60d@cs.ucla.edu> <87v8gp51ys.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Spencer Baugh , 63556@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 19 02:47:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzoH2-0007P8-RW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 May 2023 02:47:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzoGu-0007ST-Uw; Thu, 18 May 2023 20:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzoGt-0007SK-4V for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 20:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzoGs-0008Bt-Ro for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 20:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzoGr-0004pG-Jn for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 20:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 00:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63556 X-GNU-PR-Package: emacs Original-Received: via spool by 63556-submit@debbugs.gnu.org id=B63556.168445718118505 (code B ref 63556); Fri, 19 May 2023 00:47:01 +0000 Original-Received: (at 63556) by debbugs.gnu.org; 19 May 2023 00:46:21 +0000 Original-Received: from localhost ([127.0.0.1]:54885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzoGD-0004oN-Gi for submit@debbugs.gnu.org; Thu, 18 May 2023 20:46:21 -0400 Original-Received: from sonic311-25.consmr.mail.ne1.yahoo.com ([66.163.188.206]:33802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzoGA-0004o7-KH for 63556@debbugs.gnu.org; Thu, 18 May 2023 20:46:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684457171; bh=r1W6+kzNJ5rQqrcuOUrL+zh4hEO6YeRISmBAi6VZ1hA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=eu9Y5ShutsDdx3zPvsGa3a+X+Ag2fCsLlD4o3kAAjiOfkqARHlxDN1/pA7wQppKWuWst6hmP4pt32PTK8sjDHWAHn9I/XjkF2WzUSeebzzvOPwk6DweEIK7wJWD3a6aY/+WWUbKyJlrPucpZQFsOr6kU5JxWci/PJB+2Hun/gUCzehy3JVLawodkmKAAVSIGfxsxJDry3X/0bVexF1bArBMfa/NLifHzKlAm/HHgtSY9CUjZe34ygz3KycqhDenFeTRgUgqWUjwIRsi2T1EtYigwNRnDx8V7l9ikVbfOGEtxP1dgrgO3FVt/s3wVgQ7DNTPvMlNSX58Oksi5XuBU1A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684457171; bh=ri+m8whqAwFNzWhTzZwjA1KNlMDovDijYwFe4yoibPa=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uRAzNbTur43C8adWc41VEDGUMChIOw9bh4WK5AM1+F+jNkzYxTJeSM2v6A5/eYXcgla6JhROFXdPSNcRSb8hMf22SFYLNsSmmCvWXp+mSF7P45tEVIryIeHN2nOdOkg7/rSOv6tKu9071ox/vrfks4TvniozJsiz6EeHoLGlOHJIhZV30EEfll2CN5Uzi/pkbdd8FGjlf4UVedTwDGQQOTQCn6XcNPuFMLnXq/+Fgg0XbYVnis5bkdCFXx8i2ikKEGJllkVDKF2altK5qN8rFA3PaPNKvvt8rFIuk1oq2X3VoPoMQDbWVD7+KtvXnBMFhZwkhJsZVEKoEUevtRZPLg== X-YMail-OSG: E_me8NAVM1nWsT4FcBis01kxZoGwQ3.HclihfeSnfF_11eAA5opK1KHTDKNPSjr ZfvUC1_rCfPrEPYfoWCcw4TIpXn0MnWdXZGyi3MovCnjHuJgfo96I0PGFystryqSYOuvbwpiA_BA Wb7.vcOWYOk29rB8TV4.L67cuG2CKLsG8txK7a1jlA4i_H1QiSdZmPUIc3qnf_UxT1KwgBYQJmSH ghKS6sCVf7kNcMhVtgGfPz0ZKl.dQBFMHe05bSJLJtMT.wlWBj75E8dFzX57De1NzzZCFyal6HIL 54W.hovI6II7iHtu1LnWzaFcmOaRCCA0kL3SylNS5SjFHOQ4laowBZJShcb29nCBrTdw_jCX2GwU 0e.cECGS5f0hXbiHwvehvzEayONOKTVLVLuaAXdcZPe6O91_AuFhXDmVgpeZTIzpMjp9V5DXTD9d RID0BWKl8ryq3aKa.AgWeYzQYgccIih9eaDd.Ce4McdEf1hlcb.eRMxPgboLL6RlBoowVItBp9.s UVnWiwycPANzmwKg9KDP.6kTzIwZIpLxKo0.V5d4TQTlveP9QG0CgxfrG3GcRko4IUDq3vnvzj36 pkNDGSRhfFs0tPAF.LdI.MSAAFPjZxIehJAQoefYTYOnPVM0GOH_bNt3nKvrTFgfsr74Ww.sl03D 8JJgxkDgDDsQ5kTcrTXZOpsbSTlk26LSqQEcpLDIKtrLSGauV9gYvhzBd4Y5O91cXfx0K7riSWMN YblPO.YbUTWL8D96jNwTxyPzIfVQQfQf8JyjFIb3TVdbTHW5RISzfbQ1cYZaKtsHr8wDbNEu3DBg VMZBeAjID32oDMz7mf_Ej11POeXc3ynr8LryKHaY7O X-Sonic-MF: X-Sonic-ID: ccf8f7b1-539a-4fe2-8f70-967ee17a030f Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Fri, 19 May 2023 00:46:11 +0000 Original-Received: by hermes--production-sg3-748897c457-njldh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4444ef54ecf12c601073b188baa392f1; Fri, 19 May 2023 00:46:09 +0000 (UTC) In-Reply-To: (Paul Eggert's message of "Thu, 18 May 2023 07:40:47 -0700") X-Mailer: WebService/1.1.21471 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261965 Archived-At: Paul Eggert writes: > There would be problems in doing that. GCC and Clang both have > problems with _Generic (suggested by this original bug report), and > some of them have to do with which warnings you've enabled. The > configure-time check would run without the warnings whereas the build > would run with them. > > This is partly why intprops-internal.h has given up on _Generic with > GCC and Clang; see its ifdefs. I assumed that these problems didn't > apply to their simple use in elogb, but apparently I assumed > incorrectly. [...] >> Btw, couldn't the macro be defined to something along the lines of this >> when the compiler only supports C99? >> #define foo(expression) \ >> (sizeof (expression) == sizeof (signed char) \ > > That wouldn't work on unusual platforms that have padding bits. Of > course we could simply refuse to port to targets like that; still, I'd > be reluctant to do that just for this little issue. How does intprops.h work on such systems? > I couldn't measure the slowdown in this case. Until it's measurable I > wouldn't worry about it. To some extent I put in that _Generic > originally more as documentation than as an actual attempt to speed > things up. OK, but that's the second use of `long long' in src/ outside of NT-specific files. I can't help but be a little skittish.