From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 13:14:27 +0200 Message-ID: <87mt1rmjjg.fsf@gmail.com> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="828"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 13:15:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2VPq-000AcD-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 13:15:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2VPV-0000cq-8F; Fri, 26 May 2023 07:15:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2VPS-0000cL-Np for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 07:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2VPS-0000kg-F4 for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 07:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2VPR-0007qn-OH for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 07:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 11:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168509967829929 (code B ref 63731); Fri, 26 May 2023 11:15:01 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 11:14:38 +0000 Original-Received: from localhost ([127.0.0.1]:48964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2VP4-0007mb-1N for submit@debbugs.gnu.org; Fri, 26 May 2023 07:14:38 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:47481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2VP1-0007mH-Br for 63731@debbugs.gnu.org; Fri, 26 May 2023 07:14:35 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-3f6dbe3c230so6724645e9.3 for <63731@debbugs.gnu.org>; Fri, 26 May 2023 04:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685099669; x=1687691669; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ptRj+iV/W4FecMdJI3eamHw4hiE04BftV6wOXUwwqIw=; b=DmMa/Yxl/f0YtVai9h8gAtcwRqwNZsuJttnVyuyHAsrt2MDBO1xMYKoN2VlPIZto1n SsqkBpSEPWdrwAfrdbO2x53sU4yKSL6m6tG4JjIOQsMdfKWsO/ZqVXS3nDbHRvTsXCV6 q+vKqR8kjFcCClwIIPtAfSkgXg4r09YG/ZXebFL3yC5ZDx8MX3fcBZoRkhQTtaQYHp2T btk8OsXmXlbb9Yom2UqFPwN3rf4gavSzPPTrEDGgPiREjYxrGiHyiJSPAJqLmtI7DzSH ELRuQDqY6UmIGLT7fcGGJoifxObfGWdryZqx4LTdbj1Bp373mEk7SKG0qZDowneC2tpu 7mbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685099669; x=1687691669; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ptRj+iV/W4FecMdJI3eamHw4hiE04BftV6wOXUwwqIw=; b=Q0bpbjDYS7Z10TkJRLtwy4C8w3rdjf3oCTlSQsojfXoBLKBRfIQO6V7IT6O5fCNjdb fmhjrxjixiuwwQ+wxnCrmumx04RNqRaPBnSnkV0Ze+gFmL3S8wJIXms4oe87aTlPHfve SzYYEbU2aodhv4jSMKQWXYI9aE8fdsgjlYprzwc9juw9aXg93PBZlgsxTNp5oGaihon/ I8osRtrvwnkpS/qDEMtQTKoDGpK/I8F4Jl3Y4CpcWatxckOc5mBRJZcaPK/tNjkSjUt5 M3Bzrv/fb5nb6rvPOZrPsRJHohgNE/5ZNnAMh5M26XqYtvHdauRlWFqb9hIIdTAiOdjx UhKA== X-Gm-Message-State: AC+VfDyyCjxmyDFmOEMG1V+zOuCLHg/JnJXdrppE6kEf/w4hhPMpger1 sVnEuMJMkps+M5AAr3mJkEqY7BKSnbk= X-Google-Smtp-Source: ACHHUZ7hHjpep1IgXFbcX672jdvCyeFgzfRsrUW+16ly9JEdxhwh2JUABBGoFzFitEimYKdFZwweZA== X-Received: by 2002:adf:f644:0:b0:309:cb7:1935 with SMTP id x4-20020adff644000000b003090cb71935mr1251157wrp.25.1685099668668; Fri, 26 May 2023 04:14:28 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id g10-20020a5d554a000000b002e5ff05765esm4886207wrw.73.2023.05.26.04.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 04:14:28 -0700 (PDT) In-Reply-To: <83ilcflbua.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 May 2023 11:46:05 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262427 Archived-At: >>>>> On Fri, 26 May 2023 11:46:05 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Steven Allen , 63731@debbugs.gnu.org >> Date: Fri, 26 May 2023 10:34:02 +0200 >>=20 >> Ugh. The following fixes it for me: >>=20 >> diff --git a/lisp/composite.el b/lisp/composite.el >> index fb8b76114f4..af86d1436d3 100644 >> --- a/lisp/composite.el >> +++ b/lisp/composite.el >> @@ -756,7 +756,7 @@ compose-gstring-for-dotted-circle >> ;; Allow for bootstrapping without uni-*.el. >> (when unicode-category-table >> (let ((elt `([,(purecopy "\\c.\\c^+") 1 compose-gstring-for-graphic] >> - [nil 0 compose-gstring-for-graphic]))) >> + ))) Eli> This is unacceptable, AFAIU. We cannot unsupported (or change) the Eli> correct display of mark characters, can we? Right. I=CA=BCll hold off pushing it =F0=9F=98=83 >> Although the following is less invasive: >>=20 >> diff --git a/lisp/composite.el b/lisp/composite.el >> index fb8b76114f4..333428f008a 100644 >> --- a/lisp/composite.el >> +++ b/lisp/composite.el >> @@ -762,6 +762,11 @@ compose-gstring-for-dotted-circle >> (if (memq val '(Mn Mc Me)) >> (set-char-table-range composition-function-table key elt))) >> unicode-category-table)) >> + ;; for Emoji presentation selector >> + (set-char-table-range >> + composition-function-table >> + #xFE0F >> + `([,(purecopy "\\c.\ufe0f") 1 compose-gstring-for-graphic])) >> ;; for dotted-circle >> (aset composition-function-table #x25CC >> `([,(purecopy ".\\c^") 0 compose-gstring-for-dotted-circle])) Eli> Can you please explain why the current setup doesn't work in this Eli> case, even though "C-u C-x =3D" says the composition was done? An= d how Eli> the above patch fixes that? Composition is done for 1f44d+fe0f, but I suspect that with the current setup, composition is called again for FE0F, which results in the box glyph. With the second patch we will only do backwards looking composition for FE0F >> Didn=CA=BCt we conclude that composition had some issues with multip= le >> entries for the same codepoint if there was a mix for forward and >> backward looking regexp? Eli> Not sure I understand to what does this allude. What mix of forwa= rd Eli> and backward looking regexp do you see? You=CA=BCre right, there=CA=BCs no forward looking regexp, only a backwards= one and a no-regexp. But it=CA=BCs undeniable that: [nil 0 compose-gstring-for-graphic] causes the issue. I=CA=BCve never been clear on the semantics of that. Robert --=20