From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Mon, 05 Jun 2023 16:27:28 +0200 Message-ID: <87mt1ehtm7.fsf@gmail.com> References: <87a5xrzsph.fsf@stebalien.com> <87jzwqb7r3.fsf@gmail.com> <83ttvuf29m.fsf@gnu.org> <87a5xmaqul.fsf@gmail.com> <83r0qxg4q0.fsf@gnu.org> <875y88bhvr.fsf@gmail.com> <83ilc8eapd.fsf@gnu.org> <83edmvcpzl.fsf@gnu.org> <87wn0n9uol.fsf@gmail.com> <83a5xjcgev.fsf@gnu.org> <87sfbb9m4y.fsf@gmail.com> <87o7ly9t6b.fsf@gmail.com> <83edmuax13.fsf@gnu.org> <87fs7a9hl3.fsf@gmail.com> <834jnqaun6.fsf@gnu.org> <878rd29d9u.fsf@gmail.com> <83leh19kec.fsf@gnu.org> <877csijbuv.fsf@gmail.com> <83fs763vez.fsf@gnu.org> <87wn0ihvyj.fsf@gmail.com> <83cz2a3tsl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 05 16:28:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6BC2-0002g4-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jun 2023 16:28:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6BBn-0008ID-5l; Mon, 05 Jun 2023 10:28:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6BBi-0008EC-KJ for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 10:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6BBi-0001iw-CW for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 10:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6BBi-0001K6-7f for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2023 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.16859752585053 (code B ref 63731); Mon, 05 Jun 2023 14:28:02 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 5 Jun 2023 14:27:38 +0000 Original-Received: from localhost ([127.0.0.1]:50047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6BBK-0001JR-0V for submit@debbugs.gnu.org; Mon, 05 Jun 2023 10:27:38 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:52711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6BBI-0001JD-6d for 63731@debbugs.gnu.org; Mon, 05 Jun 2023 10:27:36 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-30e3caa6aa7so2042684f8f.1 for <63731@debbugs.gnu.org>; Mon, 05 Jun 2023 07:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685975250; x=1688567250; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=i1gv1NpOkOflxJ2f3Y+2NK/vfTAUWjDXC4FI6i97zGA=; b=OTSWEd56Kmsw6DQdT/4124/nMhKQ7SgD592IrVqSq5RAj+9SzXAo571hKr/SEkZC6X HGJY3KUoOlk5uP9wvWD30jk40ZvliMerz9E6Vp4+gqQJZ8sx7T/o7tmD6v0ixrn0KvgN OFYfZ5MfjpmCe0knCV6iHOKiK7+uQ/hwD4MCLwA9QYJNhtnLXJLtg3nuEqJUIYR5mMFB dXfaX7LnCZkEbt5utlEtY6awm43kdEpGKWriIOzjNIqiTiJAOn/KWZQPCrGCVKIwCVmc l6Q0A4CuR3dNgTrlof26K88JBvd39ewePJYosqveXesdQdiu6OR8xPFACuiGFp9ObpBN p7pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685975250; x=1688567250; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i1gv1NpOkOflxJ2f3Y+2NK/vfTAUWjDXC4FI6i97zGA=; b=bb4J7iQ8nHasQ4HRMSSy2sg97HH7FG/8Mhyebd2KifTej6CusSYeeyg7tZUW7SFhCG sEOguRw27GhF8dXLKgjqkfG3alKGEoHjPFx2P04Hocnztq9LB/7+yOZMcwAUyVP9Cqdq lAZdpFThNhigPG3wo2Kof6u2x1SMPcSd59KY2PWFT5RyT+Ps8D3dSEly61rrwETfo3pL 0rnfFJbOI1nCryLGICJ0XeJi+dcfqZzDxAljS55r+1O4AjME0BFFXCbJAO6YJ4M2A27v feaxVrcWZf4uC6PzGqLsMvzwy0nPOgRpeciaewxRabJZ2ssS6T+WEDTrmzyHcgIahKRE J8cg== X-Gm-Message-State: AC+VfDwN760mol+BSpeWNE6h6NurNHC2R3BfOLMJWxFDoQH5yVEZk0Q3 p5njSXgXL1ptRfLPv4wZkIQ= X-Google-Smtp-Source: ACHHUZ4JApDvvuTCpFemnuNffT/GF/lik09npn+tUS7JsSoTCJlIKSEq8VPkgpXg+E/2odP01WPDhw== X-Received: by 2002:a05:6000:4eb:b0:309:44ed:ccff with SMTP id cr11-20020a05600004eb00b0030944edccffmr6519812wrb.1.1685975250067; Mon, 05 Jun 2023 07:27:30 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4585000000b003078354f774sm9958011wrq.36.2023.06.05.07.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 07:27:29 -0700 (PDT) In-Reply-To: <83cz2a3tsl.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Jun 2023 16:47:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263015 Archived-At: >>>>> On Mon, 05 Jun 2023 16:47:22 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 63731@debbugs.gnu.org, steven@stebalien.com >> Date: Mon, 05 Jun 2023 15:36:52 +0200 >>=20 >> >>>>> On Mon, 05 Jun 2023 16:12:20 +0300, Eli Zaretskii said: >>=20 Eli> This is simple enough to install on emacs-29, I think? >>=20 >> The main change is in font.c, and looks like this. I think it=CA=BCs= too >> big for emacs-29 (breaking composition is very easy, it=CA=BCs entir= ely >> possible I=CA=BCve missed a few cases :-) ) Eli> Hmm... I though just changing the fontset in fontset.el would be Eli> enough. It=CA=BCs almost enough to do that, and to check if the triggering character is U+FE0E, bu then we fall foul of the composition rule forward/backward issue again. If we could have forward and backwards looking rules working together, then font_range would get passed U+FE0F or U+FE0E as the triggering character, it could choose the font, and there would be no need to peek at the next character. Robert --=20