From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66971: 30.0.50; [PATCH] Invert for flashing Date: Mon, 06 Nov 2023 17:33:57 +0100 Message-ID: <87msvqet8q.fsf@ledu-giraud.fr> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29147"; mail-complaints-to="usenet@ciao.gmane.io" To: 66971@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 06 17:34:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r02Yo-0007Jl-VQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Nov 2023 17:34:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r02YV-0000i3-9c; Mon, 06 Nov 2023 11:34:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r02YT-0000hs-9f for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 11:34:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r02YS-0007tU-SR for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 11:34:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r02Z4-0001XK-8Y for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 11:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2023 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16992884915880 (code B ref -1); Mon, 06 Nov 2023 16:35:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Nov 2023 16:34:51 +0000 Original-Received: from localhost ([127.0.0.1]:40455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r02Yt-0001Wm-24 for submit@debbugs.gnu.org; Mon, 06 Nov 2023 11:34:51 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:40668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r02Yp-0001WT-Tj for submit@debbugs.gnu.org; Mon, 06 Nov 2023 11:34:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r02Y9-0000cP-5q for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 11:34:05 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r02Y4-0007rH-Sl for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 11:34:04 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=orwFgUpr NVmsIXS4r+VSZWdQrZ590DK2qgLc/0/+YWE=; h=date:subject:to:from; d=ledu-giraud.fr; b=1EEkTqnCh3ni/mn4r1XVOGHhwKqshmWCuOWBjd1chBmLz93e7T QtiDC7EaVO6IUXuHo77OiS84Y/UHuezgB6Bg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=orwFgUprNVmsIXS4 r+VSZWdQrZ590DK2qgLc/0/+YWE=; h=date:subject:to:from; d=ledu-giraud.fr; b=aumEicfRZQqGqQf6PgLl6cVCggjY3Fp2gW9PEXBhVuEiQ8oXm+ 3zxifBPrUC+Ohgct4tT15+MpBNIgHIoPH3V5niv8tHK68xY4IORk+lnLbtq0Ms3hxmsSaQ lXMfJhYXNji2vMkDqUEdoToW6D0+RLceFsGWJFPImYobFK9yMovQGLSmWdwgUgLt5jZPxM VfWnpH9GM9U+H4MVzp2YxIP0/Unt2iGsYFv+pNstEf8Wt+lxe/teopNwocm1onem3aauBh gO+PQYvsGxt2w7sG6unGeeYmqdt7LgnkqYkxV/b6VlB6a/lUnFAJSm3WeNMIf10jsDeX8A 6+8jeL9QdOSw== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 1272d9f7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 6 Nov 2023 17:33:58 +0100 (CET) Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273882 Archived-At: --=-=-= Content-Type: text/plain Hi, Maybe that's just me (or the theme I'm using) but when there is antialiasing involved, the visible flashing produces rather ugly glyphs. It is much more pleasing with this patch. Or maybe, we need a user custom for it. WDYT? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Just-invert-destination-for-flashing.patch >From be50297d437e7cd42e89f0fb7f4b4ef233db7dbf Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Mon, 6 Nov 2023 17:12:01 +0100 Subject: [PATCH] Just invert destination for flashing * src/xterm.c (XTflash): Use invert for flashing. --- src/xterm.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/xterm.c b/src/xterm.c index d01c4da0564..31892f22690 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -11435,12 +11435,9 @@ XTflash (struct frame *f) if (FRAME_X_VISUAL_INFO (f)->class == TrueColor) { - values.function = GXxor; - values.foreground = (FRAME_FOREGROUND_PIXEL (f) - ^ FRAME_BACKGROUND_PIXEL (f)); + values.function = GXinvert; - gc = XCreateGC (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), - GCFunction | GCForeground, &values); + gc = XCreateGC (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), GCFunction, &values); } else gc = FRAME_X_OUTPUT (f)->normal_gc; -- 2.42.0 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.4) of 2023-11-06 built on computer Repository revision: be50297d437e7cd42e89f0fb7f4b4ef233db7dbf Repository branch: mgi/blink Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: OpenBSD computer 7.4 GENERIC.MP#0 amd64 Configured using: 'configure CC=egcc MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --exec-prefix=/home/manuel --with-x-toolkit=no --without-cairo --without-dbus --without-gconf --without-gsettings --without-sound --without-compress-install' Configured features: FREETYPE GIF GLIB GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired Minor modes in effect: gnus-dired-mode: t display-time-mode: t display-battery-mode: t server-mode: t override-global-mode: t repeat-mode: t savehist-mode: t desktop-save-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-1.4.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs Features: (shadow sort mail-extr wdired misearch multi-isearch emacsbug smerge-mode diff whitespace org-duration org-agenda sh-script smie treesit executable vc-cvs vc-rcs log-view pcvs-util emacs-authors-mode org-indent oc-basic org-element org-persist org-id avl-tree ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-version org-compat org-macs mule-util jka-compr on-screen paredit gnus-dired autorevert filenotify make-mode vc-hg conf-mode vc-dir ewoc vc-git diff-mode vc vc-dispatcher bug-reference time battery cus-load exwm-randr xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-summer-theme ef-themes modus-operandi-theme modus-themes zone speed-type url-http url-auth url-gw nsm compat ytdious mingus libmpdee reporter edebug debug backtrace transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base pcase timezone icalendar gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-x dired-aux dired dired-loaddefs notifications dbus xml cl-extra help-mode use-package-core repeat easy-mmode savehist desktop frameset debbugs-autoloads ebdb-autoloads ef-themes-autoloads exwm-autoloads hyperbole-autoloads magit-autoloads git-commit-autoloads finder-inf magit-section-autoloads dash-autoloads on-screen-autoloads osm-autoloads paredit-autoloads rust-mode-autoloads speed-type-autoloads transmission-autoloads with-editor-autoloads info compat-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue lcms2 dynamic-setting font-render-setting xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 774061 172874) (symbols 48 53736 2) (strings 32 176156 9038) (string-bytes 1 5540049) (vectors 16 106081) (vector-slots 8 2168684 207892) (floats 8 523 330) (intervals 56 27844 62) (buffers 992 103)) -- Manuel Giraud --=-=-=--