From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#67764: 30.0.50; Opening image in eww no longer works Date: Tue, 12 Dec 2023 14:44:12 +0530 Message-ID: <87msufu6jf.fsf@gmail.com> References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> <83edfsvj0a.fsf@gnu.org> <87r0jst5x5.fsf@gmail.com> <87h6kn4z2q.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30231"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67764@debbugs.gnu.org, Eli Zaretskii , jm@pub.pink To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 12 10:15:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCyrF-0007eA-So for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Dec 2023 10:15:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCyqm-00016Y-La; Tue, 12 Dec 2023 04:14:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCyqk-000167-Ru for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 04:14:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCyqk-0006G0-Jv for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 04:14:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCyqz-0000Z0-SM for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 04:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2023 09:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs Original-Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.17023724802122 (code B ref 67764); Tue, 12 Dec 2023 09:15:01 +0000 Original-Received: (at 67764) by debbugs.gnu.org; 12 Dec 2023 09:14:40 +0000 Original-Received: from localhost ([127.0.0.1]:55289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCyqe-0000YA-6X for submit@debbugs.gnu.org; Tue, 12 Dec 2023 04:14:40 -0500 Original-Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:52581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCyqb-0000Xw-FW for 67764@debbugs.gnu.org; Tue, 12 Dec 2023 04:14:39 -0500 Original-Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-6cea0fd9b53so3221859b3a.1 for <67764@debbugs.gnu.org>; Tue, 12 Dec 2023 01:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702372456; x=1702977256; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EHqqhA14wm+P1YbeegGRYfeefh+zlZzm3M5eoYPBdKA=; b=ZZsQ7jvrd80Z35TShCLEMpeeR3r+BECqnk0PfNnirMKMULpzGpmfWNOS+nTAO6FnhN OEMs35rbMXHxFbw49r8N3LxucaJi6E/+K/xbzZVHS3UBec0jtx9eWjzTv3ONgx9hhDAM mSs7XV/GQHAVTHSKou+2ztVLAkt46z8pluoc8BjZuT/DssaktHcqHa8BS2b2vnSC3A5F h2T1f/Yn5wIf8Uo6emqWR2cyE35nkIR+C6PCIBE2XyGr6g9gT244iOh5V+aaEPtRnnVP wJMTPk4o5hz9BlwBKPIWECrFXIkBLREdkSItdUP10p48Dtbp+bm2RIFR7qNkIEediyK4 I9SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702372456; x=1702977256; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EHqqhA14wm+P1YbeegGRYfeefh+zlZzm3M5eoYPBdKA=; b=TbcFeIaXd0qCqTu4BjSHZxLkKkECqTJe9uG1gD7EynM3NGZBjgJR76J2TAUhMJydYc yeXJQygd6JFztJxT+7msePUqjK1Oc2Bi/3DNaHdkrb69Ie6m1LsQES7UqCC0Rq4+rmLK 2OJze4nIXdyVtzXyad6CTWBa5qt6OnGtLXxFbhzzyZ21LgLIPOXh/hNcZj4YnH3EyPP9 VZGppV1D4h9CIe0y0Z7EgczDg75P7vfycH397Efm7ROAz9zzbWkiAcvSGHHhrM2Xz59t Cd+lpUD6j+pT6DRAxdlij9Fe4FEot0AWnfH8xUhz4y49/RbZG7UU8hH3v/DA5grSw7VF IBQw== X-Gm-Message-State: AOJu0YxcUtwDLky49IZaFXMYiON4pdg7Ah6gQvvWpxBesq3x+pCkywtu UXXdHK90HKv8AxtZhCLHkEA= X-Google-Smtp-Source: AGHT+IHCG7XO00KsZ8XHHNx93+jHcbsyH0RW3OTiqqKf0SDfPttnshIfQnyW4epsScWiV1OTxCMPdA== X-Received: by 2002:a05:6a00:4655:b0:6ce:6a06:1caa with SMTP id kp21-20020a056a00465500b006ce6a061caamr2516628pfb.20.1702372456387; Tue, 12 Dec 2023 01:14:16 -0800 (PST) Original-Received: from localhost ([49.204.128.180]) by smtp.gmail.com with ESMTPSA id h5-20020a62b405000000b006cdb8ef2db6sm7925924pfn.94.2023.12.12.01.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 01:14:15 -0800 (PST) In-Reply-To: <87h6kn4z2q.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 12 Dec 2023 09:14:37 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276024 Archived-At: --=-=-= Content-Type: text/plain [Tuesday December 12, 2023] Manuel Giraud wrote: > Visuwesh writes: > > [...] > >> diff --git a/lisp/net/shr.el b/lisp/net/shr.el >> index 9f030b4c743..bf5038a421d 100644 >> --- a/lisp/net/shr.el >> +++ b/lisp/net/shr.el >> @@ -1137,7 +1137,9 @@ shr-put-image >> (when image >> ;; The trailing space can confuse shr-insert into not >> ;; putting any space after inline images. >> - (setq alt (string-trim alt)) >> + ;; ALT may be nil when visiting image URLs in eww >> + ;; (bug#6774). > > There is a 6 missing in the bug reference ;-) ...and in the commit log. I don't know how I managed to mess it up. Thanks for catching the mistake. Revised patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-shr-put-image-with-nil-value-for-ALT.patch >From 4327fb4eae80b217437fbabae6c2ef7c6ac940a3 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Mon, 11 Dec 2023 17:09:03 +0530 Subject: [PATCH] Fix shr-put-image with nil value for ALT * lisp/net/shr.el (shr-put-image): Account for nil value for ALT. (Bug#67764) --- lisp/net/shr.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 9f030b4c743..d6ea5213337 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1137,7 +1137,9 @@ shr-put-image (when image ;; The trailing space can confuse shr-insert into not ;; putting any space after inline images. - (setq alt (string-trim alt)) + ;; ALT may be nil when visiting image URLs in eww + ;; (bug#67764). + (setq alt (if alt (string-trim alt) "*")) ;; When inserting big-ish pictures, put them at the ;; beginning of the line. (let ((inline (shr--inline-image-p image))) -- 2.42.0 --=-=-=--