From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#68761: [PATCH] Record dependencies in packages installed via package-vc Date: Tue, 06 Feb 2024 20:05:25 +0000 Message-ID: <87mssdqry2.fsf@posteo.net> References: <87il3eu4ow.fsf@stebalien.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1594"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68761@debbugs.gnu.org To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 06 21:06:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXRhq-0000At-BN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Feb 2024 21:06:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXRha-000216-Sp; Tue, 06 Feb 2024 15:05:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXRhX-00020k-E9 for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 15:05:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXRhV-0002gw-Ho for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 15:05:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXRhi-0002LJ-FQ for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 15:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68761-submit@debbugs.gnu.org id=B68761.17072499488980 (code B ref 68761); Tue, 06 Feb 2024 20:06:02 +0000 Original-Received: (at 68761) by debbugs.gnu.org; 6 Feb 2024 20:05:48 +0000 Original-Received: from localhost ([127.0.0.1]:55167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXRhT-0002Kl-ON for submit@debbugs.gnu.org; Tue, 06 Feb 2024 15:05:48 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:35411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXRhR-0002KY-BM for 68761@debbugs.gnu.org; Tue, 06 Feb 2024 15:05:46 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3FD85240101 for <68761@debbugs.gnu.org>; Tue, 6 Feb 2024 21:05:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707249926; bh=G+aikIXdAYsy7SkZM6vXnzBO1pgTEPvsOSGm7Pb9iVU=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=BN3ZyFLRa28ftZLclnRzL6gT7X6iJhufR6dXS8nuMpZiSuFp3cmCZW1H37a9/U0tm FXlRJ4jBn4O/F64V7F8BOrx8vbPA/zBzIpvhGxvkRe81XHp3PF6vmfu4wIi4+3H1Ph u1MLcajzKU17c+qb6oIzF+fXHP8G+3niLf91s4Bxcymvn36SxZD4c98L8B2o3ci/jj V+vMXf06S3xN75XnRG5+9GkR9al3Bf/OtL6XQMqmIMMxJ2knMLTb1UuhXAKjkkiOt1 78wM82dxPiMK9H1MsLkqchSmFXjw5R8D4dGnbbgcKNg6WWCmk+6i7/CDXhvKrpYgvO cI0Arcg4aOqKg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TTvPK4XC7z9rxL; Tue, 6 Feb 2024 21:05:25 +0100 (CET) In-Reply-To: <87il3eu4ow.fsf@stebalien.com> (Steven Allen's message of "Sat, 27 Jan 2024 08:22:23 -0800") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279516 Archived-At: Steven Allen writes: > The dependency list wasn't getting recorded in the package's `-pkg.el` file. Did you notice this because of some bug or what is the motivation for this change? I'll certainly look into it, I just wanted some context. >>>From edc9f75958d5feb2a82c53879e9dde4c51921bb6 Mon Sep 17 00:00:00 2001 > From: Steven Allen > Date: Sat, 27 Jan 2024 08:17:08 -0800 > Subject: [PATCH] Record dependencies in packages installed via package-vc > > * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Record a > package's declared dependencies in the package's metadata ("-pkg.el"). > --- > lisp/emacs-lisp/package-vc.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index db0cc515e46..fc402716dab 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -532,6 +532,7 @@ package-vc--unpack-1 > (setq deps)))))) > (dolist (dep deps) > (cl-callf version-to-list (cadr dep))) > + (setf (package-desc-reqs pkg-desc) deps) > (setf missing (package-vc-install-dependencies (delete-dups deps))) > (setf missing (delq (assq (package-desc-name pkg-desc) > missing)