unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 70068@debbugs.gnu.org
Subject: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
Date: Sat, 30 Mar 2024 11:07:00 +0000	[thread overview]
Message-ID: <87msqg2d2j.fsf@posteo.net> (raw)
In-Reply-To: <86a5mgdx5i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Mar 2024 09:57:45 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Fri, 29 Mar 2024 11:31:49 +0000
>> 
>> The main intention here is to avoid underlining the first line in the
>> *scratch* buffer when flymake is enabled:
>
> If this is the goal, why such a general change?  Wouldn't it be better
> to special-case *scratch* in Flymake instead?  Making such
> generalizations runs the risk of unintended consequences.

My thinking was that one never needs to set the variable anyway, since
`lisp-interaction-mode' sets `lexical-binding' anyway.  Alternatively,
one could also modify the patch to check if `lexical-binding' is non-nil?

-- 
	Philip Kaludercic on peregrine





  reply	other threads:[~2024-03-30 11:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 11:31 bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode Philip Kaludercic
2024-03-30  6:57 ` Eli Zaretskii
2024-03-30 11:07   ` Philip Kaludercic [this message]
2024-03-30 12:54     ` Eli Zaretskii
2024-04-01  5:27       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-03  8:52         ` Philip Kaludercic
2024-04-03  9:35 ` Mattias Engdegård
2024-04-03 18:17   ` Philip Kaludercic
2024-04-03 19:07     ` Mattias Engdegård
2024-04-06 10:14       ` Mattias Engdegård
2024-04-08  7:21         ` Philip Kaludercic
2024-04-08 11:41           ` Eli Zaretskii
2024-04-08 12:02             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09  8:57               ` Mattias Engdegård
2024-04-09  9:51                 ` Eli Zaretskii
2024-04-09 10:45                   ` Mattias Engdegård
2024-04-09 11:24                     ` Eli Zaretskii
2024-04-09 13:35                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 13:42                       ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msqg2d2j.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=70068@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).