From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70213: Info-mode side window fit-window-to-buffer issue Date: Mon, 08 Apr 2024 09:56:25 +0200 Message-ID: <87msq48eza.fsf@gmx.net> References: <875xww2ncc.fsf@breatheoutbreathe.in> <86h6gg56vg.fsf@gnu.org> <871q7j3l4b.fsf@breatheoutbreathe.in> <87jzlbddt3.fsf@gmx.net> <87msq71n2a.fsf@breatheoutbreathe.in> <87sezzfo22.fsf@gmx.net> <87sezzs20t.fsf@breatheoutbreathe.in> <87y19qaff3.fsf@gmx.net> <877chaqtd4.fsf@breatheoutbreathe.in> <867chal4j1.fsf@mail.linkov.net> <5657beec-3caf-4e24-838a-111a9be63eb5@gmx.at> <87le5pt5eg.fsf@breatheoutbreathe.in> <877ch9ots8.fsf@gmx.net> <87o7ak3gfs.fsf@breatheoutbreathe.in> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33274"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: martin rudalics , Eli Zaretskii , 70213@debbugs.gnu.org, Juri Linkov To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 08 09:57:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtjsX-0008QE-DQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Apr 2024 09:57:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtjs9-0004yB-G2; Mon, 08 Apr 2024 03:56:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtjs7-0004xz-6Y for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 03:56:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtjs6-00057q-U8 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 03:56:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtjsD-000150-W9 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 03:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2024 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 70213-submit@debbugs.gnu.org id=B70213.17125630114075 (code B ref 70213); Mon, 08 Apr 2024 07:57:01 +0000 Original-Received: (at 70213) by debbugs.gnu.org; 8 Apr 2024 07:56:51 +0000 Original-Received: from localhost ([127.0.0.1]:45230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtjs2-00013e-8A for submit@debbugs.gnu.org; Mon, 08 Apr 2024 03:56:50 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:55451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtjrz-00012e-PS for 70213@debbugs.gnu.org; Mon, 08 Apr 2024 03:56:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1712562986; x=1713167786; i=stephen.berman@gmx.net; bh=+YTeWRQtUm0j4WrCrsrya0ZZp8mUpmRq5tNGcqTLito=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=C1BKsW5b4cjncMC1GB/r/sJQoafMnKLelBQhIkb+5CAkspM+WTXQAPwDo0czdGPw CFz6fFWsO57JcZs4OR82o4A+h6UxU0mDIwpzZJcZgWBGFc+ggVoUDZEL/xZDlxvpq Ee7oUNCjs9C17SiQ6Ui/SNkWKgkE9y4Itm+dOAyqwhP+mYEZH9K2kd6Y86kayzveE Qry2lwtJ3o4gJ/68Rf/LsPpq0pSK93wW7wjDNjkLyGti9peDcGaf1Kappk2eDxI6g d2HtgU0tRtSsMWmt4xPdrVqMJEBrlq/tZZIpLNfLWZMY/G1siXNmVWS5xmj/aibnA IEi+YMf9bRzp5RaKFw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.94.159]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M5wLT-1rqjj71PJb-007TRJ; Mon, 08 Apr 2024 09:56:26 +0200 In-Reply-To: <87o7ak3gfs.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 07 Apr 2024 16:11:07 -0700") X-Provags-ID: V03:K1:zdRi07tbPrjj9ChNWTqLw02wLfDlTYWt8zicocEMNUw3y0Snvnd FJJhSBamtDZr9IBvGL/tBA7HKIsuWIwrlxjRJrWnB4Y/nse1ZMsQrfnUqWRbcfRChn3qKpc X+sY05N5TwJwfqSc4DMdxZn6GHXmyNtYcUcgQg76YhdOirRy2xdKVhl4ncNc+FgkgRytgTm +z1pVjHDrxLOg2f8IWX0w== UI-OutboundReport: notjunk:1;M01:P0:/WrKwVoWOC4=;aNgUJw2fLw9BxxBfvM9LZ2tbkYF EcVGTJVta6ILnGPsf6qu60i2/nlAQFjGAquUoqY0p+Aae3W9cSPmX4mOtSVzH0t7OUvvx7oNG ow9hiUBGcGqM0jH+uQpk6NPiFqsHxKSV+sHMBjMbY+EGDDSjxzjiWfWWqHjCdD4I9mnrKkn/+ XepQB4GMP1RNZBrFBHNwr96Cy2itUR/V8m67MOthhz0bZTuU4+cLI0tgMRNeZh26fLtxQl/qy +s/eU1LIQZOWySO/vY1IlPkvSIMl61Ds6CpJy8fvFSBc+8OZwH/XJ4xc3hy2GV5rsgQeBVTqs bqIkaslZetc5tZmd5CzvrfiHjg6e/YNB8l0BcxU46Vg5nhLInDTqJcNVzjHuktsLU93iVZUak 8ck9XVWXveWwYacUAuK7xJjkv/veM+vj2LR+qgtu5ew/p2EkrVfL3mfFarYvhWE8n+kvKvPKw UdL1fUfs2jJEyHoU5CWxLu3eZzvYKhVwPqgbkn1PuTalSObzEz2VappO27cINWYspgNj+AIbg bx/sJALKCCCO4xrHE1GHC1bD9eePYS73RlCpViPWuI90a3OILE1J/doF+qxisHF67TNFfoH3R 6UfEFOBJPQTD7ged/GgMv3QzyBCdv920BDYMHSSB0XARCX2vqOTjvE7xHnZiB8LTaDdXKpd73 tBqcz7BFlfO3Z+EgBE5bumloELskoya+zPw+TUhDGsKjOzDfm6jzH0hjC/sSPZrv5jJ3RTu62 3o6Wxn5FZNohTayhd/wF08kgEV38I4F3QSzQFAcuq8s95RxZM6h3zAKdO6bvh4vWS7soxQ5R X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282917 Archived-At: On Sun, 07 Apr 2024 16:11:07 -0700 Joseph Turner wrote: > Stephen Berman writes: > >> On Sun, 07 Apr 2024 10:53:00 -0700 Joseph Turner >> wrote: >> >>> martin rudalics writes: >>> >>>>>> In emacs -Q on master after Jan 6 patch, eval this: >>>>> >>>>> Maybe Martin could help to solve this problem (Cc-ed). >>>>> >>>>>> (progn >>>>>> (setq fit-window-to-buffer-horizontally t) >>>>>> >>>>>> (setq display-buffer-alist >>>>>> '(((derived-mode . Info-mode) >>>>>> display-buffer-in-side-window >>>>>> (side . right) >>>>>> (window-width . fit-window-to-buffer)) >>>>>> ((derived-mode . messages-buffer-mode) >>>>>> display-buffer-in-side-window >>>>>> (side . right) >>>>>> (window-width . fit-window-to-buffer))))) >>>> >>>> At the time we call 'fit-window-to-buffer' the buffer is empty so we >>>> show only 'window-min-width' columns. Don't we have 'body-function' for >>>> that? >>> >>> Thanks for the review! We have the same understanding of the issue. >>> >>> What do you mean by 'body-function'? >>> >>>>>> I would expect the *info* window to fit to the buffer contents >>>>>> when it first appears. The patch I sent earlier fixes this. >>>> >>>> That patch is >>>> >>>> Display-buffer-after-ensuring-it-contains-text.patch >>> >>>> IIUC. It already explains the problem in its name and does look good to >>>> me. >>> >>> Thanks for the review! Stephen, Juri, Eli, WDYT? >> >> I agree that your patch is an improvement when >> fit-window-to-buffer-horizontally is set to t. However, as I noted >> upthread, the resulting width of the right-side window is too small, >> unlike when using the same setting of display-buffer-alist with >> fit-window-to-buffer-horizontally set to nil, with which the setting of >> display-buffer-alist works just as well without your patch. So even >> with your patch, there remains a problem. > > It turns out that it's necessary to set window-resize-pixelwise also, as > noted in (info "(elisp)Frame Layouts with Side Windows") . > > In emacs -Q with the patch, the following snippet should the width of > the largest line, which on my machine is 74, the width of this line: Yep, now I get that too (after widening the frame sufficiently, since the standard default of 80 columns (which I have) is too narrow to fit both windows with widths 6 and 74 plus the added scroll bar and fringes). So window-resize-pixelwise was the missing link, there's no problem after all and your patch is good to go, as far as I'm concerned. Thanks. Steve Berman > In Emacs, you can click mouse button 2 on a menu item or cross reference > > (progn > (setq fit-window-to-buffer-horizontally t) > (setq window-resize-pixelwise t) > > (setq display-buffer-alist > '(((derived-mode . Info-mode) > display-buffer-in-side-window > (side . right) > (window-width . fit-window-to-buffer)))) > > (info) > (window-width))