From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#70725: 29.3; dired-do-touch completion Date: Tue, 21 May 2024 13:04:21 +0000 Message-ID: <87msoj2u5m.fsf@posteo.net> References: <871q6kkn5o.fsf@librehacker.com> <87plu38pf6.fsf@posteo.net> <86fruzjudh.fsf@gnu.org> <87fruzwetu.fsf@posteo.net> <8634qwlrii.fsf@mail.linkov.net> <87v83r8pm3.fsf@posteo.net> <86msp38lqm.fsf@mail.linkov.net> <87r0ef8cr9.fsf@posteo.net> <87seyv6ulx.fsf@igel.home> <87msp386vn.fsf@posteo.net> <86zft1h8jt.fsf@mail.linkov.net> <86seyfecil.fsf@gnu.org> <87jzjrt95q.fsf@posteo.net> <86ttird6uf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36628"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thierry Volpiatto , christopher@librehacker.com, Eli Zaretskii , schwab@linux-m68k.org, 70725@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 21 15:03:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s9P9B-0009Am-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 May 2024 15:03:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9P8u-0003kd-Bo; Tue, 21 May 2024 09:03:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9P8r-0003g8-UG for bug-gnu-emacs@gnu.org; Tue, 21 May 2024 09:02:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9P8r-0007JB-KV for bug-gnu-emacs@gnu.org; Tue, 21 May 2024 09:02:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9P8w-0005Z8-H1 for bug-gnu-emacs@gnu.org; Tue, 21 May 2024 09:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 May 2024 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70725 X-GNU-PR-Package: emacs Original-Received: via spool by 70725-submit@debbugs.gnu.org id=B70725.171629654321381 (code B ref 70725); Tue, 21 May 2024 13:03:02 +0000 Original-Received: (at 70725) by debbugs.gnu.org; 21 May 2024 13:02:23 +0000 Original-Received: from localhost ([127.0.0.1]:49055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9P8J-0005Yn-8Y for submit@debbugs.gnu.org; Tue, 21 May 2024 09:02:23 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:37297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9P8E-0005Yb-RO for 70725@debbugs.gnu.org; Tue, 21 May 2024 09:02:22 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9C223240027 for <70725@debbugs.gnu.org>; Tue, 21 May 2024 15:02:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1716296527; bh=NLn4eUbHxvRs56XsYk9rJJ4zPqsoOvXaa41b+cd7fA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Autocrypt:OpenPGP:From; b=L7cHYqsOQhr6+S1/ncEXXW9WleQds0oDuhqsLPVNqL0l2GZlVXtCthnHfNFNMSX1h RLsVAX4y244qV0QoUjCKAHgJHycR9RmONQ86vzCtHQVX9lQyJOMZHRSPztzR5X6xb7 1sOhJeJOwR9lRD3RbMihVpjdJdFtMTkMXF626Y4SYYNTZCvfMw6vSvGpmfiJtkcyaW YMyfhwJ6/aaSzNwckeQl/UaFYqw9WJ12J6fn4RJUhFuUab3CCH5wdHWk3oPcewu1VU a7JK3Y+5O4SvkfRIsm94yT7yKCNdwSCjYoWHlwPLiHrhw9CF71ZElaPqA6Gv2i0r90 Bebfyv/KEFeUQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VkF2P0VCPz6txY; Tue, 21 May 2024 15:02:04 +0200 (CEST) In-Reply-To: <86ttird6uf.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 21 May 2024 09:20:08 +0300") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285533 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Juri Linkov writes: >>>> > However this doesn't explain why dired-do-touch uses a completing-re= ad >>>>=20 >>>> Indeed, this was an oversight. Here is the patch >>>> that replaces 'completing-read' with 'read-string': >>> >>> Thierry, is this solution okay with you? >> >> This fix one issue, > > Thanks, so I pushed the fix. Thanks. >> but default is still wrong IMHO: >> >> When pressing RET with an empty prompt the value is different than what >> is inserted in minibuffer with M-n. Why do we bother setting the >> timesamp at the exact time when pressing RET instead of when pressing >> "T", I mean user would consider the timestamp is set once "T" is >> pressed, with this the behavior would be consistent with RET and M-n and >> the code much simpler. > > There is no need to make the value used by RET and the value inserted by = M-n > consistent in 100% of cases. Sorry but I disagree on this. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmZMm9UTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk50lC/0eLsgqxvAuFqNuH7GBbDoHoLBucN9H XlmNjVBxDRHo6rk76xYQebkzcmeIA3SjuGIwskqcMT6s/NeesJyu54R6dS2b0KPM AWIF0KQFYyb/vE6TI93KvAaeE4C7Q6hlu2DjTm+01+DfS+RNSFXBhzNBPR1NRneO cPy++gydOtdap0Hwt+S9joDuGT9URxY2/zUz94SmXjBNAlXrrxLE8ny36C3r0uU9 Yqf4QFqb5iSfOqDHJwPXp7uc4evf/uvFNjAEMt7aSfg5PPoBKuYu3JE9HdrOrw/J etBwNcriSigPoYDyTUZRgzN8xvZuZvrJg2ILvCjDcCTeM8vPGMTu2lFMTgQ6YKvD jX1Vf2JISo6pvnlczSOF5LDOeFU3l6ef/ZPi0d6AuowBtHR+8J/QNT5ukcJsaohU tCy1wQdzEBPkgrWXMRMOWWKxQUdPUqPfhC9HWIKtS/vKTiES8iFESx2IX3KPdxn6 4vxObJs/ftSFkWOJ2JI/DnRQX8c8IHPhCFk= =7sBV -----END PGP SIGNATURE----- --=-=-=--