From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Wed, 22 May 2024 16:16:44 +0000 Message-ID: <87msohhleb.fsf@posteo.net> References: <07df5e8408054bcae5968066b0cebf34@finder.org> <86fry0vihy.fsf@gnu.org> <86fry08di9.fsf@mail.linkov.net> <86cyrg5hc0.fsf@mail.linkov.net> <865xvyoupe.fsf@mail.linkov.net> <86frur76uj.fsf@gnu.org> <791456a05f91c68549027ea1ea33eaf6@finder.org> <84a5dcf2833598c5b588ab6dd4f5c762@finder.org> <86le4fxa41.fsf@mail.linkov.net> <86frufe9i9.fsf@gnu.org> <8cfec392c3f9259b7499ebd4f605bc25@finder.org> <878r05uao0.fsf@posteo.net> <878r04n8mj.fsf@posteo.net> <2aa288529bd9d73662452627a9fc856c@finder.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15333"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 68765@debbugs.gnu.org, monnier@iro.umontreal.ca, juri@linkov.net To: Jared Finder Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 22 18:18:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s9ofX-0003ky-33 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 May 2024 18:18:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9of7-0007eU-Ub; Wed, 22 May 2024 12:17:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9of6-0007cm-Rl for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 12:17:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9of6-0006gG-JK for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 12:17:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9ofC-0004s4-30 for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 12:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2024 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68765 X-GNU-PR-Package: emacs Original-Received: via spool by 68765-submit@debbugs.gnu.org id=B68765.171639462418707 (code B ref 68765); Wed, 22 May 2024 16:18:02 +0000 Original-Received: (at 68765) by debbugs.gnu.org; 22 May 2024 16:17:04 +0000 Original-Received: from localhost ([127.0.0.1]:56890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9oeG-0004rf-Cz for submit@debbugs.gnu.org; Wed, 22 May 2024 12:17:04 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:34001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9oeB-0004r7-D6 for 68765@debbugs.gnu.org; Wed, 22 May 2024 12:17:02 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 83F70240105 for <68765@debbugs.gnu.org>; Wed, 22 May 2024 18:16:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1716394607; bh=a3H5BpBE4FGtK1xdT0h9j5cXVJad1lc3FI60+UghaX8=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=XjyChKY80/WlN+7kQ1HDQuK3pz8Ur82oGsJ5QGVdmkIut0u7++n+DqAwSWhomOxxx EU3RiCW56iSozp0cDv+0njRV40QftOD5oa6KaAkNQjmoYbRKWme/2xWfK0quBZ21PY iHiYHO23BJ0iyZJzLcNwQwvaQsQliTaBkcwsH2XMy+1UYLlEbkMV2Tjzt/21NKbbtN CqbuMKROknMa7DZZNd2cfAh7LIkFtG2eU8fuclwCbHoGQYOYpoTMzk3/MvCgDcyHgV w8EtvzCG0Caj+/RZKrC0V5+2VwZpnYt5d5bK6WJFlqHg+sKmspcyg5nWgAF7GE5sUA 1vjDzqqO3HeqA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VkxJY5NNWz6txg; Wed, 22 May 2024 18:16:45 +0200 (CEST) In-Reply-To: <2aa288529bd9d73662452627a9fc856c@finder.org> (Jared Finder's message of "Mon, 20 May 2024 21:18:12 -0700") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285638 Archived-At: Jared Finder writes: > On 2024-05-20 02:19, Philip Kaludercic wrote: >> Jared Finder writes: >>> On 2024-05-19 07:41, Philip Kaludercic wrote: >>>> Jared Finder writes: >>>>> Is there anything else that needs to be done to get this package on >>>>> ELPA? I'd like to use this package on older Emacsen as well. >>>> It just has to be added to ELPA, but that is a one-line patch to >>>> elpa.git. Here is the tarball I generated locally: >>>> Can you confirm that it looks alright and works on older systems >>>> (use >>>> M-x package-install-file)? >>> Confirmed, just tested it! It worked fine on Emacs 29.1 the >>> package's >>> minimum supported version. >> Regarding that point, I didn't follow the thread in detail, but why >> is >> 29.1 the minimum version? package-lint indicates that it should be >> compatible with 27.1, but it might be missing something. > > Only because that was the version I used regularly when I started > writing this. I plan to extend support to earlier Emacs versions in a > future version of this package. I'm just waiting on squaring away > this first step before working on any updates. :) If you need some special new functionality, you can make use of the Compat package, which as of Emacs 30 has a bundled shim making it easier to use it in core packages. > On 2024-05-19 23:39, Philip Kaludercic wrote: >> Jared Finder writes: >>> On 2024-05-19 07:41, Philip Kaludercic wrote: >>>> Where will the package be documented? Should anything be added to >>>> the >>>> ELPA package? >>> I was hoping documentation could just stay in the core Emacs >>> manual. >>> window-tool-bar is a core package and I was hoping to document it next >>> to existing documentation on the existing (frame) tool bar. Does that >>> seem reasonable? >> Sure, in that case the core should just link to the specific Info >> node. >> As soon as the manual is updated on the gnu.org website I'd also add a >> HTTP link for people previewing the package to be able to see as well. > > I'm not quite sure what change you're looking for here. Let's assume > I've added an info node "(emacs)Window Tool Bar" that is also a > function index for global-window-tool-bar-mode, where do you think I > should mention this link? In the commentary section of the package. >> Otherwise, I'll add the package to ELPA now, and I hope it will appear >> on the site in a few hours. > > Yup, I see it! Thanks! > > -- MJF > -- Philip Kaludercic on peregrine