From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jules Tamagnan Newsgroups: gmane.emacs.bugs Subject: bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands Date: Sun, 23 Jun 2024 17:45:05 -0700 Message-ID: <87msnb5fu6.fsf@gmail.com> References: <87a5jd8hqh.fsf@gmail.com> <877ceg9546.fsf@gmail.com> <874j9k8wpo.fsf@gmail.com> <87r0cn5n2s.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6941"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71716@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 24 02:47:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLXrq-0001gV-Ck for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jun 2024 02:47:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLXrQ-0003L6-Ih; Sun, 23 Jun 2024 20:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLXrK-0003Kd-5A for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 20:47:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLXrJ-0005xJ-Ow for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 20:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLXrK-0003Vv-FE for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 20:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jules Tamagnan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71716-submit@debbugs.gnu.org id=B71716.171918997713435 (code B ref 71716); Mon, 24 Jun 2024 00:47:02 +0000 Original-Received: (at 71716) by debbugs.gnu.org; 24 Jun 2024 00:46:17 +0000 Original-Received: from localhost ([127.0.0.1]:58938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLXqb-0003Ud-8d for submit@debbugs.gnu.org; Sun, 23 Jun 2024 20:46:17 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:58391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLXqY-0003U6-Qy for 71716@debbugs.gnu.org; Sun, 23 Jun 2024 20:46:15 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-709423bc2e5so2902268a12.0 for <71716@debbugs.gnu.org>; Sun, 23 Jun 2024 17:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719189908; x=1719794708; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KCid06Jts5pt9QkhuwZikWRU9RSnc7q2Z/zWqHMOAHo=; b=FzjoRrNm+NkKpfl/EJWsTHfOez+8fYr+WMVIU5pF9NqhOlk+I/LFc1HRzL19eE1vnw RbaGEhBHjzOGpZ2BRU+90yJTKz3RmxNgZz1t9idEr1WKw8moUoqNLosYeAUrg6EqXiQ1 NrZq928+nPyymlRp0AWpUerZAR9d82TJX6t6oBIH21uzxb3V89wvP4MSrODoyszRAaXp ELz3ABPO6blfw1Xl+XBQu7PEsOO8EN2+qGaEFBj9l2uFVkqj1Vf+sfo8Bv5s7VoUJfFL vtE4L172TgTGeG4tme61CKGzDZx6fLSU4n4VAGZYUjZTqoGzzSOaIDmMLTgDXFy9SKvk nCfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719189908; x=1719794708; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCid06Jts5pt9QkhuwZikWRU9RSnc7q2Z/zWqHMOAHo=; b=f9OK+x089LnK6twXyrHaoZcaEDnAIVvTRjSFUdA612V/RgI+LRI69gZJypOZ8smEvC JKhyAAM+LGSGrR/92KTQCV5lYWet6VvTjyl0M5GbgHmZ2NXTcCviZ3lWFb49fJCSfRBv GHDPu94IUQJy9OHDTeVUyqO0mNd2uKV1JfCGab5iERFvWSl1Fex0npMkfIJtjIrKxV2C noho3t8YtuaM6rHBM02AB03v46An12v5Y0nl1PKQXB5+sdOsWNu+0zFCgo1P+BJHxlG3 e6FVslSY7fifNa1LLk/QddNFpqCjjIdl4SUPSUdnqiFW0cm8qfkNw0Sdwc4DrDkvv0IV sijA== X-Gm-Message-State: AOJu0YxqCpoF1hzsADq3qtCP6m0ichitQZt7GjOzLYGc1vT3JVS8xIsK 0t8oElnDSDc2qR9eau7FLstpJ6aHaWKSvbiLdyIJzogw6RzMwe8V0zKHKg== X-Google-Smtp-Source: AGHT+IGb99MO37mGIwxcQ7apap5EKIoJpSO4K//2Q9cxXP/rOZK1G9LKkR+rJSMx9yJPVa+PjHTLEw== X-Received: by 2002:a05:6a20:6720:b0:1bd:be0:7fbe with SMTP id adf61e73a8af0-1bd0be0820dmr730343637.12.1719189907760; Sun, 23 Jun 2024 17:45:07 -0700 (PDT) Original-Received: from jat-framework (c-73-189-85-43.hsd1.ca.comcast.net. [73.189.85.43]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c819a8c846sm5358115a91.26.2024.06.23.17.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 17:45:07 -0700 (PDT) In-Reply-To: <87r0cn5n2s.fsf@gmail.com> (Jules Tamagnan's message of "Sun, 23 Jun 2024 15:08:43 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287812 Archived-At: Jules Tamagnan writes: > The second patch > `completion-preview-partial-insertion-with-region-delete.patch` is the > version of the change that uses in-buffer deletion. There's not much to > say here, it seems quite a bit more robust. I guess one thing to mention is that the use of `full-end` and `new-end` could be replaced by `(+ (length aft) end)` and `(point)` respectively which I had originally avoided to reduce calculations but might better fit the style of the code. Another idea would be to add a test proving that `(completion-preview--insert-partial #'end-of-buffer)` will never place the point too far. I have tested this on my own but haven't written a test for it. There are surely other style comments too, maybe the use of whitespace within a function is considered bad form? As always open to any and all feedback. Thanks in advance. Best, Jules