From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using Date: Sun, 28 Jul 2024 12:04:28 +0000 Message-ID: <87msm1pvsj.fsf@posteo.net> References: <87ikync1zh.fsf@posteo.net> <86frtrk2ec.fsf@gnu.org> <8734pqbneq.fsf@posteo.net> <871q3xklgv.fsf@jeremybryant.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10096"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Kangas , 71374-done@debbugs.gnu.org To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 28 14:05:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sY2e8-0002UA-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jul 2024 14:05:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sY2dw-00018a-N4; Sun, 28 Jul 2024 08:04:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sY2dv-00017z-E8 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 08:04:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sY2dv-00042N-4n for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 08:04:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=JzMk48F7HK2BZznuC3yQTMEDkDXfIFfopQ0k5JnOR5M=; b=PFSw9J63bwdRRH/yxIq8DQmVGqWoETl6+SNhUDsz65oGGIpNKhETAcc0HafFuEQ5X8yH5brhi1HkwHtX67gNeNwytzmtJZatEmeQWzzVIrfeEvN1EF/vDstIV6LzGpxIrMRfTj2xRA3SHGQY8LQto2bb2NzWWro7pmUR7gzkOxP0WbzIl1sRKKFGvjUYKm9VlAhqblHnRKYm7ZltSrqXcDEUve1/czdgSeatLKmYlNethqdEUuY/V1Fig0uBNElgQJqcDnEW6FDqkEUw3hWEU3ACIhvSoCHOdmlB5q80+jghVqHAdMTZJOPCSAG93JYzLBX9EnDbxlC+l8nm6v5F9A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sY2e6-0006gq-DD for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 08:05:02 -0400 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2024 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71374 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 71374@debbugs.gnu.org, philipk@posteo.net, philipk@posteo.net Original-Received: via spool by 71374-done@debbugs.gnu.org id=D71374.172216828925690 (code D ref 71374); Sun, 28 Jul 2024 12:05:02 +0000 Original-Received: (at 71374-done) by debbugs.gnu.org; 28 Jul 2024 12:04:49 +0000 Original-Received: from localhost ([127.0.0.1]:42765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY2dt-0006gG-58 for submit@debbugs.gnu.org; Sun, 28 Jul 2024 08:04:49 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:45759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY2dr-0006g2-23 for 71374-done@debbugs.gnu.org; Sun, 28 Jul 2024 08:04:47 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1C350240028 for <71374-done@debbugs.gnu.org>; Sun, 28 Jul 2024 14:04:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1722168269; bh=5mK7Y2bs911Y6RLGaBZMAlLHdb989vEaMN+MbC5dgc0=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=eZCZY4YSqrmjehWj6kwkV28M2Z4oThCrFZIZG78fWNuS11LO9XNRVencz9nBK94Gm d1dU0T8XNP+wGDjLHkN1BzEr3NwhIUmjYBXoCC6UD3T6uAKVkXfUAuF+4Kc9UjK3lW FJCliXHqDD5HFFPixBSVvinGye2+Zxfmy3ekZMnY/b0OAxySy3rUecSis26ts7hKdC 6ZV9CveRcTKUHPoYVi5HXvZGrA5zF0DzMbGBI/oiPrkxcOZCHr40wEzGkNIknbG1aY eupn+Jo6iVqpdXCJHuD8veZpWkzyD2Gi0Cr58l60FKm2y9g47XlcB0pSMG8DhVPUPm vn5/rWxXM/NFw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WX0XX40Drz6tm8; Sun, 28 Jul 2024 14:04:28 +0200 (CEST) In-Reply-To: <871q3xklgv.fsf@jeremybryant.net> (Jeremy Bryant's message of "Sat, 13 Jul 2024 22:53:20 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289464 Archived-At: Jeremy Bryant writes: > Stefan Kangas writes: > >> Philip Kaludercic writes: >> >>> Eli Zaretskii writes: >>> >>>>> From: Philip Kaludercic >>>>> Date: Wed, 05 Jun 2024 06:55:46 +0000 >>>>> >>>>> The main issue with this patch is that it drops the syntax highlighting >>>>> in the *string edit* buffer, but we could fix that in a second patch by >>>>> adding support to specify a major mode to inherit from when editing a >>>>> string. >>>> >>>> Thanks. This is basically a cleanup, yes? IOW, there's nothing wrong >>>> with the current implementation, right? If so, I'd prefer to wait >>>> with this until after the emacs-30 branch is cut. >>> >>> Right, it just seemed like the kind of thing where it would be natural >>> to demonstrate string-edit. >> >> Feel free to install on master now, thanks. > > Philip, has this been installed on master? Can the bug be closed? I hadn't pushed the change, have done so now. Closing the report. Thanks for the reminder. -- Philip Kaludercic on peregrine