bug#71946: 30.0.50; [PATCH] Fix bibtex validation for non-file buffers

[Roland Winkler <winkler@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On Sat, Jul 13 2024, Eli Zaretskii wrote:
> Roland, is this patch okay with you, and if so, is it safe enough to
> be installed on the emacs-30 release branch?

(For the records: resending this message with bug#71946 unarchived
so that this message goes into the bug tracker.)

I am sorry, due to a silly mistake on my side, I saw your email only
now.  I saw that you already installed the patch in the emacs-30 relase
branch.

I tested the patch, it works for me, and I believe the already installed
patch should be safe in 99.9% of all scenarios I can think of.  However
I'd suggest two minor modifications, see the patch attached below:

- rename FILE-P to IS-FILE to be consistent with the emacs lisp coding
  conventions.

- Set compilation-parse-errors-filename-function only if we do not want
  its default value.

Shall I install this patch in the emacs-30 release branch or in master?

Roland



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bibtex.patch --]
[-- Type: text/x-diff, Size: 1205 bytes --]

--- bibtex.el~	2024-09-22 13:41:29.890443820 -0500
+++ bibtex.el	2024-09-22 14:23:17.726487214 -0500
@@ -4638,16 +4638,17 @@
             (bibtex-progress-message 'done)))))
 
     (if error-list
-        (let* ((file-p (buffer-file-name))
-               (file (if file-p (file-name-nondirectory file-p) (buffer-name)))
+        (let* ((is-file (buffer-file-name))
+               (file (if is-file (file-name-nondirectory is-file) (buffer-name)))
                (dir default-directory)
                (err-buf "*BibTeX validation errors*"))
           (setq error-list (sort error-list #'car-less-than-car))
           (with-current-buffer (get-buffer-create err-buf)
             (setq default-directory dir)
             (unless (eq major-mode 'compilation-mode) (compilation-mode))
-            (setq-local compilation-parse-errors-filename-function
-                        (if file-p #'identity #'get-buffer))
+            (unless is-file
+              (setq-local compilation-parse-errors-filename-function
+                          #'get-buffer))
             (let ((inhibit-read-only t))
               (delete-region (point-min) (point-max))
               (insert (substitute-command-keys