unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Ulrich Mueller <ulm@gentoo.org>, 73524@debbugs.gnu.org
Subject: bug#73524: 29.4; bug-reference-mode matches regexp case-insensitively
Date: Sat, 28 Sep 2024 20:46:54 +0200	[thread overview]
Message-ID: <87msjrhazl.fsf@gnu.org> (raw)
In-Reply-To: <86ed5364y9.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Sep 2024 20:52:46 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> >> If we want to always match case-insensitively in bug-reference,
>> >> then we could bind case-fold-search to t in bug-reference-fontify,
>> >> no?
>> 
>> > Sure, if we are convinced that there's really no scenario where bug
>> > references are case-sensitive.  I would think this is very uncommon
>> > but not impossible.
>> 
>> What about the other examples in the default, i.e. "RFE" and "PR"?
>> I'm not completely convinced that matching their lower-case form
>> would be a good thing.
>
> I see in binutils-gdb repository most "PR" are in upper-case, but
> all.
> [...]
> Not sure about RFE (where is that used?)

Request for enhancement?

Anyway, I also think that bug#123 is probably better matched
case-insensitively while RFC 2616 or CVE-2024-5742 are commonly
all-caps.  But in the end it's a user's choice if she prefers to have a
false positive or a false negative when something is or just looks like
a bug reference.  I'd rather have a false positive but that's just me.

So I'd vote for a defcustom bug-reference-case-fold-search defaulting to
t that users can set according to their preference or conventions.

And I wouldn't read too much into the default value of
bug-reference-bug-regexp.  It's just a value that works for us (Emacs or
other GNU projects using debbugs).

Bye,
  Tassilo





      reply	other threads:[~2024-09-28 18:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-28  6:24 bug#73524: 29.4; bug-reference-mode matches regexp case-insensitively Ulrich Mueller
2024-09-28  8:39 ` Eli Zaretskii
2024-09-28  8:48   ` Ulrich Mueller
2024-09-28 16:24     ` Tassilo Horn
2024-09-28 16:30       ` Eli Zaretskii
2024-09-28 17:10         ` Tassilo Horn
2024-09-28 17:25           ` Ulrich Mueller
2024-09-28 17:52             ` Eli Zaretskii
2024-09-28 18:46               ` Tassilo Horn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msjrhazl.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=73524@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).