From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#74193: 30.0.92; noquery argument ignored when creating a TLS connection Date: Mon, 04 Nov 2024 17:38:47 +0100 Message-ID: <87msifneco.fsf@gmail.com> References: <87cyjc6v8n.fsf@ars3.mail-host-address-is-not-set> <86a5efw6ku.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26732"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74193@debbugs.gnu.org, Augusto Stoffel To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 04 17:40:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t807p-0006kg-KF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Nov 2024 17:40:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t807a-0001WU-7O; Mon, 04 Nov 2024 11:40:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t807X-0001P4-1x for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2024 11:40:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t807W-0003Q8-OC for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2024 11:40:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=wHos6yHbvjq8UZ4jKpRvoabpRWWjPVjkXM6o20mVfrY=; b=TT2ubNGp7YjiS7b3WLxwvZCVarQJ+eUgVmsSw8xDUMUdTUfTyhPcJQBFVqdTQh3crf4IgNGkHtb2tJwfjDLVofZpTejrd/4YYMYSW2r51VhKC15VmjEYdr/pubNfLELRhmZRQnlgUj3O64ZEeTusUp9EXte3bw9ekFS09Kcya4Q3F9qQOF5VsDqK49TwqoP343qJ1wVmwi0BYoNPDxTu5NcP8xghyQrf+F4PvmEzV25QH+/7Et6VDUyOcwML21j6wEZLMfUZcC89afWXm48jrcAgg+pcPEacEDbPSgp1wiquLvPbAVQq+qNekwvHtLEN1RQy9a8Uxen+SnCE0TCqIg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t807W-0000v5-Ih for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2024 11:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Nov 2024 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74193 X-GNU-PR-Package: emacs Original-Received: via spool by 74193-submit@debbugs.gnu.org id=B74193.17307383973509 (code B ref 74193); Mon, 04 Nov 2024 16:40:02 +0000 Original-Received: (at 74193) by debbugs.gnu.org; 4 Nov 2024 16:39:57 +0000 Original-Received: from localhost ([127.0.0.1]:40997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t807Q-0000uX-Vf for submit@debbugs.gnu.org; Mon, 04 Nov 2024 11:39:57 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:61445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t807O-0000uJ-H6 for 74193@debbugs.gnu.org; Mon, 04 Nov 2024 11:39:55 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4316e9f4a40so36351505e9.2 for <74193@debbugs.gnu.org>; Mon, 04 Nov 2024 08:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730738328; x=1731343128; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=wHos6yHbvjq8UZ4jKpRvoabpRWWjPVjkXM6o20mVfrY=; b=i+7lDwuPNMqSJuF0dZZAaBgbz2+bbRko3agGsr4VczioRO4ggXYe0+E4BT1fdU0MWI AXPmCxEK72vfrFbeXOMvInW4zSIJwwwhaRXKpOp+oEEcPETXny3Llo6N1RiXpkISxXFp qGNH6nq/2fDrXOICySzFujVinkXqw0HmpyQ6Oc7XkR4YBg3wMweePrmVu373z6uikiZr Krcx9GCH0dI5FcOdn6TXuUTPUQNURYXoEwa0dc0wWDUK4djZd35s+GU039oqAQbMUBD+ 55fA6wLHmnQFD4sDtuukM00no+B1DpxzCQY7bDHuy56KQFYygZxCWtx+uKolH/OJZsDt SKdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730738328; x=1731343128; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wHos6yHbvjq8UZ4jKpRvoabpRWWjPVjkXM6o20mVfrY=; b=I4KxQdmsF5Nhoe9PdzXJzqTAsQHF048d/409Q3AEAoV9K3lf/LE8pjRpzAdTSyn4ap zxIw8dpPRf/qRvHZo1bbIejTAecJmx8DB68gs5oKsAaIVakZTCk+reIQzMbWzPMkAATF yHZ3qHjSdBqGUBP7BgierMgm4ECB+202/hvm1p6itpvU62aVJj9Gx3txrHgCFlpkqBSn MkmlS2mRiEWa9TU1DpUtRnkGY7zA1qrSSanfYE7FbYWbjny87jyHWERPmWmFHOnS2Js7 HGrsF/xJfHzM/MJU7U+JpH2nMccupSKw81UFB5TP7Edd+C+Cb7APUBJCGcijXAgNFjjd K0nw== X-Forwarded-Encrypted: i=1; AJvYcCUwZ5T/YfsosvTSRy1lZ5WxhEYwRoSsYHawK+x1311lHBh27YjU2Hypni9MokzfITvfQRQpcQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz7erQr/aY1onfYW3Yf97O9uA/KxVXUDdFqwne1hOjoo4tbN7bd QPIxeHQbXx9wnoY95R9KEuDsZOkTV9XMkArAtZkgbAxtuO2ZSVZysp1uRA== X-Google-Smtp-Source: AGHT+IFJW6SlE73gm5kV7nLEYqbzNp8w4p/0LzX8jUws8eTseu9Z08WW9PARxaqB2j8I9dr94yDQLA== X-Received: by 2002:a05:600c:4f15:b0:430:5654:45d0 with SMTP id 5b1f17b1804b1-4319acb104dmr294989815e9.14.1730738328489; Mon, 04 Nov 2024 08:38:48 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb51:e0ad:8e3b:a99f:8c4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c116ac7dsm13629497f8f.105.2024.11.04.08.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 08:38:47 -0800 (PST) In-Reply-To: <86a5efw6ku.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 04 Nov 2024 14:01:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294867 Archived-At: >>>>> On Mon, 04 Nov 2024 14:01:53 +0200, Eli Zaretskii said: >> From: Augusto Stoffel >> Cc: Augusto Stoffel , 74193@debbugs.gnu.org >> Date: Sun, 03 Nov 2024 19:13:44 +0100 >>=20 >> On Sun, 3 Nov 2024 at 19:44, Eli Zaretskii wrote: >>=20 >> > AFAICT, open-gnutls-stream doesn't support :noquery, so Emacs >> > basically ignores :noquery in this case and starts a network proce= ss >> > with query-on-exit flag set. >>=20 >> Indeed, the fix is trivial: >>=20 >>=20 >> >From 01d73dea9243d2b57b6ed2bd0fa37e0935ef7a74 Mon Sep 17 00:00:00 2= 001 >> From: Augusto Stoffel >> Date: Sun, 3 Nov 2024 19:11:54 +0100 >> Subject: [PATCH] * lisp/net/gnutls.el (open-gnutls-stream): Use :noq= uery >> option >>=20 >> --- >> lisp/net/gnutls.el | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/lisp/net/gnutls.el b/lisp/net/gnutls.el >> index b5fb4d47d57..e8614bfc6d3 100644 >> --- a/lisp/net/gnutls.el >> +++ b/lisp/net/gnutls.el >> @@ -200,6 +200,7 @@ open-gnutls-stream >> (process (open-network-stream >> name buffer host service >> :nowait nowait >> + :noquery (plist-get parameters :noquery) >> :tls-parameters >> (and nowait >> (cons 'gnutls-x509pki Eli> Thanks. Eli> Robert, do you know if GnuTLS, as we use it in Emacs, supports thi= s on Eli> all platforms? With both :nowait and non-:nowait? More generally= , I Eli> wonder why we don't pass all the parameters to open-network-stream? I don=CA=BCt know if it=CA=BCs supported everywhere, I suspect the interact= ions with :nowait could get interesting. As far as I remember, `open-gnutls-stream' is supposed to be a 'simple' wrapper, which is why it doesn=CA=BCt support all the keywords. Eli> In any case, the doc string should be fixed to mention :noquery. Which doc string? `open-gnutls-stream', after this patch? Robert --=20