bug#74193: 30.0.92; noquery argument ignored when creating a TLS connection

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Mon, 04 Nov 2024 14:01:53 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Augusto Stoffel <arstoffel@gmail.com>
    >> Cc: Augusto Stoffel <arstoffel@gmail.com>,  74193@debbugs.gnu.org
    >> Date: Sun, 03 Nov 2024 19:13:44 +0100
    >> 
    >> On Sun,  3 Nov 2024 at 19:44, Eli Zaretskii wrote:
    >> 
    >> > AFAICT, open-gnutls-stream doesn't support :noquery, so Emacs
    >> > basically ignores :noquery in this case and starts a network process
    >> > with query-on-exit flag set.
    >> 
    >> Indeed, the fix is trivial:
    >> 
    >> 
    >> >From 01d73dea9243d2b57b6ed2bd0fa37e0935ef7a74 Mon Sep 17 00:00:00 2001
    >> From: Augusto Stoffel <arstoffel@gmail.com>
    >> Date: Sun, 3 Nov 2024 19:11:54 +0100
    >> Subject: [PATCH] * lisp/net/gnutls.el (open-gnutls-stream): Use :noquery
    >> option
    >> 
    >> ---
    >> lisp/net/gnutls.el | 1 +
    >> 1 file changed, 1 insertion(+)
    >> 
    >> diff --git a/lisp/net/gnutls.el b/lisp/net/gnutls.el
    >> index b5fb4d47d57..e8614bfc6d3 100644
    >> --- a/lisp/net/gnutls.el
    >> +++ b/lisp/net/gnutls.el
    >> @@ -200,6 +200,7 @@ open-gnutls-stream
    >> (process (open-network-stream
    >> name buffer host service
    >> :nowait nowait
    >> +                   :noquery (plist-get parameters :noquery)
    >> :tls-parameters
    >> (and nowait
    >> (cons 'gnutls-x509pki

    Eli> Thanks.

    Eli> Robert, do you know if GnuTLS, as we use it in Emacs, supports this on
    Eli> all platforms?  With both :nowait and non-:nowait?  More generally, I
    Eli> wonder why we don't pass all the parameters to open-network-stream?

I donʼt know if itʼs supported everywhere, I suspect the interactions
with :nowait could get interesting. As far as I remember,
`open-gnutls-stream' is supposed to be a 'simple' wrapper, which is
why it doesnʼt support all the keywords.

    Eli> In any case, the doc string should be fixed to mention :noquery.

Which doc string? `open-gnutls-stream', after this patch?

Robert
--