From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Date: Tue, 26 Nov 2024 21:56:49 +0000 Message-ID: <87mshl7j6m.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19151"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73827@debbugs.gnu.org To: Alex Bochannek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 26 22:57:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tG3Yn-0004pX-Ry for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Nov 2024 22:57:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tG3YS-0003kZ-H9; Tue, 26 Nov 2024 16:57:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG3YN-0003k6-CR for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 16:57:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tG3YM-0007B5-HD for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 16:57:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=vzeTcEh9AUGA9HSdACqqoIA1Y2j1oFTje6y7NRp9zOo=; b=q8n5a25BRRAtl2R+/WotBjfl1eBkVOp+tYE9K3eX1G+Qh+aufWWqtE+iUkDqz05v4fKhX6r9CTuKl662FzQK6UB4uleXMdxHta8wEuGBgrJRZQ+HuEt0iZddEY3ZPcUE+HR3KmUAih4MH4m4jyJ06b3ro6DQvxVqhNkjS7m5IWyjTyII4z4WVRJt7Y/r+KAXEN97MrVCCFT5TEFyegLZQPAfXkfkdvYni1209druHSgSPT2lAGmz5W3nQjCMa9NhpUzxV+V/jUcwXbiV7vfLxNHBq6xpumdmKLMR5fTSaXpsvX+YlmKpb8VX8LacuwiOXH4uDSmM/Q0h1xsQsQ47AQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tG3YM-0003Cb-5x for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 16:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2024 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73827-submit@debbugs.gnu.org id=B73827.173265821912298 (code B ref 73827); Tue, 26 Nov 2024 21:57:02 +0000 Original-Received: (at 73827) by debbugs.gnu.org; 26 Nov 2024 21:56:59 +0000 Original-Received: from localhost ([127.0.0.1]:54434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG3YJ-0003CI-8j for submit@debbugs.gnu.org; Tue, 26 Nov 2024 16:56:59 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:47553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG3YH-0003C3-MS for 73827@debbugs.gnu.org; Tue, 26 Nov 2024 16:56:58 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3A402240103 for <73827@debbugs.gnu.org>; Tue, 26 Nov 2024 22:56:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732658211; bh=w/e0qxg9VcteuJ/kH2wWj79Lp1RJxJVN0C+z64yAGEI=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=nLVash65LQH1wGLcWMT9t60xUcM4hgfE8otJS34DWhq7HtDP+ZYgkf8cyPHdAb4kU ePpwtnjDkBZ4Ud3zd09vQcEpg2b0GxPJLucoaL4rfraM4qKtZMGM8DVhb1OerSqy6q OQJxyG2uxtdTVEOb7lJxkqQA5axIhBGxxriR44YLNb/0f5gqXs+mncamOooEU96pdR t1ic6AwfkvK6IkbqYhyMOjLQcUnxYfy45dKJh2K8Xq3pDm65u1wIRK/0Fl3HDcf/DS Zx2c+6kYgbaJMoKQTu3t+yPgRC47A3pj1cJBPwKlkLjE5sTbGqEREB4VaDmEJMQzrA NX4hkdGzu9Pbg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XybyB3BPyz6tw3; Tue, 26 Nov 2024 22:56:49 +0100 (CET) In-Reply-To: (Alex Bochannek's message of "Tue, 15 Oct 2024 16:14:54 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296002 Archived-At: Alex Bochannek writes: > Hello! > > I have not submitted patches against an ELPA package before, so I hope > this format is OK. I tried to follow the instruction on pulling ELPA > from Git, but the make step failed for me. > > The register-list mode throws an error on start-up when there are > unknown register types in the register-alist. This can happen with > window configurations and saved session state after a restart. The > reason for this is a simple line flip in the register-list-get-type > function. > > --- /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el.~1~ 2023-01-10 19:36:23 > +++ /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el 2024-10-15 15:49:37 > @@ -483,8 +483,8 @@ > (t "error")) > (cond ((window-configuration-p (car key)) "W") > ((frame-configuration-p (car key)) "F") > - ((stringp (car key)) "R") > ((string= "Unprintable entity" (car key)) "?") The change confuses me, are we sure that (car key) must be a string at this point? If not, should be prefer `equal' over `string='? > + ((stringp (car key)) "R") > (t "error")))) > > ;;; Edit key/value of the register > > > Apologies again for the format of this submission. If someone could > point me at instructions for how to make your life easier next time, I'd > appreciate it. You can try out M-x package-vc-install register-list RET that should give you a checkout. You can then make your changes as usual and then prepare a patch using vc-prepare-patch or git-format-patch(1). > Thanks!