From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Dan Jacobson Newsgroups: gmane.emacs.bugs Subject: Re: Makefile mode comment color didn't notice backslash continuation Date: 04 Feb 2003 09:00:32 +0800 Sender: bug-gnu-emacs-bounces+gnu-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: <87lm0woo5r.fsf@jidanni.org> References: Reply-To: Dan Jacobson NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1044327481 17001 80.91.224.249 (4 Feb 2003 02:58:01 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 4 Feb 2003 02:58:01 +0000 (UTC) Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18ftHb-0004Q1-00 for ; Tue, 04 Feb 2003 03:57:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ftJD-0006uZ-07 for gnu-bug-gnu-emacs@m.gmane.org; Mon, 03 Feb 2003 21:59:39 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18ftJ4-0006e0-00 for bug-gnu-emacs@gnu.org; Mon, 03 Feb 2003 21:59:30 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18ftIs-0006N9-00 for bug-gnu-emacs@gnu.org; Mon, 03 Feb 2003 21:59:19 -0500 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ftIf-0006DG-00 for bug-gnu-emacs@gnu.org; Mon, 03 Feb 2003 21:59:06 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18ftGk-0004Nx-00 for ; Tue, 04 Feb 2003 03:57:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: bug-gnu-emacs@gnu.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18ftGi-0004NS-00 for ; Tue, 04 Feb 2003 03:57:04 +0100 Original-Lines: 32 Original-X-Complaints-To: usenet@main.gmane.org User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: bug-gnu-emacs-bounces+gnu-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:4383 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:4383 P> Personally I believe this is wrong as well, but suggest a different P> solution: none of this text should be colorized as a comment. hmm, indeed, this is Makefile mode, not shell-script mode. On the other hand, one could say that me making a fuss about this ended up in 'emacs taking its toys and going home', leaving me with less colors than i started. however it is probably better. however maybe there should still be a makefile-show-shell-comments-too variable one could turn on so I won't run out of things to find bugs in :-) P> In the above example _none_ of that text is a makefile comment, because P> the entirety of any line beginning with a TAB is considered a command P> script, and make does not do any comment processing on command script P> lines (it can't, actually). P.S. if there is no TAB on the last line, it is indeed not colored, as to your specs... P> In short (too late...) the font-locking in makefile mode should ignore P> everything except make variables for colorization in a line that begins P> with a TAB (that's what make does, after all...) I think you mean makefile mode need not bother itself with any detail of lines beginning with tab, i.e. the only comment color in $ cat Makefile e=z #ppp z: echo $e f=g date would be #ppp -- http://jidanni.org/ Taiwan(04)25854780