From: Juri Linkov <juri@jurta.org>
To: Deniz Dogan <deniz.a.m.dogan@gmail.com>
Cc: 4240@emacsbugs.donarmstrong.com
Subject: bug#4240: 23.1.50; C-u doesn't work with Swedish characters
Date: Sun, 23 Aug 2009 21:54:04 +0300 [thread overview]
Message-ID: <87ljlas6nn.fsf@mail.jurta.org> (raw)
In-Reply-To: <7b501d5c0908230628r5bc2cad2he3fc7a2249fcac5@mail.gmail.com> (Deniz Dogan's message of "Sun, 23 Aug 2009 15:28:58 +0200")
> I hit "C-u ä" expecting it to come out as "ääää". Instead it comes out
> as "ä\344\344ä". I try "C-u C-u ä" and it comes out as "ä" followed by
> fourteen "\344" and then a trailing "ä". This happens no matter which
> kind of repetition I'm doing, be it using C-u or using e.g. M-3. It's
> always the leading and the trailing character that come out right, all
> of the other ones are "broken".
Please see bug#4037:
http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4037
I received no confirmation that my proposed fix is correct.
Maybe the right fix is to reverse negation? It seems logical to check
if a buffer is unibyte before converting from unibyte to multibyte, but
I don't understand what this code was supposed to do.
Index: src/cmds.c
===================================================================
RCS file: /sources/emacs/emacs/src/cmds.c,v
retrieving revision 1.107
diff -u -r1.107 cmds.c
--- src/cmds.c 13 Jul 2009 01:02:51 -0000 1.107
+++ src/cmds.c 10 Aug 2009 22:54:02 -0000
@@ -337,7 +337,7 @@
/* Add the offset to the character, for Finsert_char.
We pass internal_self_insert the unmodified character
because it itself does this offsetting. */
- if (! NILP (current_buffer->enable_multibyte_characters))
+ if (NILP (current_buffer->enable_multibyte_characters))
modified_char = unibyte_char_to_multibyte (modified_char);
XSETFASTINT (n, XFASTINT (n) - 2);
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-08-23 18:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83fxbccoca.fsf@gnu.org>
2009-08-04 19:27 ` bug#4037: Characters garbled in self-insert-command Juri Linkov
2009-08-28 8:55 ` bug#4037: marked as done (Characters garbled in self-insert-command) Emacs bug Tracking System
2009-08-23 13:28 ` bug#4240: 23.1.50; C-u doesn't work with Swedish characters Deniz Dogan
2009-08-23 18:54 ` Juri Linkov [this message]
2009-08-23 20:40 ` Eli Zaretskii
2009-08-26 17:08 ` Eli Zaretskii
2009-08-27 5:04 ` Stefan Monnier
2009-08-27 6:23 ` Kenichi Handa
2009-08-28 8:55 ` bug#4240: marked as done (23.1.50; C-u doesn't work with Swedish characters) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljlas6nn.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=4240@emacsbugs.donarmstrong.com \
--cc=deniz.a.m.dogan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).