From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#5436: 23.1.91; Deleting directories causes unusable file layout in freedesktop trashcan Date: Fri, 22 Jan 2010 11:20:25 -0500 Message-ID: <87ljfqkt6e.fsf@stupidchicken.com> References: <87d413k4eu.fsf@thinkpad.tsdh.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264178399 16189 80.91.229.12 (22 Jan 2010 16:39:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jan 2010 16:39:59 +0000 (UTC) Cc: Tassilo Horn , 5436@debbugs.gnu.org To: David De La Harpe Golden Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 22 17:39:51 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NYMY3-0003n0-3q for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jan 2010 17:39:51 +0100 Original-Received: from localhost ([127.0.0.1]:54829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYMY4-0007dU-5L for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jan 2010 11:39:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NYMXw-0007Ys-O5 for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 11:39:44 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NYMXr-0007UP-8c for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 11:39:43 -0500 Original-Received: from [199.232.76.173] (port=37502 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYMXq-0007U7-UH for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 11:39:38 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45851) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NYMXq-0001NW-Fo for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2010 11:39:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NYMFq-0008AX-3L; Fri, 22 Jan 2010 11:21:02 -0500 X-Loop: bug-gnu-emacs@gnu.org In-Reply-To: <87d413k4eu.fsf@thinkpad.tsdh.de> Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jan 2010 16:21:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5436 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5436-submit@debbugs.gnu.org id=B5436.126417723331386 (code B ref 5436); Fri, 22 Jan 2010 16:21:02 +0000 Original-Received: (at 5436) by debbugs.gnu.org; 22 Jan 2010 16:20:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYMFM-0008AB-Nq for submit@debbugs.gnu.org; Fri, 22 Jan 2010 11:20:32 -0500 Original-Received: from pantheon-po34.its.yale.edu ([130.132.50.80]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYMFK-0008A6-Nj for 5436@debbugs.gnu.org; Fri, 22 Jan 2010 11:20:31 -0500 Original-Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0MGKQMq027442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 22 Jan 2010 11:20:26 -0500 Original-Received: by furry (Postfix, from userid 1000) id F028CC05D; Fri, 22 Jan 2010 09:20:25 -0700 (MST) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.9 (--) Resent-Date: Fri, 22 Jan 2010 11:21:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34626 Archived-At: Hi David, Could you take a look at Bug#5436? Thanks. > I have `delete-by-moving-to-trash' enabled. When I delete a directory > with `M-x delete-directory' or using `D' in dired on a directory and say > that I want to delete it recursively, the freedesktop trashcan contains > entries for each file deleted, and not only one entry for the whole > directory. > > For example, I delete the directory ~/foo with these contents: > > ~/foo/ > ~/foo/bar/ > ~/foo/bar/test.txt > > After that, the freedesktop trashcan contains these Entries: > > --8<---------------cut here---------------start------------->8--- > /home/horn/.local/share/Trash/files: > total used in directory 20K available 70801444 > drwx------ 4 horn horn 4.0K Jan 21 13:42 . > drwxr-xr-x 4 horn horn 4.0K Jan 21 13:42 .. > drwxr-xr-x 2 horn horn 4.0K Jan 21 13:42 bar ### > drwxr-xr-x 2 horn horn 4.0K Jan 21 13:42 foo > -rw-r--r-- 1 horn horn 1 Jan 21 13:42 test.txt ### > > /home/horn/.local/share/Trash/info: > total used in directory 20K available 70801444 > drwx------ 2 horn horn 4.0K Jan 21 13:42 . > drwxr-xr-x 4 horn horn 4.0K Jan 21 13:42 .. > -rw-r--r-- 1 horn horn 74 Jan 21 13:42 bar.trashinfo ### > -rw-r--r-- 1 horn horn 70 Jan 21 13:42 foo.trashinfo > -rw-r--r-- 1 horn horn 83 Jan 21 13:42 test.txt.trashinfo ### > --8<---------------cut here---------------end--------------->8--- > > The lines marked with ### are wrong. `delete-directory' should keep the > structure of the deleted directory and move it as a whole to the trash. > Else, it's nearly impossible to restore the top level dir foo including > all contents again, and that's what the trashcan if for, right?