From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dave Abrahams <dave@boostpro.com>, 9597@debbugs.gnu.org
Subject: bug#9597: 23.3; [diff-mode] Can't quite cope with git patches
Date: Tue, 27 Sep 2011 03:03:50 +0300 [thread overview]
Message-ID: <87litax5wp.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvty80awgb.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 25 Sep 2011 22:08:34 -0400")
>> I suppose that modifying the buffer with inserting a newline
>> is a temporary workaround for some earlier bug, so I added
>> a check for the diff separator in another condition branch.
>
> No, it's not outdated.
> The issue is in diff-end-of-hunk where we can sometimes use the numbers
> but not always.
> Also, adding a newline makes the thing less ambiguous in cases such as
> when the user edits the hunks (in which case we need to update the hunk
> header based on the hunk text).
Maybe we should add an option that doesn't insert a newline
for users who don't want that viewing diff files modifies them.
next prev parent reply other threads:[~2011-09-27 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 19:41 bug#9597: 23.3; [diff-mode] Can't quite cope with git patches Dave Abrahams
2011-09-25 13:29 ` Juri Linkov
2011-09-26 2:08 ` Stefan Monnier
2011-09-27 0:03 ` Juri Linkov [this message]
2016-12-25 23:40 ` bug#9597: update Dima Kogan
2016-12-27 21:16 ` Juri Linkov
2016-12-27 23:56 ` Dima Kogan
2017-01-25 22:16 ` Dima Kogan
2017-01-27 9:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87litax5wp.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=9597@debbugs.gnu.org \
--cc=dave@boostpro.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).