From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Wed, 29 Feb 2012 12:04:39 +0100 Message-ID: <87linl529k.fsf@gmx.de> References: <87mx9su32g.fsf@web.de> <87k439gyu5.fsf@gmail.com> <87fwdwhizm.fsf@gmail.com> <87bookhfcn.fsf@gmail.com> <87aa44o7qo.fsf@gmail.com> <87ty2c490n.fsf@gmail.com> <87r4xgkt2b.fsf@gmail.com> <87obskum9i.fsf@gmx.de> <874nuc9bao.fsf@gmail.com> <874nubzdsu.fsf@gmail.com> <87zkc3xwdn.fsf@gmail.com> <87k437o1hm.fsf@gmx.de> <87booiu43h.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330513603 4134 80.91.229.3 (29 Feb 2012 11:06:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 29 Feb 2012 11:06:43 +0000 (UTC) Cc: 10489@debbugs.gnu.org, Thierry Volpiatto To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 29 12:06:42 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2hMk-0001hi-Oa for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Feb 2012 12:06:38 +0100 Original-Received: from localhost ([::1]:60696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hMe-0000UK-IK for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Feb 2012 06:06:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hMT-0000Th-Ea for bug-gnu-emacs@gnu.org; Wed, 29 Feb 2012 06:06:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2hMM-0003Ep-GD for bug-gnu-emacs@gnu.org; Wed, 29 Feb 2012 06:06:20 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hMM-0003Ei-Cw for bug-gnu-emacs@gnu.org; Wed, 29 Feb 2012 06:06:14 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S2hM9-0003Ne-Kc for bug-gnu-emacs@gnu.org; Wed, 29 Feb 2012 06:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Feb 2012 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.133051353412959 (code B ref 10489); Wed, 29 Feb 2012 11:06:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 29 Feb 2012 11:05:34 +0000 Original-Received: from localhost ([127.0.0.1]:55212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2hLh-0003Ml-47 for submit@debbugs.gnu.org; Wed, 29 Feb 2012 06:05:34 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:33456) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1S2hLL-0003Lx-Iz for 10489@debbugs.gnu.org; Wed, 29 Feb 2012 06:05:21 -0500 Original-Received: (qmail invoked by alias); 29 Feb 2012 11:04:51 -0000 Original-Received: from p57BB9B37.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.155.55] by mail.gmx.net (mp032) with SMTP; 29 Feb 2012 12:04:51 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19awIQVjpRanMM+xLZPwGfi3QEOTAP8PiAq3rZLr9 l1wT64H19UwqxG In-Reply-To: (Stefan Monnier's message of "Tue, 28 Feb 2012 21:01:09 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57393 Archived-At: Stefan Monnier writes: >>>> `files-equal-p' still returns t for two non-existing files. Shall be >>>> fixed too. >>> I don't see why that should be fixed: files-equal-p only works for >>> existing files. If one or both of the files don't exist, the return >>> value is unspecified. Oh, yes, the doc needs to be fixed to say it clearly. >> Why is this better than returning nil (which is easy to achieve)? > > It's not. I see. There might be optimizations in file name handlers, for example returning immediately t when both file names are identical. Maybe we could change the entry in files.texi like this: --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/emacs/doc/lispref/files.texi.~107463~ 2012-02-29 11:58:54.000000000 +0100 --- /home/albinus/src/emacs/doc/lispref/files.texi 2012-02-29 11:58:55.000000000 +0100 *************** *** 1020,1028 **** @defun file-equal-p file1 file2 This function returns @code{t} if the files @var{file1} and ! @var{file2} name the same file. Two ordinary files are considered to ! be the same if the function @code{file-attributes} (@pxref{File ! Attributes}) returns @code{equal} values for them. @end defun @defun file-subdir-of-p dir1 dir2 --- 1020,1034 ---- @defun file-equal-p file1 file2 This function returns @code{t} if the files @var{file1} and ! @var{file2} name the same file. If @var{file1} or @var{file2} does ! not exist, the return value is unspecified. ! ! If two files are equal, it does not imply that both file names specify ! accessible files. For example, @file{/sudo::/foo/bar} might be ! accessible, but @file{file:///foo/bar} might not. (@pxref{Remote ! Files,, Remote Files, emacs, The GNU Emacs Manual}, and ! @pxref{Supported URL Types,, Supported URL Types, url, URL ! Programmer's Manual}) @end defun @defun file-subdir-of-p dir1 dir2 --8<---------------cut here---------------end--------------->8--- > Stefan Best regards, Michael.