From: Sven Joachim <svenjoac@gmx.de>
To: Romain Francoise <romain@orebokech.com>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,
11514@debbugs.gnu.org, Katsumi Yamaoka <yamaoka@jpl.org>
Subject: bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc
Date: Mon, 21 May 2012 13:46:07 +0200 [thread overview]
Message-ID: <87likloiyo.fsf@turtle.gmx.de> (raw)
In-Reply-To: <87bollw5d3.fsf@silenus.orebokech.com> (Romain Francoise's message of "Fri, 18 May 2012 23:23:36 +0200")
On 2012-05-18 23:23 +0200, Romain Francoise wrote:
> If you put the following in /tmp/foo.el:
>
> (setq mail-user-agent 'gnus-user-agent
> gnus-message-archive-group "nnimap+foo:Sent")
>
> then start Emacs with `emacs -Q -l /tmp/foo.el' then do `C-x m', the
> resulting Message buffer doesn't have a Gcc header. In Emacs 23 and
> 24.0.92, the Gcc header was (correctly, I think) added to the buffer.
>
> Note: whether or not Gnus is started beforehand doesn't make a difference.
This seems to have been introduced by the following change in the
emacs-24 branch:
,----
| revno: 107813
| author: Lars Magne Ingebrigtsen <larsi@gnus.org>
| committer: Katsumi Yamaoka <yamaoka@jpl.org>
| branch nick: emacs-24
| timestamp: Wed 2012-04-11 22:31:16 +0000
| message:
| gnus-art.el (article-wash-html): Fix non-ASCII characters when washing HTML (bug#7410).
| gnus-msg.el (gnus-inews-insert-gcc): Protect against when we don't have a group name.
| gnus-start.el (gnus-read-newsrc-el-file): Protect against broken .newsrc.el files.
`----
The diff for gnus-msg.el is this:
--8<---------------cut here---------------start------------->8---
=== modified file 'lisp/gnus/gnus-msg.el'
--- lisp/gnus/gnus-msg.el 2012-03-14 22:15:04 +0000
+++ lisp/gnus/gnus-msg.el 2012-04-11 22:31:16 +0000
@@ -1670,11 +1670,13 @@ this is a reply."
(not
(setq result
(cond
- ((stringp (caar var))
+ ((and group
+ (stringp (caar var)))
;; Regexp.
(when (string-match (caar var) group)
(cdar var)))
- ((functionp (car var))
+ ((and group
+ (functionp (car var)))
;; Function.
(funcall (car var) group))
(t
--8<---------------cut here---------------end--------------->8---
It corresponds to commit bf5aff3ff7c87 in the no-gnus branch in Gnus
git.
Cheers,
Sven
next prev parent reply other threads:[~2012-05-21 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 21:23 bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc Romain Francoise
2012-05-21 11:46 ` Sven Joachim [this message]
2012-05-21 23:29 ` Katsumi Yamaoka
2012-05-22 7:38 ` Romain Francoise
2012-06-07 23:00 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87likloiyo.fsf@turtle.gmx.de \
--to=svenjoac@gmx.de \
--cc=11514@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=romain@orebokech.com \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).