From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christopher Schmidt Newsgroups: gmane.emacs.bugs Subject: bug#11156: 24.2.50; require-final-newline and read-only files (was: bug#11156: 24.0.95; require-final-newline and read-only files) Date: Sun, 2 Sep 2012 19:55:34 +0100 (BST) Message-ID: <87ligsw8yy.fsf_-_@earth.home> References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> <4F89C879.6070209@gmx.at> <20120415134821.0001E20235@saturn.ch.ristopher.com> <87k41d4kvj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1346612200 20550 80.91.229.3 (2 Sep 2012 18:56:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Sep 2012 18:56:40 +0000 (UTC) To: 11156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 02 20:56:41 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T8FLd-0004vB-Bd for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Sep 2012 20:56:41 +0200 Original-Received: from localhost ([::1]:49284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FLa-0007bq-D6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Sep 2012 14:56:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FLX-0007bl-HD for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:56:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8FLW-0001Yu-Jj for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:56:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FLW-0001Yq-GR for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:56:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T8FMw-00028F-7Z for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Sep 2012 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13466122308135 (code B ref -1); Sun, 02 Sep 2012 18:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Sep 2012 18:57:10 +0000 Original-Received: from localhost ([127.0.0.1]:34826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8FM5-000279-6K for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:57:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42352) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8FM3-000273-9u for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8FKc-0001M6-IJ for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:55:39 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:58850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FKc-0001M2-F6 for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:55:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FKb-0007aU-K2 for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:55:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8FKa-0001Lq-Og for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:55:37 -0400 Original-Received: from ristopher.com ([146.185.21.93]:54233 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FKa-0001Lm-FJ for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:55:36 -0400 Original-Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 8EFE020D26; Sun, 2 Sep 2012 19:55:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1346612134; bh=t0nKWigAP26gsZRp0f8LxdxsOD/heVa8nYisOWo0axg=; h=From:To:Subject:In-Reply-To:References:Message-ID:MIME-Version: Content-Type:Date; b=Gsg9HuOkTBZGUyc7/b3MYy8iA93fb/rdAr1Il6hldeQS70dxTdQNft+ll+JaV8Tz/ BqwfvLqrlTKRdM3mHI7UTTiK6VuQRf6S1jStXutukPzdX1pUnfHtagAjZIiPbUU/Sz ld720LEW7lBUzpMHiIsO8sLQ12EWj39Vv/u1M0Cg= In-Reply-To: <87k41d4kvj.fsf@gnu.org> (Chong Yidong's message of "Wed, 18 Apr 2012 14:25:20 +0800") Mail-Followup-To: bug-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63685 Archived-At: reopen 11156 Chong Yidong writes: > Christopher Schmidt writes: > >>> `after-find-file' shouldn't try adding a newline if >>> `buffer-read-only' is non-nil. And the values 'visit and >>> 'visit-save should be documented in the Elisp manual. >> >> === modified file 'doc/lispref/ChangeLog' >> ... > > Thanks, committed to the repository. There is still a minor bug in regard to require-final-newline. Recipe: emacs -q M-: (setq require-final-newline 'visit) Open an image file via C-x C-f There is a new buffer but no window displays it. The *Messages*-buffer contains "find-file-noselect-1: Text is read-only". This is because image-mode sets the read-only property of the whole buffer string to t. buffer-read-only is nil in this case, though. I think all code fragments that try to add new lines due to require-final-newline should ignore text-read-only errors. Christopher