From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#14317: 24.3.50; nadvice.el: named advices not upgradable Date: Fri, 03 May 2013 03:20:42 +0200 Message-ID: <87li7w7tat.fsf@web.de> References: <87mwsgx5t5.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367544094 14224 80.91.229.3 (3 May 2013 01:21:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 May 2013 01:21:34 +0000 (UTC) To: 14317@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 03 03:21:32 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UY4gk-0005Ix-Nf for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2013 03:21:30 +0200 Original-Received: from localhost ([::1]:59112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UY4gk-0007mo-2Z for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2013 21:21:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UY4gg-0007mi-At for bug-gnu-emacs@gnu.org; Thu, 02 May 2013 21:21:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UY4gf-0003dd-F8 for bug-gnu-emacs@gnu.org; Thu, 02 May 2013 21:21:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UY4gf-0003dS-Bh for bug-gnu-emacs@gnu.org; Thu, 02 May 2013 21:21:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UY4hG-00083u-2D for bug-gnu-emacs@gnu.org; Thu, 02 May 2013 21:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2013 01:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14317-submit@debbugs.gnu.org id=B14317.136754409730873 (code B ref 14317); Fri, 03 May 2013 01:22:01 +0000 Original-Received: (at 14317) by debbugs.gnu.org; 3 May 2013 01:21:37 +0000 Original-Received: from localhost ([127.0.0.1]:55979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UY4gm-00081V-J8 for submit@debbugs.gnu.org; Thu, 02 May 2013 21:21:37 -0400 Original-Received: from mout.web.de ([212.227.15.4]:54509) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UY4gg-000812-6W for 14317@debbugs.gnu.org; Thu, 02 May 2013 21:21:31 -0400 Original-Received: from drachen.dragon ([89.204.130.13]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0MOAmi-1UdYrK40c0-006EmL; Fri, 03 May 2013 03:20:47 +0200 In-Reply-To: <87mwsgx5t5.fsf@web.de> (Michael Heerdegen's message of "Tue, 30 Apr 2013 01:42:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V02:K0:H/Eww58zZK02Q+WN9s6GKyQ2Y/HYXMZquVOAWNWhioe m5cLt1bfDUlS0ogB+FZFYyk08U/4OBs63JOucxqXlL6RKmC7rm gab/wJYUwKYI39KolvEjyghpmEiKtaygIROEj/z1x6ULeRnNSF xhKvJkSqV8jTxcP7AplS9tWNR1wQ2NuzRTHjKBWT83j/l17vcy 8dqmCVJABxrDYUWicIB14kUCu6kDETuvE3ZA8mA3NQ= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73903 Archived-At: Michael Heerdegen writes: > but as a user, I would suspect something like > > (defun advice--add-function (where ref function props) > (when (advice--member-p function (cdr (assq 'name props)) > (gv-deref ref)) > (advice--remove-function .........)) > (setf (gv-deref ref) > (advice--make where function (gv-deref ref) props))) > > i.e., replacing the old code, instead of doing nothing. We should probably distinguish between named functions and named advice. I mean, it's probably stupid to remove and add back an fboundp symbol - but you get the idea... Regards, Michael.