From: Michael Heerdegen <michael_heerdegen@web.de>
To: 14317@debbugs.gnu.org
Subject: bug#14317: 24.3.50; nadvice.el: named advices not upgradable
Date: Fri, 03 May 2013 03:20:42 +0200 [thread overview]
Message-ID: <87li7w7tat.fsf@web.de> (raw)
In-Reply-To: <87mwsgx5t5.fsf@web.de> (Michael Heerdegen's message of "Tue, 30 Apr 2013 01:42:14 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> but as a user, I would suspect something like
>
> (defun advice--add-function (where ref function props)
> (when (advice--member-p function (cdr (assq 'name props))
> (gv-deref ref))
> (advice--remove-function .........))
> (setf (gv-deref ref)
> (advice--make where function (gv-deref ref) props)))
>
> i.e., replacing the old code, instead of doing nothing.
We should probably distinguish between named functions and
named advice. I mean, it's probably stupid to remove and add
back an fboundp symbol - but you get the idea...
Regards,
Michael.
next prev parent reply other threads:[~2013-05-03 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 23:42 bug#14317: 24.3.50; nadvice.el: named advices not upgradable Michael Heerdegen
2013-05-03 1:20 ` Michael Heerdegen [this message]
2013-05-05 5:49 ` Stefan Monnier
2013-05-06 15:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li7w7tat.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=14317@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).