From: Andreas Politz <politza@hochschule-trier.de>
To: 14776@debbugs.gnu.org
Subject: bug#14776: 24.3.50; [PATCH] parse-time-string performance
Date: Thu, 04 Jul 2013 17:41:29 +0200 [thread overview]
Message-ID: <87li5m1geu.fsf@hochschule-trier.de> (raw)
In-Reply-To: <lu1u7gfhak.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 02 Jul 2013 23:34:11 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Glenn Morris wrote:
>
>> Why is it called 30+ times per article? Naively, seems like a chance for
>> a ~ 30x speed-up, compared to the ~ 4x one you seem to achieve.
>
> Oh, parse-time-string-chars, not parse-time-string. Ignore me.
Yes, but I just noticed something different.
In my benchmark the unpatched function runs for 41.5s on 100*3000 calls,
which comes down to an average of 0.415s per 3000 dates (or articles in
a summary buffer displaying parsed dates). This should actually not be
very noticeable.
But it was. It took gnus ~40s to display this amount of articles and
most of it was spend in parse-time-string. After tweaking it (i.e. the
patch) it came down to ~10s. Now, looking more closely at the above,
non-gnus numbers, this makes no sense. (Though it's appealing to jump to
a conclusion, because it appears to be the correct factor.)
I should have tested this with -Q. The reason is a customized
gc-cons-percentage (0.2) and gc-cons-threshold (67108864). Using the
default values shows almost no difference anymore in gnus, i.e. both
versions (stock and patched) need around ~10s.
I suppose there are various lessons to learn from this endeavour.
-ap
next prev parent reply other threads:[~2013-07-04 15:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 1:21 bug#14776: 24.3.50; [PATCH] parse-time-string performance Andreas Politz
2013-07-03 1:27 ` Andreas Politz
2013-07-03 3:32 ` Glenn Morris
2013-07-03 3:34 ` Glenn Morris
2013-07-04 15:41 ` Andreas Politz [this message]
2013-07-04 18:41 ` Lars Magne Ingebrigtsen
2013-07-04 19:47 ` Andreas Politz
2013-07-04 20:31 ` Lars Magne Ingebrigtsen
2013-07-04 21:08 ` Andreas Politz
2013-07-04 21:15 ` Lars Magne Ingebrigtsen
[not found] ` <87hagaeztj.fsf@hochschule-trier.de>
2013-07-06 15:34 ` Lars Ingebrigtsen
2013-07-06 15:50 ` Andreas Politz
2013-07-06 15:56 ` Lars Ingebrigtsen
2013-07-06 16:07 ` Andreas Politz
2013-07-06 17:47 ` Andreas Politz
2013-07-08 14:51 ` Lars Magne Ingebrigtsen
2016-03-01 1:05 ` Lars Ingebrigtsen
2019-06-27 11:12 ` Lars Ingebrigtsen
2013-07-04 22:21 ` Andreas Politz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li5m1geu.fsf@hochschule-trier.de \
--to=politza@hochschule-trier.de \
--cc=14776@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).